u-boot.git/lib, branch v2021.07-rc3

sandbox: errno: avoid conflict with libc's errno

2021-05-24T18:21:30Z

When building with LTO, the system libc's `errno` variable used in arch/sandbox/cpu/os.c conflicts with U-Boot's `errno` (defined in lib/errno.c) with the following error: .../ld: errno@@GLIBC_PRIVATE: TLS definition in /lib64/libc.so.6 section .tbss mismatches non-TLS reference in /tmp/u-boot.EQlEXz.ltrans0.ltrans.o To avoid this conflict use different asm label for this variable when CONFIG_SANDBOX is enabled. Signed-off-by: Marek Behún Reviewed-by: Bin Meng Reviewed-by: Simon Glass

lib: crc32: put the crc_table variable into efi_runtime_rodata section

2021-05-24T18:21:30Z

When compiling with LTO, the compiler fails with an error saying that `crc_table` causes a section type conflict with `efi_var_buf`. This is because both are declared to be in the same section (via macro `__efi_runtime_data`), but one is const while the other is not. Put this variable into the section .rodata.efi_runtime, instead of .data.efi_runtime, via macro __efi_runtime_rodata. Signed-off-by: Marek Behún Reviewed-by: Marek Vasut Reviewed-by: Heinrich Schuchardt

efi_selftest: compiler flags for efi_selftest_miniapp_exception.o

2021-05-24T18:21:30Z

Add $(CFLAGS_EFI) and remove $(CFLAGS_NON_EFI) for efi_selftest_miniapp_exception.o. The removal is needed when compiling with LTO - this object file needs to be compiled without -flto. The adding is for consistency with other miniapps. Signed-off-by: Marek Behún Reviewed-by: Heinrich Schuchardt

string: make memcpy(), memset(), memcmp() and memmove() visible for LTO

2021-05-24T18:21:30Z

It seems that sometimes (happening on ARM64, for example with turris_mox_defconfig) GCC, when linking with LTO, changes the symbol names of some functions, for example lib/string.c's memcpy() function to memcpy.isra.0. This is a problem however when GCC for a code such as this: struct some_struct *info = get_some_struct(); struct some struct tmpinfo; tmpinfo = *info; emits a call to memcpy() by builtin behaviour, to copy *info to tmpinfo. This then results in the following linking error: .../lz4.c:93: undefined reference to `memcpy' .../uuid.c:206: more undefined references to `memcpy' follow GCC's documentation says this about -nodefaultlibs option: The compiler may generate calls to "memcmp", "memset", "memcpy" and "memmove". These entries are usually resolved by entries in libc. These entry points should be supplied through some other mechanism when this option is specified. Make these functions visible by using the __used macro to avoid this error. Signed-off-by: Marek Behún Reviewed-by: Simon Glass

treewide: Convert macro and uses of section(foo) to section("foo")

2021-05-24T18:21:30Z

This commit does the same thing as Linux commit 33def8498fdd. Use a more generic form for __section that requires quotes to avoid complications with clang and gcc differences. Remove the quote operator # from compiler_attributes.h __section macro. Convert all unquoted __section(foo) uses to quoted __section("foo"). Also convert __attribute__((section("foo"))) uses to __section("foo") even if the __attribute__ has multiple list entry forms. Signed-off-by: Marek Behún Reviewed-by: Bin Meng Reviewed-by: Simon Glass

lib: kconfig: Limit BINMAN_FDT for OF_SEPARATE or OF_EMBED

2021-05-19T09:01:50Z

Generally speaking BINMAN_FDT makes sense for OF_SEPARATE or OF_EMBED. For the other OF_CONTROL methods, it's quite possible binman node is not available as binman is invoked during the build phase instead of runtime. Let's only turn it on for OF_SEPARATE or OF_EMBED by default. Signed-off-by: Bin Meng Reviewed-by: Simon Glass

lib: introduce HASH_CALCULATE option

2021-05-18T10:36:13Z

Build error occurs when CONFIG_EFI_SECURE_BOOT or CONFIG_EFI_CAPSULE_AUTHENTICATE is enabled, because hash-checksum.c is not compiled. Since hash_calculate() implemented in hash-checksum.c can be commonly used aside from FIT image signature verification, this commit itroduces HASH_CALCULATE option to decide if hash-checksum.c shall be compiled. Signed-off-by: Masahisa Kojima Reviewed-by: Heinrich Schuchardt

efi_loader: Fix Kconfig for EFI_TCG2 protocol

2021-05-18T10:36:13Z

EFI_TCG2 depends not only on TPMv2 but also on the underlying algorithms. So select the missing SHA1, SHA256, SHA384 and SHA512 we currently support Reported-by: Michal Simek Signed-off-by: Ilias Apalodimas Add 'default y'. Reviewed-by: Heinrich Schuchardt

efi_loader: Don't stop EFI subsystem init if installing TCG2 fails

2021-05-18T10:36:13Z

Up to now we are stopping the EFI subsystem if a TPMv2 exists but the protocol fails to install. Now that we've switched the config to 'default y' the sandbox TPM fails, since it doesn't support all the required capabilities of the protocol. Not installing the protocol is not catastrophic. If the protocol fails to install the PCRs will never be extended to the expected values, so some other entity later in the boot flow will eventually figure it out and take the necessary actions. While at it fix a corner case were the user can see an invalid error message when the protocol failed to install. We do have a tcg2_uninit() which we call when the protocol installation fails. There are cases though that this might be called before the configuration table is installed (e.g probing the TPM for capabilities failed). In that case the user will see "Failed to delete final events config table". So stop printing it since it's not an actual failure , simply because the config table was never installed in the first place. In order to stop printing it make efi_init_event_log() and create_final_event() cleanup themselves and only call tcg2_uninit() when the protocol installation fails. Signed-off-by: Ilias Apalodimas Reviewed-by: Heinrich Schuchardt

efi_loader: Uninstall the TCG2 protocol if logging s-crtm fails

2021-05-18T10:36:13Z

Instead of just failing, clean up the installed config table and EventLog memory if logging an s-crtm event fails during the protocol installation Signed-off-by: Ilias Apalodimas Eliminate label 'out:' by using return. Reviewed-by: Heinrich Schuchardt

u-boot.git/lib, branch v2021.07-rc3

sandbox: errno: avoid conflict with libc's errno

lib: crc32: put the crc_table variable into efi_runtime_rodata section

efi_selftest: compiler flags for efi_selftest_miniapp_exception.o

string: make memcpy(), memset(), memcmp() and memmove() visible for LTO

treewide: Convert macro and uses of __section(foo) to __section("foo")

lib: kconfig: Limit BINMAN_FDT for OF_SEPARATE or OF_EMBED

lib: introduce HASH_CALCULATE option

efi_loader: Fix Kconfig for EFI_TCG2 protocol

efi_loader: Don't stop EFI subsystem init if installing TCG2 fails

efi_loader: Uninstall the TCG2 protocol if logging s-crtm fails

treewide: Convert macro and uses of section(foo) to section("foo")