u-boot.git/lib, branch v2022.04-rc2

efi_loader: fix dual signed image certification

2022-02-11T19:07:55+00:00

The EFI spec allows for images to carry multiple signatures. Currently
we don't adhere to the verification process for such images.

The spec says:
"Multiple signatures are allowed to exist in the binary's certificate
table (as per PE/COFF Section "Attribute Certificate Table"). Only one
hash or signature is required to be present in db in order to pass
validation, so long as neither the SHA-256 hash of the binary nor any
present signature is reflected in dbx."

With our current implementation signing the image with two certificates
and inserting both of them in db and one of them dbx doesn't always reject
the image.  The rejection depends on the order that the image was signed
and the order the certificates are read (and checked) in db.

While at it move the sha256 hash verification outside the signature
checking loop, since it only needs to run once per image and get simplify
the logic for authenticating an unsigned imahe using sha256 hashes.

Signed-off-by: Ilias Apalodimas

acpi: Move MCFG implementation to common lib

2022-02-09T19:30:13+00:00

MCFG tables are used on multiple arches. Move to common ACPI lib.

Cc: Simon Glass 
Signed-off-by: Moritz Fischer 
Reviewed-by: Simon Glass 
Use sizeof(*mcfg) instead of sizeof(*header)
Signed-off-by: Simon Glass

efi: Drop unnecessary calls to blk_find_device()

2022-02-05T19:20:01+00:00

When we have the block descriptor we can simply access the device. Drop
the unnecessary function call.

Signed-off-by: Simon Glass 
Reviewed-by: Heinrich Schuchardt

efi: Use device_get_uclass_id() where appropriate

2022-02-05T19:20:01+00:00

Use this function rather than following the pointers, since it is there
for this purpose.

Add the uclass name to the debug call at the end of dp_fill() since it is
quite useful.

Signed-off-by: Simon Glass 
Reviewed-by: Heinrich Schuchardt

efi_loader: add handle for UART

2022-02-05T19:20:01+00:00

When loading an EFI binary via the UART we assign a UART device path to it.
But we lack a handle with that device path.

Signed-off-by: Heinrich Schuchardt

efi_loader: fix text output for Uart() DP nodes

2022-02-05T19:20:01+00:00

The UEFI specification concerning Uart() device path nodes has been
clarified:

Parity and stop bits can either both use keywords or both use
numbers but numbers and keywords should not be mixed.

Let's go for keywords as this is what EDK II does. For illegal
values fall back to numbers.

Signed-off-by: Heinrich Schuchardt

efi_loader: use %zu to print efi_uintn_t in FMP driver

2022-02-05T19:20:01+00:00

For printing an unsigned value we should use %u and not %d.

Signed-off-by: Heinrich Schuchardt

efi_loader: use %zu not %zd to print efi_uintn_t

2022-02-05T19:20:01+00:00

efi_uintnt_t is an unsigned type. We should avoid showing negative numbers.

Signed-off-by: Heinrich Schuchardt

efi_loader: fix device path to text protocol

2022-02-05T19:20:01+00:00

The printing of a file path node must properly handle:

* odd length of the device path node
* UTF-16 character only partially contained in device path node
* buffer overflow due to very long file path

Signed-off-by: Heinrich Schuchardt

lib: fix snprintf() for UTF-16 strings

2022-02-05T19:20:01+00:00

snprintf() must return the required buffer length.

Signed-off-by: Heinrich Schuchardt