u-boot.git/net/arp.c, branch v2019.10

net: Don't overwrite waiting packets with asynchronous replies

2018-10-10T17:29:01Z

Peter originally sent a fix, but it breaks a number of other things. This addresses the original reported issue in a different way. That report was: > U-Boot has 1 common buffer to send Ethernet frames, pointed to by > net_tx_packet. When sending to an IP address without knowing the MAC > address, U-Boot makes an ARP request (using the arp_tx_packet buffer) > to find out the MAC address of the IP addressr. When a matching ARP > reply is received, U-Boot continues sending the frame stored in the > net_tx_packet buffer. > > However, in the mean time, if U-Boot needs to send out any network > packets (e.g. replying ping packets or ARP requests for its own IP > address etc.), it will use the net_tx_packet buffer to prepare the > new packet. Thus this buffer is no longer the original packet meant > to be transmitted after the ARP reply. The original packet will be > lost. This instead uses the ARP tx buffer to send async replies in the case where we are actively waiting for an ARP reply. Signed-off-by: Joe Hershberger Reported-by: Tran Tien Dat Reviewed-by: Simon Glass Reviewed-by: Bin Meng Tested-by: Bin Meng

net: Add an accessor to know if waiting for ARP

2018-10-10T17:28:58Z

This single-sources the state of the ARP. Signed-off-by: Joe Hershberger Reviewed-by: Simon Glass Reviewed-by: Bin Meng

net: Always align tx packets

2018-06-13T18:54:15Z

Make sure that TX packets are always cache-aligned. Signed-off-by: Mario Six Acked-by: Joe Hershberger

SPDX: Convert a few files that were missed before

2018-05-11T00:38:35Z

As part of the main conversion a few files were missed. These files had additional whitespace after the '*' and before the SPDX tag and my previous regex was too strict. This time I did a grep for all SPDX tags and then filtered out anything that matched the correct styles. Fixes: 83d290c56fab ("SPDX: Convert all of our single license tags to Linux Kernel style") Reported-by: Heinrich Schuchardt Signed-off-by: Tom Rini

env: Rename setenv() to env_set()

2017-08-16T12:22:18Z

We are now using an env_ prefix for environment functions. Rename setenv() for consistency. Also add function comments in common.h. Suggested-by: Wolfgang Denk Signed-off-by: Simon Glass

net/arp: remove superfluous assignments

2017-05-12T12:37:19Z

The value of variable pkt is never used. The problem was indicated by clang scan-build. Signed-off-by: Heinrich Schuchardt

net/arp: account for ARP delay, avoid duplicate packets on timeout

2015-10-28T19:57:37Z

eth_rx() in the main reception loop may trigger sending a packet which is already timed out (or will immediately) upon reception of an ARP reply. As long as the ARP reply is pending, the timeout handler of a packet should be postponed. Happens on TFTP with bad network (e.g. WLAN). Signed-off-by: Stefan Brüns Acked-by: Joe Hershberger

net/arp: Do not run net_start_again() on timeout

2015-10-28T19:57:00Z

net_start_again() will be called from net_loop() if state is NETLOOP_FAIL. Signed-off-by: Stefan Brüns Acked-by: Joe Hershberger

net: cosmetic: Fix checkpatch.pl failures in net.c

2015-04-18T17:11:35Z

Finish eliminating CamelCase from net.c and other failures Signed-off-by: Joe Hershberger Acked-by: Simon Glass

net: cosmetic: Clean up ARP variables and functions

2015-04-18T17:11:33Z

Make a thorough pass through all variables and function names contained within arp and remove CamelCase and improve naming. Signed-off-by: Joe Hershberger Acked-by: Simon Glass