u-boot.git/net/bootp.c, branch v2015.07

net: Fix incorrect DHCP/BOOTP packets on 64-bit systems

2015-04-18T17:11:35+00:00

This commit fixes incorrect DHCP/BOOTP packet layout caused by
'ulong' type size difference on 64 and 32-bit architectures.
It also renames NetReadLong()/NetCopyLong() to
net_read_u32/net_copy_u32() accordingly.

Signed-off-by: Radha Mohan Chintakuntla 
Signed-off-by: Sergey Temerkhanov 
Signed-off-by: Joe Hershberger 
Acked-by: Simon Glass

net: cosmetic: Fix checkpatch.pl failures in net.c

2015-04-18T17:11:35+00:00

Finish eliminating CamelCase from net.c and other failures

Signed-off-by: Joe Hershberger 
Acked-by: Simon Glass

net: cosmetic: Clean up DHCP variables and functions

2015-04-18T17:11:33+00:00

Make a thorough pass through all variables and function names contained
within bootp.c and remove CamelCase and improve naming.

Signed-off-by: Joe Hershberger 
Acked-by: Simon Glass

net: cosmetic: Cleanup internal packet buffer names

2015-04-18T17:11:32+00:00

This patch cleans up the names of internal packet buffer names that are
used within the network stack and the functions that use them.

Signed-off-by: Joe Hershberger

net: cosmetic: Name ethaddr variables consistently

2015-04-18T17:11:32+00:00

Use "_ethaddr" at the end of variables and drop CamelCase.
Make constant values actually 'const'.

Signed-off-by: Joe Hershberger 
Acked-by: Simon Glass

net: cosmetic: Fixup var names for DHCP strings

2015-04-18T17:11:32+00:00

Remove CamelCase variable naming.
Move the definition to the same compilation unit as the primary use.

Signed-off-by: Joe Hershberger 
Acked-by: Simon Glass

net: cosmetic: Fixup var names related to boot file

2015-04-18T17:11:32+00:00

The variables around the bootfile were inconsistent and used CamelCase.
Update them to make the code more readable.

Signed-off-by: Joe Hershberger 
Acked-by: Simon Glass

net: cosmetic: Change IPaddr_t to struct in_addr

2015-04-18T17:11:32+00:00

This patch is simply clean-up to make the IPv4 type that is used match
what Linux uses. It also attempts to move all variables that are IP
addresses use good naming instead of CamelCase. No functional change.

Signed-off-by: Joe Hershberger 
Acked-by: Simon Glass

net: bootp: as CONFIG_BOOTP_SERVERIP is defined, keep bootfile not changed

2014-12-08T14:35:41+00:00

Currenly when CONFIG_BOOTP_SERVERIP is defined, the SERVERIP is not changed
when receive the BOOTP packet. But BOOTFILE is changed via BOOTP packet.

As we will load the BOOTFILE from SERVERIP, if the BOOTFILE is modified
by bootp packet but SERVERIP is not, that is not make sense.

This patch make SERVERIP and BOOTFILE be consistent. If we define the
CONFIG_BOOTP_SERVERIP, then SERVERIP and BOOTFILE will not changed by
BOOTP packet. Only IP address is changed.

Signed-off-by: Josh Wu

net: More BOOTP retry timeout improvements

2014-08-21T16:01:30+00:00

It's not unusual for DHCP servers to take a couple hundred milliseconds
to respond to DHCP discover messages. One possible reason for the delay
can be that the server checks (typically using an ARP request) that the
IP it's about to hand out isn't in use yet. To make matters worse, some
servers may also queue up requests and process them sequentially, which
can cause excessively long delays if clients retry too fast.

Commit f59be6e850b3 ("net: BOOTP retry timeout improvements") shortened
the retry timeouts significantly, but the BOOTP/DHCP implementation in
U-Boot doesn't handle that well because it will ignore incoming replies
to earlier requests. In one particular setup this increases the time it
takes to obtain a DHCP lease from 630 ms to 8313 ms.

This commit attempts to fix this in two ways. First it increases the
initial retry timeout from 10 ms to 250 ms to give DHCP servers some
more time to respond. At the same time a cache of outstanding DHCP
request IDs is kept so that the implementation will know to continue
transactions even after a retransmission of the DISCOVER message. The
maximum retry timeout is also increased from 1 second to 2 seconds. An
ID cache of size 4 will keep DHCP requests around for 8 seconds (once
the maximum retry timeout has been reached) before dropping them. This
should give servers plenty of time to respond. If it ever turns out
that this isn't enough, the size of the cache can easily be increased.

With this commit the DHCP lease on the above-mentioned setup still takes
longer (1230 ms) than originally, but that's an acceptable compromise to
improve DHCP lease acquisition time for a broader range of setups.

To make it easier to benchmark DHCP in the future, this commit also adds
the time it took to obtain a lease to the final "DHCP client bound to
address x.x.x.x" message.

Tested-by: Stephen Warren 
Signed-off-by: Thierry Reding