u-boot.git/net/dsa-uclass.c, branch master

net: dsa: Fix OF fallback lookup for ports

2023-06-14T10:38:25+00:00

The variable 'node' was already invalid, so using it for further
lookup will not work.

Signed-off-by: Marcus Comstedt 
Reviewed-by: Claudiu Manoil 
Signed-off-by: Peng Fan

net: dsa: allow rcv() and xmit() to be optional

2023-02-02T19:22:08+00:00

Allow rcv() and xmit() dsa driver ops to be optional in case a driver
does not care to mangle a packet as in U-Boot only one network port is
enabled at a time and thus no packet mangling is necessary.

Suggested-by: Vladimir Oltean 
Signed-off-by: Tim Harvey 
Reviewed-by: Vladimir Oltean 
Reviewed-by: Fabio Estevam 
Signed-off-by: Tim Harvey

net: dsa: ensure dsa driver has proper ops

2023-02-02T19:22:08+00:00

Add a function to sanity check a dsa driver having proper ops.

Suggested-by: Vladimir Oltean 
Signed-off-by: Tim Harvey 
Reviewed-by: Vladimir Oltean 
Reviewed-by: Fabio Estevam

net: dsa: move cpu port probe to dsa_post_probe

2023-02-02T19:22:08+00:00

In order to ensure that a DSA driver probe gets called before
dsa_ops->port_probe move the port_probe of the cpu_port to
a post-probe function.

Signed-off-by: Tim Harvey 
Reviewed-by: Ramon Fried 
Reviewed-by: Vladimir Oltean 
Reviewed-by: Fabio Estevam

dm: core: Drop ofnode_is_available()

2022-09-29T20:11:31+00:00

This function is also available as ofnode_is_enabled(), so use that
instead.

Signed-off-by: Simon Glass

net: dsa: Fix segmentation fault if master fails to probe

2022-06-08T17:59:53+00:00

If the DSA master fails to probe for whatever reason, then DSA devices
will continue on as if nothing is wrong. This can cause incorrect
behavior. In particular, on sandbox, dsa_sandbox_probe attempts to
access the master's private data. This is only safe to do if the master
has been probed first. Fix this by probing the master after we look it
up, and bailing out if we get an error.

Fixes: fc054d563b ("net: Introduce DSA class for Ethernet switches")
Signed-off-by: Sean Anderson 
Reviewed-by: Vladimir Oltean

net: dsa: fix phydev->speed being uninitialized for the CPU port fixed PHY

2022-01-15T16:49:03+00:00

If the DSA API is going to allow drivers to do things such as:

- phy_config in dsa_ops :: port_probe
- phy_startup in dsa_ops :: port_enable

then it would actually be good if the ->port_probe() method would
actually be called in all cases before the ->port_enable() is.

Currently this is true for user ports, but not true for the CPU port,
because the CPU port does not have a udevice registered for it (this is
all part of DSA's design). So the current issue is that after
phy_startup has finished for the CPU port, its phydev->speed is an
uninitialized value, because phy_config() was never called for the
priv->cpu_port_fixed_phy, and it is precisely phy_config() who copies
the speed into the phydev in the case of the fixed PHY driver.

So we need to simulate a probing event for the CPU port by manually
calling the driver's ->port_probe() method for the CPU port.

Fixes: 8a2982574854 ("net: dsa: introduce a .port_probe() method in struct dsa_ops")
Signed-off-by: Vladimir Oltean 
Reviewed-by: Ramon Fried

net: dsa: Use true instead of 1 in the set_promisc() call

2021-11-23T07:57:56+00:00

set_promisc() call accepts the parameter of a bool type. Make it
clear by using true instead of 1.

Signed-off-by: Bin Meng 
Reviewed-by: Vladimir Oltean 
Reviewed-by: Ramon Fried

net: dsa: allow drivers to get the port OF node

2021-11-23T07:57:55+00:00

In the current DSA switch driver API, only the udevice of the switch
(belonging to UCLASS_DSA) is exposed, as well as an "int port" argument.
So drivers do not have access to the udevice of individual ports
(belonging to UCLASS_ETH), one of the reasons being that not all ports
have an associated UCLASS_ETH udevice.

However, all DSA ports have an OF node, and in some cases the driver
needs a handle to it, for all ports including the CPU port. Example: the
following Linux per-port device tree property:

	managed = "in-band-status";

states whether a port should operate with clause 37 in-band autoneg
enabled or not.

This patch exposes a function which can be called by individual drivers
as needed.

Signed-off-by: Vladimir Oltean 
Reviewed-by: Ramon Fried

net: dsa: ensure port names are NULL-terminated after DSA_PORT_NAME_LENGTH truncation

2021-09-28T15:50:57+00:00

strncpy() simply bails out when copying a source string whose size
exceeds the destination string size, potentially leaving the destination
string unterminated.

One possible way to address is to pass DSA_PORT_NAME_LENGTH - 1 and a
previously zero-initialized destination string, but this is more
difficult to maintain.

The chosen alternative is to use strlcpy(), which properly limits the
copy len in the (srclen >= size) case to "size - 1", and which is also
more efficient than the strncpy() byte-by-byte implementation by using
memcpy. The destination string returned by strlcpy() is always NULL
terminated.

Signed-off-by: Vladimir Oltean 
Reviewed-by: Ramon Fried