u-boot.git/net/net.c, branch v2011.06

net/net.c: Update ipaddr if the environment has changed

2011-06-01T20:17:49+00:00

At least on ARM the ipaddr is only set in board_init_r function. The
problem is if ipaddr is not defined in environment importing another
environment defined don't update the ipaddr value.

For example, suppose we've a default environment without net variables
defined and we want to import an uEnv.txt environment from SD-card like
this:

  ipaddr=192.168.2.240
  netmask=255.255.255.0
  gatewayip=192.168.2.1
  serverip=192.168.2.114

Then if you try boot from NFS results in:

  Importing environment from mmc ...
  Running uenvcmd ...
  smc911x: detected LAN9221 controller
  smc911x: phy initialized
  smc911x: MAC ac:de:48:00:00:00
  *** ERROR: `ipaddr' not set

The ipaddr at this point is NULL beacause is only set at board_init_r
function. This patch updates the ipaddr value if the environment has
changed.

Signed-off-by: Enric Balletbo i Serra 
Acked-by: Mike Frysinger

TFTP: add tftpsrv command

2011-05-19T19:38:32+00:00

Signed-off-by: Luca Ceresoli 
Cc: Wolfgang Denk 
Acked-by: Detlev Zundel

net/net.c: cosmetic: do not use assignment in if condition

2011-05-12T20:07:41+00:00

This removes the following checkpatch issue:
 - ERROR: do not use assignment in if condition

Signed-off-by: Luca Ceresoli 
Cc: Wolfgang Denk 
Cc: Ben Warren

net/net.c: cosmetic: fix indentation

2011-05-12T20:07:31+00:00

This removes the following checkpatch issues:
 - ERROR: switch and case should be at the same indent
 - WARNING: suspect code indent for conditional statements
 - WARNING: labels should not be indented

Signed-off-by: Luca Ceresoli 
Cc: Wolfgang Denk 
Cc: Ben Warren

net/net.c: cosmetic: parentheses not required for return

2011-05-12T20:06:04+00:00

This removes the following checkpatch issue:
 - ERROR: return is not a function, parentheses are not required

Signed-off-by: Luca Ceresoli 
Cc: Wolfgang Denk 
Cc: Ben Warren

net/net.c: cosmetic: fix pointer syntax issues

2011-05-12T20:03:47+00:00

This removes the following checkpatch issues:
 - ERROR: "foo * bar" should be "foo *bar"
 - ERROR: "(foo*)" should be "(foo *)"

Signed-off-by: Luca Ceresoli 
Cc: Wolfgang Denk 
Cc: Ben Warren

net/net.c: cosmetic: fix brace issues

2011-05-12T20:01:34+00:00

This removes the following checkpatch issues:
 - WARNING: braces {} are not necessary for single statement blocks
 - WARNING: braces {} are not necessary for any arm of this statement

Signed-off-by: Luca Ceresoli 
Cc: Wolfgang Denk 
Cc: Ben Warren

net/net.c: cosmetic: fix whitespace issues

2011-05-12T20:01:05+00:00

This removes the following checkpatch issues:
 - ERROR: space prohibited after that open parenthesis '('
 - ERROR: space prohibited before that close parenthesis ')'
 - ERROR: space prohibited after that open square bracket '['
 - ERROR: space prohibited after that '&' (ctx:WxW)
 - ERROR: spaces required around that '=' (ctx:VxW)
 - ERROR: space required before the open parenthesis '('
 - ERROR: space required after that ',' (ctx:VxV)
 - ERROR: need consistent spacing around '+' (ctx:WxV)
 - WARNING: unnecessary whitespace before a quoted newline
 - WARNING: please, no spaces at the start of a line
 - WARNING: space prohibited between function name and open
   parenthesis '('

Signed-off-by: Luca Ceresoli 
Cc: Wolfgang Denk 
Cc: Ben Warren 
Cc: Mike Frysinger

net/net.c: cosmetic: variable initializations

2011-05-12T19:49:56+00:00

This removes the following checkpatch errors:
 - ERROR: do not initialise globals to 0 or NULL
 - ERROR: spaces required around that '=' (ctx:VxV)
 - ERROR: that open brace { should be on the previous line

Signed-off-by: Luca Ceresoli 
Cc: Wolfgang Denk 
Cc: Ben Warren 
Cc: Mike Frysinger

net/net.c: cosmetic: fix lines over 80 characters

2011-05-12T19:49:49+00:00

This removes the following checkpatch warning:
 - WARNING: line over 80 characters

There are three such warnings left.

The first is hard to fix with cosmetic-only changes without compromising code
readability, so I'm leaving it as it is for now:
  WARNING: line over 80 characters
  #1537: FILE: net.c:1537:
  + [4 tabs] memcpy(((Ethernet_t *)NetArpWaitTxPacket)->et_dest, ...

The other two cannot be fixed without splitting string literals, so it is
preferred to keep them longer than 80 characters.

Signed-off-by: Luca Ceresoli 
Cc: Wolfgang Denk 
Cc: Ben Warren 
Cc: Mike Frysinger