u-boot.git/net/tcp.c, branch master

net: Incorrect NOP macro used for test

2025-08-01T07:30:47+00:00

In tcp_parse_options the uchar p[0] is attempted to test for a match
with the 32bit macro TCP_0_NOP which can never be true. Instead test
against the 8bit macro TCP_1_NOP.

This issue found by Smatch.

Signed-off-by: Andrew Goodbody 
Reviewed-by: Jerome Forissier

net/tcp: define a fallback value for rcv_wnd size

2024-12-28T17:59:42+00:00

Some driver implements it's own network packet pool, so PKTBUFSRX is zero.
This results in zero-size TCP receive window, so data transfer doesn't
work. Avoid it by setting a reasonable fallback value.

Signed-off-by: Mikhail Kshevetskiy 
Reviewed-by: Simon Glass

net/tcp: simplify tcp header filling code

2024-12-28T17:59:42+00:00

This patch:
 * remove useless code,
 * use a special function for pretty printing of tcp flags,
 * simplify the code

The behavior should not be changed.

Signed-off-by: Mikhail Kshevetskiy 
Reviewed-by: Simon Glass

net/tcp: improve tcp framework, use better state machine

2024-12-28T17:59:42+00:00

Changes:
 * Fix initial send sequence always zero issue
 * Use state machine close to RFC 9293. This should make TCP
   transfers more reliable (now we can upload a huge array
   of data from the board to external server)
 * Improve TCP framework a lot. This should make tcp client
   code much more simple.
 * rewrite wget with new tcp stack
 * rewrite fastboot_tcp with new tcp stack

It's quite hard to fix the initial send sequence (ISS) issue
with the separate patch. A naive attempt to fix an issue
inside the tcp_set_tcp_header() function will break tcp packet
retransmit logic in wget and other clients.

Example:
  Wget stores tcp_seq_num value before tcp_set_tcp_header() will
  be called and (on failure) retransmit the packet with the stored
  tcp_seq_num value. Thus:
    * the same ISS must allways be used (current case)
    * or tcp clients needs to generate a proper ISS when
      required.

A proper ISS fix will require a big redesing comparable with
a this one.

Signed-off-by: Mikhail Kshevetskiy 
Reviewed-by: Simon Glass

net/tcp: rename ack_edge and seq_init to more common rcv_nxt and irs

2024-12-28T17:59:42+00:00

Use the names from RFC 9293

Signed-off-by: Mikhail Kshevetskiy 
Reviewed-by: Simon Glass

net/tcp: add connection info to tcp_stream structure

2024-12-28T17:59:42+00:00

Changes:
 * Avoid use net_server_ip in tcp code, use tcp_stream data instead
 * Ignore packets from other connections if connection already created.
   This prevents us from connection break caused by other tcp stream.

Signed-off-by: Mikhail Kshevetskiy 
Reviewed-by: Simon Glass

net/tcp: put connection specific data into a tcp_stream structure

2024-12-28T17:59:42+00:00

no functional changes

Signed-off-by: Mikhail Kshevetskiy 
Reviewed-by: Simon Glass

net/tcp: fix selective acknowledge

2024-12-28T17:59:42+00:00

Current code assume that all (except last) packets are of the same size.
This is definitely wrong. Replace SACK code with a new one, that does
not rely on this assumption. Also this code uses less memory.

Signed-off-by: Mikhail Kshevetskiy 
Reviewed-by: Simon Glass

net/tcp: fix TCP options processing

2024-12-28T17:59:42+00:00

Current TCP code may miss an option if TCP_O_NOP option was used before
it for proper aligning.

Signed-off-by: Mikhail Kshevetskiy 
Reviewed-by: Simon Glass

Restore patch series "arm: dts: am62-beagleplay: Fix Beagleplay Ethernet"

2024-05-20T19:35:03+00:00

As part of bringing the master branch back in to next, we need to allow
for all of these changes to exist here.

Reported-by: Jonas Karlman 
Signed-off-by: Tom Rini