u-boot.git/net, branch v2017.09-rc2

net: Use packed structures for networking

2017-08-07T20:18:31+00:00

PXE boot is broken with GCC 7.1 due option '-fstore-merging' enabled
by default for '-O2':

BOOTP broadcast 1
data abort
pc : [<8ff8bb30>]          lr : [<00004f1f>]
reloc pc : [<17832b30>]    lr : [<878abf1f>]
sp : 8f558bc0  ip : 00000000     fp : 8ffef5a4
r10: 8ffed248  r9 : 8f558ee0     r8 : 8ffef594
r7 : 0000000e  r6 : 8ffed700     r5 : 00000000  r4 : 8ffed74e
r3 : 00060101  r2 : 8ffed230     r1 : 8ffed706  r0 : 00000ddd
Flags: nzcv  IRQs off  FIQs off  Mode SVC_32
Resetting CPU ...

Core reason is usage of structures for network headers without packed
attribute.

Reviewed-by: Yauheni Kaliuta 
Signed-off-by: Denis Pynkin 
Acked-by: Joe Hershberger

net: Fix compile failure in net.c

2017-08-07T20:18:31+00:00

Add missing "defined" statement to fix the compile failures.

Signed-off-by: Holger Dengler 
Acked-by: Joe Hershberger

net: tftp: silence a subscript above array bounds compile time warning

2017-08-07T20:18:29+00:00

For strncpy() select a minimal string length of destination and source
strings, here DEFAULT_NAME_LEN is preferable to MAX_LEN.

Due to the NUL-terminated contents of default_string the change is
a noop, however it removes a compilation warning if SH2/3/4 platform
specific strncpy() function is used:

  In file included from include/linux/string.h:21:0,
                   from include/common.h:28,
                   from net/tftp.c:9:

  net/tftp.c: In function 'tftp_start':
  arch/sh/include/asm/string.h:52:42: warning: array subscript is above array bounds [-Warray-bounds]
     : "0" (__dest), "1" (__src), "r" (__src+__n)

Signed-off-by: Vladimir Zapolskiy 
Acked-by: Joe Hershberger

net: Get mac address from driver as seed

2017-08-07T20:18:28+00:00

Previously seeded by obtaining mac addr from env. If mac addr was
never set, rand would output 0. This fix obtains the mac addr
from driver instead.

Signed-off-by: Jimmy Du 
Acked-by: Joe Hershberger

net: core: avoid possible NULL pointer dereference

2017-06-02T19:44:19+00:00

Checking if dev is NULL after dereferencing it does not make sense.

Signed-off-by: Heinrich Schuchardt 
Acked-by: Joe Hershberger

net: Disable the format-extra-args warning

2017-05-12T12:37:40+00:00

We will see warnings such as:
net/eth_common.c:57:61: warning: data argument not used by format string [-Wformat-extra-args]
        sprintf(enetvar, index ? "%s%daddr" : "%saddr", base_name, index);
                                              ~~~~~~~~             ^
With clang.  In this case we do not want to re-write our code to be less
compact as the above is intentional and readable.  Add a comment above
the disabling so that it's clear why we want that warning off.

Signed-off-by: Tom Rini

net/arp: remove superfluous assignments

2017-05-12T12:37:19+00:00

The value of variable pkt is never used.

The problem was indicated by clang scan-build.

Signed-off-by: Heinrich Schuchardt

net: link_local: Fix netmask endianness bug

2017-03-26T14:58:19+00:00

The network mask must be stored in network order when in a
'struct in_addr'.

This fix removes the "gatewayip needed but not set" message on the
console when using a link-local IP setup.

Signed-off-by: Alexandre Messier 
Signed-off-by: Sylvain Lemieux 
Acked-by: Joe Hershberger

net: don't override ethernet address environment

2017-03-20T21:57:16+00:00

If the ethernet address environment is set with a valid
ethernet address prevent overriding it as it is most likely
set by the user and he/she doesn't want board code to
automatically override it whatsoever.

Signed-off-by: Roger Quadros 
Reviewed-by: Tom Rini

net: core: cosmetic: A MAC address is not limited to SROM

2017-02-07T16:54:32+00:00

Currently, we print that the MAC from the SROM does not match. It can be
many forms of ROM, so lets drop the S.

Signed-off-by: Olliver Schinagl 
Acked-by: Joe Hershberger