u-boot.git/net, branch v2020.01

net: mdio-uclass: add dm_eth_phy_connect helper function

2019-12-09T15:47:43+00:00

The function connects an ethernet device to a PHY using DT information.
This API is only available for eth devices with an associated device tree
node.

Signed-off-by: Alex Marginean 
Acked-by: Joe Hershberger

net: mdio-uclass: rename arguments of dm_mdio_phy_connect for clarity

2019-12-09T15:47:43+00:00

Renamed dm_mdio_phy_connect arguments dev to mdiodev and addr to phyaddr
for a bit more clarity and consistency with the following patches.
Also use NULL instead of 0 on error return path.

Signed-off-by: Alex Marginean 
Acked-by: Joe Hershberger

net: tftp: Fix too small block size

2019-12-09T15:47:43+00:00

Commit b618b3707633 ("net: Convert CONFIG_TFTP_BLOCKSIZE to Kconfig")
accidentally set the default *option* TFTP block size to 512 bytes, even
though the comment in the code says that this is a terrible choice. Most
boards didn't define the symbol before, so they got the default block size
of 1468 bytes before, but now use 512 bytes, which is also the fallback.
This leads to both abysmal performance and a lot of hashes printed
on the screen (one character for every 5K), which is both annoying and
slow over serial links.

Set the default block size in Kconfig back to the value it had before.

This improves TFTP performance from 2.8 MB/s to 6.9 MB/s on a Pine64.

Fixes: b618b3707633 ("net: Convert CONFIG_TFTP_BLOCKSIZE to Kconfig")
Signed-off-by: Andre Przywara 
Acked-by: Joe Hershberger

net: eth-uclass: ignore unavailable devices

2019-12-09T15:47:42+00:00

device_probe() may fail in which case the seq_id will be -1. Don't
display these devices during startup. While this is only a cosmetic
change, the return value of eth_initialize() will also change to the
actual number of available devices. The return value is only used in
spl_net to decide whether there are any devices to boot from. So
returning only available devices is also more correct in that case.

Signed-off-by: Michael Walle 
Acked-by: Joe Hershberger

net: tftp: Fix tftp store address check in store_block()

2019-12-09T15:47:42+00:00

During testing of qemu-riscv32 with a 2GiB memory configuration,
tftp always fails with a error message:

  Load address: 0x84000000
  Loading: #
  TFTP error: trying to overwrite reserved memory...

It turns out the result of 'tftp_load_addr + tftp_load_size' just
overflows (0x100000000) and the test logic in store_block() fails.
Fix this by adjusting the end address to ULONG_MAX when overflow
is detected.

Fixes: a156c47e39ad ("tftp: prevent overwriting reserved memory")
Signed-off-by: Bin Meng 
Acked-by: Joe Hershberger

net: avoid address-of-packed-member error

2019-12-09T15:47:42+00:00

sandbox_defconfig does not compile using GCC 9.2.1:

net/net.c: In function ‘net_process_received_packet’:
net/net.c:1288:23: error: taking address of packed member of ‘struct
ip_udp_hdr’ may result in an unaligned pointer value
[-Werror=address-of-packed-member]
 1288 |    sumptr = (ushort *)&(ip->udp_src);
      |                       ^~~~~~~~~~~~~~

Avoid the error by using a u8 pointer instead of an u16 pointer and
in-lining ntohs().

Simplify the checksumming of the last message byte.

Signed-off-by: Heinrich Schuchardt 
Reviewed-by: Simon Goldschmidt 
Acked-by: Joe Hershberger

net: nfs: Only link in NFS code outside of SPL builds

2019-12-09T15:47:41+00:00

While we have networking use cases within SPL we do not support loading
files via NFS at this point in time.  Disable calling nfs_start() so
that the NFS related code can be garbage collected at link time.

Signed-off-by: Tom Rini 
Acked-by: Joe Hershberger

net: Always build the string_to_enetaddr() helper

2019-12-09T15:47:41+00:00

Part of the env cleanup moved this out of the environment code and into
the net code. However, this helper is sometimes needed even when the net
stack isn't included.

Move the helper to lib/net_utils.c like it's similarly-purposed
string_to_ip(). Also rename the moved function to similar naming.

Signed-off-by: Joe Hershberger 
Reported-by: Ondrej Jirman

common: Move get_ticks() function out of common.h

2019-12-02T23:23:13+00:00

This function belongs in time.h so move it over and add a comment.

Signed-off-by: Simon Glass 
Reviewed-by: Tom Rini

common: Move random-number functions into their own header

2019-12-02T23:23:07+00:00

Create a new rand.h header file and move functions into it, to reduce
the size of common.h

Signed-off-by: Simon Glass 
Reviewed-by: Tom Rini