u-boot.git/net, branch v2022.01-rc4

WS cleanup: remove trailing empty lines

2021-09-30T12:08:56+00:00

Signed-off-by: Wolfgang Denk

Merge branch 'network_master' of https://source.denx.de/u-boot/custodians/u-boot-net into next

2021-09-29T11:58:20+00:00

- Fix some non-NULL terminated strings in the networking subsystem
- net: tsec: Mark tsec_get_interface as __maybe_unused

net: dsa: ensure port names are NULL-terminated after DSA_PORT_NAME_LENGTH truncation

2021-09-28T15:50:57+00:00

strncpy() simply bails out when copying a source string whose size
exceeds the destination string size, potentially leaving the destination
string unterminated.

One possible way to address is to pass DSA_PORT_NAME_LENGTH - 1 and a
previously zero-initialized destination string, but this is more
difficult to maintain.

The chosen alternative is to use strlcpy(), which properly limits the
copy len in the (srclen >= size) case to "size - 1", and which is also
more efficient than the strncpy() byte-by-byte implementation by using
memcpy. The destination string returned by strlcpy() is always NULL
terminated.

Signed-off-by: Vladimir Oltean 
Reviewed-by: Ramon Fried

net: mdio-uclass: rewrite dm_mdio_post_probe using strlcpy

2021-09-28T15:50:57+00:00

dm_mdio_post_probe used to be vulnerable after truncation, but has been
patched by commit 398e7512d8d7 ("net: Fix Covarity Defect 244093").
Nonetheless, we can use strlcpy like the rest of the code base now,
which yields the same result.

Signed-off-by: Vladimir Oltean 
Reviewed-by: Ramon Fried

net: dsa: remove unused variables

2021-09-28T15:50:56+00:00

"dev" and "dsa_pdata" are unused inside dsa_port_of_to_pdata.

"dsa_priv" is unused inside dsa_port_probe.

Signed-off-by: Vladimir Oltean 
Reviewed-by: Ramon Fried

net: dsa: pass CPU port fixed PHY to .port_disable

2021-09-28T15:50:56+00:00

While adding the logic for DSA to register a fixed-link PHY for the CPU
port, I forgot to pass it to the .port_disable method too, just
.port_enable.

Bug had no impact for felix_switch.c, due to the phy argument not being
used, but ksz9477.c does use it => NULL pointer dereference.

Fixes: fc054d563bfb ("net: Introduce DSA class for Ethernet switches")
Signed-off-by: Vladimir Oltean 
Reviewed-by: Ramon Fried

net: dsa: introduce a .port_probe() method in struct dsa_ops

2021-09-28T15:50:56+00:00

Some drivers might want to execute code for each port at probe time, as
opposed to executing code just-in-time for the port selected for
networking.

To cater to that use case, introduce a .port_probe() callback method
into the DSA switch operations which is called for each available port,
at the end of dsa_port_probe().

Signed-off-by: Vladimir Oltean 
Reviewed-by: Ramon Fried 
Tested-by: Michael Walle

net: dsa: refactor the code to set the port MAC address into a dedicated function

2021-09-28T15:50:55+00:00

This snippet of code has a bothering "if (...) return 0" in it which
assumes it is the last piece of code running in dsa_port_probe().

This makes it difficult to add further code at the end of dsa_port_probe()
which does not depend on MAC address stuff.

So move the code to a dedicated function which returns void and let the
code flow through.

Signed-off-by: Vladimir Oltean 
Reviewed-by: Ramon Fried 
Tested-by: Michael Walle

net: dsa: use "err" instead of "ret" in dsa_port_probe

2021-09-28T15:50:55+00:00

DM DSA uses "err" for error code values, so use this consistently.

Signed-off-by: Vladimir Oltean 
Reviewed-by: Ramon Fried 
Tested-by: Michael Walle

Remove #include from files which do not need it

2021-09-17T16:10:44+00:00

Signed-off-by: Pali Rohár 
Reviewed-by: Tom Rini