u-boot.git/test/boot/bootdev.c, branch v2024.01

bootstd: Scan all bootdevs in a boot_targets entry (take 2)

2023-10-23T17:05:13+00:00

When the boot_targets environment variable is used with the distro-boot
scripts, each device is included individually. For example, if there
are three mmc devices, then we will have something like:

   boot_targets="mmc0 mmc1 mmc2"

In contrast, standard boot supports specifying just the uclass, i.e.:

   boot_targets="mmc"

The intention is that this should scan all MMC devices, but in fact it
currently only scans the first.

Update the logic to handle this case, without required BOOTSTD_FULL to
be enabled.

Signed-off-by: Simon Glass 
Reported-by: Date Huang 
Reported-by: Vincent Stehlé 
Reported-by: Ivan Ivanov 
Tested-by: Ivan T.Ivanov

bootstd: Correct logic for single uclass

2023-10-23T17:05:13+00:00

The current logic for "bootflow mmc" is flawed since it checks the
uclass of the bootdev instead of its parent, the media device. Correct
this and add a test that covers this scenario.

Signed-off-by: Simon Glass 
Tested-by: Ivan T.Ivanov

bootstd: Expand boot-ordering test to include USB

2023-10-23T17:05:13+00:00

Scan the USB bus as well, so we can check that different uclasses work
correctly in boot_targets

update the function comment with more detail.

Signed-off-by: Simon Glass 
Tested-by: Ivan T.Ivanov

Revert "bootstd: Scan all bootdevs in a boot_targets entry"

2023-10-23T17:05:13+00:00

This commit was intended to allow all bootdevs in each boot_targets
entry to be scanned. However it causes bad ordering with bootdevs, e.g.
scanning Ethernet bootdevs when it should be keeping to mmc.

Revert it so we can try another approach.

This reverts commit e824d0d0c219bc6da767f13f90c5b00eefe929f0.

Signed-off-by: Simon Glass 
Tested-by: Ivan T.Ivanov

bootstd: Scan all bootdevs in a boot_targets entry

2023-10-13T17:15:41+00:00

When the boot_targets environment variable is used with the distro-boot
scripts, each device is included individually. For example, if there
are three mmc devices, then we will have something like:

   boot_targets="mmc0 mmc1 mmc2"

In contrast, standard boot supports specifying just the uclass, i.e.:

   boot_targets="mmc"

The intention is that this should scan all MMC devices, but in fact it
currently only scans the first.

Update the logic to handle this case, without required BOOTSTD_FULL to
be enabled.

I believe at least three people reported this, but I found two.

Signed-off-by: Simon Glass 
Reported-by: Date Huang 
Reported-by: Vincent Stehlé

bootstd: usb: Avoid initing USB twice

2023-05-13T13:52:32+00:00

This causes crashes on some boards, e.g. rockpro64. In any case, we
should not do it.

Check the usb_started flag to avoid this.

Signed-off-by: Simon Glass 
Tested-by: Jonas Karlman 
Tested-by: Tom Rini

usb: Tidy up the usb_start flag

2023-05-13T13:52:32+00:00

This should be declared in a header file so that type-checking works
correctly.

Add a single declaration to usb.h and remove the others.

Signed-off-by: Simon Glass 
Reviewed-by: Marek Vasut 
Reviewed-by: Patrick Delaunay

ide: Move ide_init() into probing

2023-04-27T17:51:06+00:00

At present the code does ide_init() as a separate operation, then calls
device_probe() to copy over the information. We can call ide_init() from
probe just as easily.

The only difference is that using 'ide init' twice will do nothing.
However it already fails to copy over the new data in that case, so the
effect is the same. For now, unbind the block devices and remove the IDE
device, which causes the bus to be probed again. Later patches will fix
this up fully, so that all blk_desc data is copied across.

Since ide_reset() is only called from ide_init(), there is no need to init
the ide_dev_desc[] array. This is already done at the end of ide_init() so
drop this code.

The call to uclass_first_device() is now within the probe() function of
the same device, so does nothing. Drop it.

Signed-off-by: Simon Glass

bootstd: Report missing labels only when asked

2023-04-26T12:43:04+00:00

Use the -l flag to indicate whether to report missing uclasses.

Also try to be more helpful when no devices are found. For example, when
we see something 'scsi0' requested and nothing was found, this indicates
that there are no SCSI devices, so show a suitable message.

Move messages out of the low-level functions so that silent operation
is possible.

This means they are never reported unless BOOTSTD_FULL is enabled, since
the -l flag cannot otherwise be set.

Suggested-by: Tom Rini 

Signed-off-by: Simon Glass

bootflow: Rename bootflow_flags_t

2023-03-08T19:40:49+00:00

These flags actually relate to the iterator, not the bootflow struct
itself. Rename them.

Signed-off-by: Simon Glass