u-boot.git/tools/binman/btool, branch v2023.01

Revert "binman: btool: gzip: fix packer name so that binary can be found"

2022-11-22T22:13:34+00:00

This reverts commit daa2da754afe1bac777f6cb0f05233e0de7b325d.

This commit is not needed anymore since the btool_ prefix is
automatically stripped by bintool.

Cc: Quentin Schulz 
Signed-off-by: Quentin Schulz 
Reviewed-by: Simon Glass

binman: bintool: remove btool_ prefix from btool names

2022-11-22T22:13:34+00:00

The binary is looked on the system by the suffix of the packer class.
This means binman was looking for btool_gzip on the system and not gzip.

Since a btool can have its btool_ prefix missing but its module and
binary presence on the system appropriately found, there's no need to
actually keep this prefix after listing all possible btools, so let's
remove it.

This fixes gzip btool by letting Bintool.find_bintool_class handle the
missing prefix and still return the correct class which is then init
with gzip name instead of btool_gzip.

Additionally, there was an issue with the cached module global variable.
The variable only stores the module and not the associated class name
when calling find_bintool_class.
This means that when caching the module on the first call to
find_bintool_class, class_name would be set to Bintoolbtool_gzip but the
module_name gzip only, adding the module in the gzip key in the module
dictionary. When hitting the cache on next calls, the gzip key would be
found, so its value (the module) is used. However the default class_name
(Bintoolgzip) is used, failing the getattr call.

Instead, let's enforce the same class name: Bintool, whatever
the filename it is contained in.

Cc: Quentin Schulz 
Signed-off-by: Quentin Schulz 
Reviewed-by: Simon Glass

binman: Get futility by building it

2022-09-21T08:37:47+00:00

A binary download is not great, since it depends on libraries being
present in the system. Build futility from source instead.

Signed-off-by: Simon Glass

binman: bintool: bzip2: fix version function on non-Debian-based systems

2022-09-01T17:36:36+00:00

Upstream bzip2 1.0.x actually is stuck when running bzip2 -V and
redirecting the output. This is fixed in Debian for about a decade
already in
https://git.launchpad.net/ubuntu/+source/bzip2/tree/debian/patches/20-legacy.patch?h=ubuntu/jammy
and in bzip2 1.1.x (no release yet, see
https://gitlab.com/bzip2/bzip2/-/commit/65179284ceddc43e6388bf4ed8c2d85cf16e1b2f
).

Fedora notably does not have such a patch.

Since bzip2 --help actually prints the version number too, let's use it
instead so that binman works fine on (hopefully) all distributions.

Fixes: 45aa2798008c ("binman: Add bzip2 bintool")
Signed-off-by: Quentin Schulz 
Reviewed-by: Simon Glass

binman: btool: futility: use Bintool.version

2022-09-01T17:36:36+00:00

Bintool.version can now be passed the binary argument to return the
version text, so there's no need to override it in futility anymore.

Signed-off-by: Quentin Schulz 
Reviewed-by: Simon Glass

binman: btool: fiptool: use Bintool.version

2022-09-01T17:36:36+00:00

Bintool.version can now be passed the binary argument to return the
version text, so there's no need to override it in fiptool anymore.

Signed-off-by: Quentin Schulz 
Reviewed-by: Simon Glass

binman: btool: mkimage: use Bintool.version

2022-09-01T17:36:36+00:00

Bintool.version already contains everything required to get the version
out of mkimage binary so let's not override it with its own
implementation.

Signed-off-by: Quentin Schulz 
Reviewed-by: Simon Glass

binman: btool: lz4: use Bintool.version

2022-09-01T17:36:36+00:00

Bintool.version already contains everything required to get the version
out of lz4 binary so let's not override it with its own implementation.

Signed-off-by: Quentin Schulz 
Reviewed-by: Simon Glass

binman: btool: gzip: fix packer name so that binary can be found

2022-09-01T17:36:36+00:00

The binary is looked on the system by the suffix of the packer class.
This means binman was looking for btool_gzip on the system and not gzip.

Therefore, let's pass "gzip" as the name so that it can be found and
used.

Fixes: 0f369d79925a ("binman: Add gzip bintool")
Signed-off-by: Quentin Schulz 
Reviewed-by: Simon Glass

binman: Add zstd bintool

2022-08-21T00:07:33+00:00

Add zstd bintool to binman to support on-the-fly compression.

Signed-off-by: Stefan Herbrechtsmeier 
Reviewed-by: Simon Glass