u-boot.git/tools/env, branch v2017.09-rc4

fix: fw_env: Prevent writing error message on special files, which don't support fsync

2017-09-03T19:30:31+00:00

According to fsync specification [1] some special files (e.g., a pipe, FIFO,
or socket) don't support synchronization and return either EROFS or EINVAL.

On the linux side the sys_fsync -> do_fsync() checks if the requested file
has f_op->fsync defined. If not it returns EINVAL [2].

This commit prevents writing error messages for files (devices), which
do not support fsync().

[1] - http://man7.org/linux/man-pages/man2/fsync.2.html
[2] - http://elixir.free-electrons.com/linux/v4.13-rc6/source/fs/sync.c#L183

Signed-off-by: Lukasz Majewski 
Acked-by: Michael Heimpold

env: Rename setenv() to env_set()

2017-08-16T12:22:18+00:00

We are now using an env_ prefix for environment functions. Rename setenv()
for consistency. Also add function comments in common.h.

Suggested-by: Wolfgang Denk 
Signed-off-by: Simon Glass

tools/fw_env: use fsync to ensure that data is physically stored

2017-07-22T19:36:16+00:00

Closing a file descriptor does not guarantee that the data has been
successfully saved to disk, as the kernel might defer the write.

Signed-off-by: Michael Heimpold

tools/env: avoid memory leak in fw_setenv

2017-04-18T14:29:22+00:00

If realloc fails we should release the old buffer.

Signed-off-by: Heinrich Schuchardt 
Reviewed-by: Tom Rini 
Reviewed-by: Simon Glass

env: fix memory leak in fw_env routines

2017-04-12T17:28:29+00:00

fw_env_open allocates buffers to store the environment, but these
buffers are never freed. This becomes quite nasty using the fw_ tools as
library, because each access to the environment (even just reading a
variable) generates a memory leak equal to the size of the environment.

Fix this renaming fw_env_close() as fw_env_flush(), because the function
really flushes the environment from RAM to storage, and add a
fw_env_close function to free the allocated resources.

Signed-off-by: Stefano Babic

env: add a version number to check API

2017-04-12T17:28:29+00:00

Changes in the environment library are difficult to tracked by programs
using the library. Add simply an API version number that must be
increased each time when the API is changed.

This can be detected and a program can work with different versions of
the library.

Signed-off-by: Stefano Babic

env: split fw_env.h in public and private parts

2017-04-12T17:28:28+00:00

Move U-Boot private data into a separate file. This
lets export fw_env.h to be used by external programs
that want to change the environment using the library
built in tools/env.

Signed-off-by: Stefano Babic

Rename aes.h to uboot_aes.h

2017-04-12T17:28:27+00:00

aes.h is a too generic name if this file can
be exported and used by a program.
Rename it to avoid any conflicts with
other files (for example, from openSSL).

Signed-off-by: Stefano Babic

tools: fix cross-compiling tools when HOSTCC is overridden

2017-03-15T00:40:22+00:00

Richard reported U-Boot tools issues in OpenEmbedded/Yocto project.

OE needs to be able to change the default compiler. If we pass in
HOSTCC through the make command, it overwrites all HOSTCC instances,
including ones in tools/Makefile and tools/env/Makefile, which breaks
"make cross_tools" and "make env", respectively.

Add "override" directives to avoid overriding HOSTCC instances that
really need to point to the cross-compiler.

Signed-off-by: Masahiro Yamada 
Reported-by: Richard Purdie 
Reviewed-by: Simon Glass

tools/env: fix environment alignment tests for block devices

2016-11-28T20:10:36+00:00

commit 183923d3e412500bdc597d1745e2fb6f7f679ec7 enforces that the
environment must start at an erase block boundary.

For block devices the sample fw_env.config does not mandate a erase block size
for block devices. A missing setting defaults to the full env size.

Depending on the environment location the alignment check now errors out for
perfectly legal settings.

Fix this by defaulting to the standard blocksize of 0x200 for environments
stored in a block device.
That keeps the fw_env.config files for block devices working even with that
new check.

Signed-off-by: Max Krummenacher