u-boot.git/tools/env, branch v2019.10

fw_env: fix build error

2019-09-24T21:46:13+00:00

The following error appears:

tools/env/fw_env.c:1149:25: error: lvalue required as unary ‘&’ operand
  rc = write(fd, &ENV_REDUND_OBSOLETE, sizeof(ENV_REDUND_OBSOLETE));

Fixes: d3716dd ("env: Rename the redundancy flags")

Signed-off-by: Pierre-Jean Texier 
Tested-by: Joris Offouga 
Tested-by: Heiko Schocher 
Suggested-by: Heiko Schocher 
Acked-by: Joe Hershberger

fw_env: remove duplicated definitions

2019-09-24T21:46:13+00:00

Since commit d3716dd ("env: Rename the redundancy flags"), the
definitions of ENV_REDUND_OBSOLETE & ENV_REDUND_ACTIVE was moved
to env.h.

Fixes:

tools/env/fw_env.c:122:22: error: ‘ENV_REDUND_ACTIVE’ redeclared as different kind of symbol
 static unsigned char ENV_REDUND_ACTIVE = 1;
                      ^~~~~~~~~~~~~~~~~
In file included from tools/env/fw_env.c:13:
include/env.h:63:2: note: previous definition of ‘ENV_REDUND_ACTIVE’ was here
  ENV_REDUND_ACTIVE = 1,
  ^~~~~~~~~~~~~~~~~
tools/env/fw_env.c:127:22: error: ‘ENV_REDUND_OBSOLETE’ redeclared as different kind of symbol
 static unsigned char ENV_REDUND_OBSOLETE;
                      ^~~~~~~~~~~~~~~~~~~
In file included from tools/env/fw_env.c:13:
include/env.h:62:2: note: previous definition of ‘ENV_REDUND_OBSOLETE’ was here
  ENV_REDUND_OBSOLETE = 0,

Signed-off-by: Pierre-Jean Texier 
Tested-by: Joris Offouga 
Tested-by: Heiko Schocher 
Acked-by: Joe Hershberger

env: Rename the redundancy flags

2019-08-11T20:43:41+00:00

Add an ENV prefix to these two flags so that it is clear what they relate
to. Also move them to env.h since they are part of the public API. Use an
enum rather than a #define to tie them together.

Signed-off-by: Simon Glass

env: Move env_set() to env.h

2019-08-11T20:43:41+00:00

Move env_set() over to the new header file.

Acked-by: Joe Hershberger 
Signed-off-by: Simon Glass

fw_env: Add missing write failure check

2019-06-20T14:57:08+00:00

If flash_write fails, whilst we propagate this up to our caller, we need
to avoid swapping in the new file (if we're on a filesystem) in this
case.

Fixes: dbc34323796b ("tools: env: Implement atomic replace for filesystem")
Signed-off-by: Alex Kiernan

env: add missing newline

2019-05-05T12:48:50+00:00

Signed-off-by: Philip Molloy

fw_env: Fix double free

2019-04-26T22:58:21+00:00

addr0 is being freed twice, leading to segmentation fault

Signed-off-by: Björn Stenberg

include/version.h: workaround sysroot inc order

2018-09-11T00:20:34+00:00

On some systems the host system or even the cross sysroot can
contain a version.h.  This leads to the wrong file being picked
up and a PLAIN_VERSION undefined error.

This workaround symlinks the version.h into the tool folder to
allow reordering of search folders.

Fixes
http://autobuild.buildroot.net/results/770/7702d5df36a6532aafdbe6e9e62709bbfa058b54/build-end.log
http://autobuild.buildroot.net/results/e34/e3401027d2fb3ce565ca9e2456a427afd3610a87/build-end.log
... additional can be found with these queries ...
http://autobuild.buildroot.net/?reason=uboot-tools-2018.03
http://autobuild.buildroot.net/?reason=uboot-tools-2018.05

Upstream: pending

Signed-off-by: Matthew Weber

Revert "fw_printenv: Don't bail out directly after one env read error"

2018-07-02T02:10:33+00:00

As pointed out by Wolfgang Denk, the problem with this fix is that while
interactive users will see that we have found one part of the
environment failed and are using the other, progmatic use will not see
this and can lead to problems.

Signed-off-by: Tom Rini

fw_printenv: Don't bail out directly after one env read error

2018-06-27T17:09:16+00:00

When using a redundant environment a read error should simply mean to
not use that copy instead of giving up completely. The other copy may
be just fine.

Signed-off-by: Joe Hershberger 
Signed-off-by: Ioan-Adrian Ratiu