u-boot.git/tools/fdtgrep.c, branch v2018.11

fdtgrep: Separate out checking of two allocations

2018-06-19T11:31:44+00:00

The current code might succeed on the first allocation and fail on the
second. Separate the checks to avoid this problem.

Of course, free() will never fail and the chances that (when allocating
two small areas) one will succeed and one will fail are just as remote.
But this keeps coverity happy.

Reported-by: Coverity (CID: 131226)

Signed-off-by: Simon Glass

fdtgrep: Fix logic of free() in do_fdtgrep()

2018-06-19T11:31:43+00:00

This loop never actually exits, but the way the code is written this is
not obvious. Add an explicit error check.

Reported-by: Coverity (CID: 131280)
Signed-off-by: Simon Glass 
[trini: Add explicit init of region to NULL per LLVM warning]
Signed-off-by: Tom Rini

SPDX: Convert all of our single license tags to Linux Kernel style

2018-05-07T13:34:12+00:00

When U-Boot started using SPDX tags we were among the early adopters and
there weren't a lot of other examples to borrow from.  So we picked the
area of the file that usually had a full license text and replaced it
with an appropriate SPDX-License-Identifier: entry.  Since then, the
Linux Kernel has adopted SPDX tags and they place it as the very first
line in a file (except where shebangs are used, then it's second line)
and with slightly different comment styles than us.

In part due to community overlap, in part due to better tag visibility
and in part for other minor reasons, switch over to that style.

This commit changes all instances where we have a single declared
license in the tag as both the before and after are identical in tag
contents.  There's also a few places where I found we did not have a tag
and have introduced one.

Signed-off-by: Tom Rini

tools: include necessary headers explicitly

2018-01-28T17:27:31+00:00

Several host-tools use "bool" type without including .
This relies on the crappy header inclusion chain.

tools/Makefile has the following line:

  HOST_EXTRACFLAGS += -include $(srctree)/include/libfdt_env.h \

All host-tools are forced to include libfdt_env.h even if they are
totally unrelated to FDT.  Then,  is indirectly included
as follows:

     include/libfdt_env.h
  -> include/linux/types.h
  -> 

I am fixing this horrible crap.  In advance, I need to add necessary
include directives explicitly.  tools/fdtgrep.c needs more; 
for open() and  for errno.

Signed-off-by: Masahiro Yamada 
Reviewed-by: Joe Hershberger 
Reviewed-by: Simon Glass

libfdt: migrate fdt_rw.c to a wrapper of scripts/dtc/libfdt/fdt_rw.c

2018-01-28T17:27:30+00:00

The only difference between scripts/dtc/libfdt/fdt_rw.c and
lib/libfdt/fdt_rw.c is fdt_remove_unused_strings().

It is only used by fdtgrep, so we do not need to compile it for U-Boot
image.  Move it to tools/libfdt/fdw_rw.c so that lib/libfdt/fdt_rw.c
can be a wrapper of scripts/dtc/libfdt/fdt_rw.c.

Signed-off-by: Masahiro Yamada 
Reviewed-by: Simon Glass

Do not attempt to use the systemwide libfdt

2017-11-06T14:59:02+00:00

U-Boot bundles a patched copy of libfdt, so it's wrong to attempt to
include it . This breaks the build for me when I have dtc
fully installed in my host -- as happened earlier tonight with
Buildroot, for example.

There are several other occurrences throughout the code where ' include style is being used -- IMHO wrongly.

Signed-off-by: Jan Kundrát

fdtgrep: Deal with NULL data passed to check_type_include()

2017-06-12T12:38:07+00:00

Since the parameter can be NULL we must be careful not to dereference it
in this case.

Signed-off-by: Simon Glass 
Reported-by: Coverity (CID: 163250)
Fixes: 1043d0a0 (fdt: Add fdtgrep tool)

fdtgrep: Cope with the /aliases node being last

2017-04-13T20:43:31+00:00

With skeleton.dtsi being dropped it is more likely that the /aliases node
will be last in the device tree. Update fdtgrep to handle this.

Signed-off-by: Simon Glass 
Tested-by: Masahiro Yamada

Various, accumulated typos collected from around the tree.

2016-10-07T00:57:40+00:00

Fix various misspellings of:

 * deprecated
 * partition
 * preceding,preceded
 * preparation
 * its versus it's
 * export
 * existing
 * scenario
 * redundant
 * remaining
 * value
 * architecture

Signed-off-by: Robert P. J. Day 
Reviewed-by: Jagan Teki 
Reviewed-by: Stefan Roese

fdtgrep: Improve error handling with invalid device tree

2016-03-14T21:34:50+00:00

This tool requires that the aliases node be the first node in the tree. But
when it is not, it does not handle things gracefully. In fact it crashes.

Fix this, and add a more helpful error message.

Signed-off-by: Simon Glass 
Reported-by: Masahiro Yamada