u-boot.git/tools/ifwitool.c, branch master

ifwitool: Fix member access

2023-01-27T17:51:26+00:00

On a second and third look, a recent patch seems to be writing to the
wrong place - updating offsets from the address of the pointer instead
of what the pointer points to.

Fix it.

Signed-off-by: Simon Glass 
Fixes: 2d1b2ac13fe ("tool: ifwitool: Fix buffer overflow")
Acked-by: Sean Anderson

tool: ifwitool: Fix buffer overflow

2022-12-08T14:25:44+00:00

An incorrect 1st parameter is passed to the fix_member()
 function. Should use a pointer to the beginning of the parent structure
 (bpdt or subpart_dir, because are boxed), not to their fields. Otherwise,
 this leads to an overrun of the structure boundary, since in the
 fix_member() function, an 'offset' is made, relative to the 1st argument,
 which itself is an 'offset' from the beginning of the structure.

Signed-off-by: Mikhail Ilin 
Reviewed-by: Simon Glass

tool: ifwitool: The function localtime() can return NULL.

2022-12-08T14:25:44+00:00

This will cause the local_time pointer is passed as the 4th argument
 to function strftime() to also point to NULL. This result in a
 segmentation fault. Thus, it's necessary to add a check of the local_time
 pointer to NULL.

Found by Linux Verification Center (linuxtesting.org) with SVACE.

Signed-off-by: Mikhail Ilin 
Reviewed-by: Simon Glass

tool: Move ALIGN_MASK to header as common MACRO

2020-04-24T14:10:00+00:00

The ALIGN code is need by many files who need handle structure or image
align, so move the macro to imagetool.h file.

Signed-off-by: Kever Yang 
Reviewed-by: Punit Agrawal 
Reviewed-by: Tom Rini

tools: ifwitool: Define __packed when it is not defined

2019-10-28T17:32:51+00:00

Some compilers may provide __packed define for us.

Signed-off-by: Bin Meng

x86: Add ifwitool for Intel Integrated Firmware Image

2019-07-24T03:27:56+00:00

Some Intel SoCs from about 2016 boot using an internal microcontroller via
an 'IFWI' image. This is a special format which can hold firmware images.
In U-Boot's case it holds u-boot-tpl.bin.

Add this tool, taken from coreboot, so that we can build bootable images
on apollolake SoCs.

This tool itself has no tests. Some amount of coverage will be provided by
the binman tests that use it, so enable building the tool on sandbox.

Signed-off-by: Simon Glass