u-boot.git/tools/image-host.c, branch v2025.01

image-host: fix 'unknown error' error message

2024-10-18T20:10:22Z

Fix error message like this: Can't add verification data for node 'fdt-1' () We get unknown error because we decode error as fdt error but actually it is system error. Signed-off-by: Alexander Kochetkov Reviewed-by: Simon Glass

mkimage: Allow 'auto-conf' signing of scripts

2024-07-05T19:57:01Z

U-Boot configured for verified boot with the "required" option set to "conf" also checks scripts put in FIT images for a valid signature, and refuses to source and run such a script if the signature for the configuration is bad or missing. Such a script could not be packaged before, because mkimage failed like this: % tools/mkimage -T script -C none -d tmp/my.scr -f auto-conf -k tmp -g dev -o sha256,rsa4096 my.uimg Failed to find any images for configuration 'conf-1/signature' tools/mkimage Can't add hashes to FIT blob: -1 Error: Bad parameters for FIT image type This is especially unfortunate if LEGACY_IMAGE_FORMAT is disabled as recommended. Listing the script configuration in a "sign-images" subnode instead, would have added even more complexity to the already complex auto fit generation code. Signed-off-by: Alexander Dahl

image-host: Fix error value paths and emit error messages to stderr.

2024-04-12T14:53:31Z

A recent refactoring in image-host.c messed up the return values of the function that reads the encryptiong keys. This patch fixes this and also makes sure that error output goes to stderr instead of to stdout. Signed-off-by: Hugo Cornelis

image-host: refactor and protect for very long filenames

2024-01-18T22:50:27Z

This patch adds a function fit_image_read_key_iv_data that checks the return value of snprintf and allows to generate a sensible error message when generating binary images using filenames that are too long for the OS to handle. This is especially relevant for automated builds such as Buildroot and Yocto builds. Signed-off-by: Hugo Cornelis

tools: fix build without LIBCRYPTO support

2024-01-12T03:09:11Z

Commit cb9faa6f98ae ("tools: Use a single target-independent config to enable OpenSSL") introduced a target-independent configuration to build crypto features in host tools. But since commit 2c21256b27d7 ("hash: Use Kconfig to enable hashing in host tools and SPL") the build without OpenSSL is broken, due to FIT signature/encryption features. Add missing conditional compilation tokens to fix this. Signed-off-by: Paul-Erwan Rio Tested-by: Alexander Dahl Cc: Simon Glass Reviewed-by: Tom Rini Reviewed-by: Simon Glass

tools: image-host: print error messages to stderr

2023-08-30T15:47:43Z

The make by default cuts off the stdout output from external tools, so all error messages from the image-host are not shown in a make output. Besides that, it is a common approach to use stderr stream for error messages. Use stderr for all error messages in image-host. Signed-off-by: Oleksandr Suvorov Reviewed-by: Simon Glass

mkimage: Add a few more messages for FIT failures

2023-01-18T18:49:13Z

Add messages to make it clearer which part of the FIT creation is failing. This can happen when an invalid 'algo' property is provided in the .its file. Signed-off-by: Simon Glass

mkimage: fit: Fix signing of configs with external data

2022-10-26T15:36:06Z

Just like we exclude data-size, data-position, and data-offset from fit_config_check_sig, we must exclude them while signing as well. While we're at it, use the FIT_DATA_* defines for fit_config_check_sig as welll. Fixes: 8edecd3110e ("fit: Fix verification of images with external data") Fixes: c522949a29d ("rsa: sig: fix config signature check for fit with padding") Signed-off-by: Sean Anderson Reviewed-by: Simon Glass

image-pre-load: Move macros/definitions to image.h

2022-10-11T19:40:48Z

Putting these definitions in a header will allow signatures to be validated independently of bootm. Signed-off-by: Steven Lawrance Reviewed-by: Simon Glass

tools: mkimage: Avoid ENODATA in host tools

2022-05-05T23:37:11Z

ENODATA isn't part of POSIX. Use EINVAL instead. Signed-off-by: Mark Kettenis Reviewed-by: Tom Rini