u-boot.git/tools/mkimage.c, branch v2016.09

mkimage: Fix argument parsing with signature comment

2016-08-06T00:55:23+00:00

Inform getopt that '-c' requires a parameter.

Fixes: a02221f29deb ("mkimage: Convert to use getopt()")
Signed-off-by: Karl Beldan 
Reviewed-by: Tom Rini

mkimage: fix missing break for -p switch

2016-07-14T22:22:44+00:00

Signed-off-by: Teddy Reed 
Reported-by: Coverity (CID: 150277)
Reviewed-by: Tom Rini

mkimage: Show item lists for all categories

2016-07-14T22:22:31+00:00

Update the error-handling code for -A, -C and -O to show a list of valid
options when an invalid one is provided.

Signed-off-by: Simon Glass 
Reported-by: Vinoth Eswaran 
Reviewed-by: Tom Rini

mkimage: Use generic code for showing an 'image type' error

2016-07-14T22:22:30+00:00

The existing error code only displays image types which are claimed by a
particular U_BOOT_IMAGE_TYPE() driver. But this does not seem correct. The
mkimage tool should support all image types, so it makes sense to allow
creation of images of any type with the tool.

When an incorrect image type is provided, use generic code to display the
error.

Signed-off-by: Simon Glass 
Reviewed-by: Tom Rini

mkimage: Allow display of a list of any image header category

2016-07-14T22:22:30+00:00

Add a generic function which can display a list of items in any category.
This will allow displaying of images for the -A, -C, -O and -T flags. At
present only -T is supported.

Signed-off-by: Simon Glass 
Reviewed-by: Tom Rini

mkimage: Drop blank line before main()

2016-07-14T22:22:27+00:00

This is not needed. Drop it.

Signed-off-by: Simon Glass 
Reviewed-by: Tom Rini

mkimage: Drop premature setting of params.fit_image_type

2016-07-14T22:22:27+00:00

There is no need to set params.fit_image_type while parsing the arguments.
It is set up later anyway.

Signed-off-by: Simon Glass 
Reviewed-by: Tom Rini

mkimage: Require a data file when auto-fit is used

2016-07-14T22:22:27+00:00

When auto-fit is used, it is not valid to create a FIT without an image
file. Add a check for this to avoid a very confusing error message later
("Can't open (null): Bad address").

Signed-off-by: Simon Glass 
Reviewed-by: Tom Rini

mkimage: Explain the auto-fit imagefile special case

2016-07-14T22:22:26+00:00

There is a special case in the code when auto-fit is used. Add a comment to
make it easier to understand why this is needed.

Signed-off-by: Simon Glass 
Acked-by: Joe Hershberger

mkimage: Honour the default image type with auto-fit

2016-07-14T22:22:26+00:00

The default image type is supposed to be IH_TYPE_KERNEL, as set in the
'params' variable. Honour this with auto-fit also.

Signed-off-by: Simon Glass 
Reviewed-by: Tom Rini