u-boot.git/tools/moveconfig.py, branch v2016.07

tools: moveconfig: show suspicious boards with possible misconversion

2016-06-22T00:23:00+00:00

There are some cases where config options are moved, but they are
ripped off at the final savedefconfig stage:

  - The moved option is not user-configurable, for example, due to
    a missing prompt in the Kconfig entry

  - The config was not defined in the original config header despite
    the Kconfig specifies it as non-bool type

  - The config define in the header contains reference to another
    macro, for example:
        #define CONFIG_CONS_INDEX     (CONFIG_SYS_LPC32XX_UART - 2)
    The current moveconfig does not support recursive macro expansion.

In these cases, the conversion is very likely to be an unexpected
result.  That is why I decided to display the log in yellow color
in commit 5da4f857beac ("tools: moveconfig: report when CONFIGs are
removed by savedefconfig").

It would be nice to display the list of suspicious boards when the
tool finishes processing.  It is highly recommended to check the
defconfigs once again when this message is displayed.

Signed-off-by: Masahiro Yamada 
Reviewed-by: Joe Hershberger

tools: moveconfig: simplify show_failed_boards() and show more info

2016-06-22T00:22:54+00:00

Since commit 1d085568b3de ("tools: moveconfig: display log atomically
in more readable format"), the function color_text() is clever enough
to exclude LF from escape sequences.  Exploit it for removing the
"for" loops from Slots.show_failed_boards().

Also, display "(the list has been saved in moveconfig.failed)" if
there are failed boards.

Signed-off-by: Masahiro Yamada 
Reviewed-by: Joe Hershberger

tools: moveconfig: simplify source tree switching

2016-06-22T00:22:48+00:00

The subprocess.Popen() does not change the child process's working
directory if cwd=None is given.  Let's exploit this fact to refactor
the source directory handling.

We no longer have to pass "-C " to the sub-process
because self.current_src_dir tracks the source tree against which we
want to run defconfig/autoconf.

The flag self.use_git_ref is not necessary either because we can know
the current state by checking whether the self.current_src_dir is a
valid string or None.

Signed-off-by: Masahiro Yamada

tools: moveconfig: change class WorkDir to class ReferenceSource

2016-06-22T00:22:42+00:00

The class WorkDir can be used in a very generic way, but currently
it is only used for containing a reference source directory.

This commit changes it for a more dedicated use.  The move_config
function can be more readable by enclosing the git-clone and git-
checkout in the class constructor.

Signed-off-by: Masahiro Yamada 
Reviewed-by: Joe Hershberger

tools: moveconfig: fix needless move for config with default 1

2016-06-22T00:22:42+00:00

When moving an integer type option with default value 1, the tool
moves configs with the same value as the default (, and then removed
by the later savedefconfig).  This is a needless operation.

The KconfigParser.parse_one_config() should compare the config after
the "=y -> =1" fixup.

Signed-off-by: Masahiro Yamada 
Reviewed-by: Joe Hershberger

tools: moveconfig: Add a new --git-ref option

2016-06-12T22:46:29+00:00

This option allows the 'make autoconf.mk' step to run against a former
repo state, while the savedefconfig step runs against the current repo
state. This is convenient for the case where something in the Kconfig
has changed such that the defconfig is no longer complete with the new
Kconfigs. This feature allows the .config to be built assuming those old
Kconfigs, but then savedefconfig based on the new state of the Kconfigs.

If in doubt, always specify this switch. It will always do the right
thing even if not required, but if it was required and you don't use it,
the moved configs will be incorrect. When not using this switch, you
must very carefully evaluate that all moved configs are correct.

Signed-off-by: Joe Hershberger 
Reviewed-by: Masahiro Yamada

tools: moveconfig: New color used for changed defconfig

2016-06-12T22:46:28+00:00

The old color blends in with similar messages and makes them not stand
out.

Signed-off-by: Joe Hershberger 
Reviewed-by: Masahiro Yamada

tools: moveconfig: Fix another typo

2016-06-12T22:46:28+00:00

Signed-off-by: Joe Hershberger 
Reviewed-by: Masahiro Yamada

tools: moveconfig: make Slot.poll() more readable with helper methods

2016-06-12T22:46:28+00:00

The Slot.poll() method is already complicated and a new feature
we are going to add will make it more difficult to understand
the execution flow.

Refactor it with helper methods, .handle_error(), .do_defconfig(),
.do_autoconf(), .do_savedefconfig, and .update_defconfig().

Signed-off-by: Masahiro Yamada

tools: moveconfig: allow to run without any CONFIG specified

2016-06-12T22:46:28+00:00

I found "tools/moveconfig -s" might be useful for defconfig re-sync.
I could optimize it for re-sync if I wanted, but I do not want to
make the code complex for this feature.

Signed-off-by: Masahiro Yamada 
Reviewed-by: Joe Hershberger