u-boot.git/tools/patman/test_checkpatch.py, branch v2022.01

checkpatch: Add warnings for using strn(cat|cpy)

2021-04-12T21:44:55Z

strn(cat|cpy) has a bad habit of not nul-terminating the destination, resulting in constructions like strncpy(foo, bar, sizeof(foo) - 1); foo[sizeof(foo) - 1] = '\0'; However, it is very easy to forget about this behavior and accidentally leave a string unterminated. This has shown up in some recent coverity scans [1, 2] (including code recently touched by yours truly). Fortunately, the guys at OpenBSD came up with strl(cat|cpy), which always nul-terminate strings. These functions are already in U-Boot, so we should encourage new code to use them instead of strn(cat|cpy). [1] https://lists.denx.de/pipermail/u-boot/2021-March/442888.html [2] https://lists.denx.de/pipermail/u-boot/2021-January/438073.html Signed-off-by: Sean Anderson Reviewed-by: Simon Glass

checkpatch: Add warnings for unexpected struct names

2020-12-13T23:51:09Z

As a way of keeping the driver declarations more consistent, add a warning if the struct used does not end with _priv or _plat. Signed-off-by: Simon Glass

patman: Rename functions in patchstream

2020-11-05T16:11:31Z

Rename these functions to lower case as per PEP8. Signed-off-by: Simon Glass

checkpatch.pl: Make CONFIG_IS_ENABLED(CONFIG_*) an error

2020-10-14T15:16:34Z

CONFIG_IS_ENABLED() takes the kconfig name without the CONFIG_ prefix, e.g. CONFIG_IS_ENABLED(CLK) for CONFIG_CLK. Make including the prefix an error in checkpatch.pl so calls in the wrong format aren't accidentally reintroduced. Signed-off-by: Alper Nebi Yasak Reviewed-by: Simon Glass

checkpatch: Don't allow common.h and dm.h in headers

2020-08-04T02:19:54Z

These headers should not be included in other header files. Add a checkpatch rule and test for this. Signed-off-by: Simon Glass

patman: Fix up the test comments

2020-08-04T02:19:54Z

Many of the tests have the same comment and two have the same name. Fix this. Signed-off-by: Simon Glass

checkpatch: Don't warn about PREFER_IF in headers/DT files

2020-07-10T00:57:22Z

This warning should only be displayed for C files. Fix it and update the test. Signed-off-by: Simon Glass

patman: Add tests for the rest of the checkpatch checks

2020-07-10T00:57:22Z

Finish off the tests for our small collection of checkpatch checks. Signed-off-by: Simon Glass

patman: Decode output from the '--show-types' option

2020-07-10T00:57:22Z

Collect the 'checkpatch type' from each error, warning and check. Provide this to patman and update the uclass test to use it. Signed-off-by: Simon Glass

patman: Add a test for the 'possible new uclass' check

2020-07-10T00:57:22Z

It is quite likely that the number of U-Boot-specific tests in checkpatch.pl will increase over time. We should have tests for these to avoid undefined behaviour and bugs being introduced, which might cause people to ignore the warnings. Add a simple new class that can generate a patch with a single-line addition in it. Use that to add a test for one of the checkpatch checks. Signed-off-by: Simon Glass