u-boot.git/tools/patman, branch v2017.07

patman: Add a functional test

2017-06-09T02:21:59+00:00

The existing test (patman --test) only covers basic checkpatch output.
We have had some problems with unicode processing and could use test
coverage for the various tags patman supports.

Add a new functional test which runs most of the patman flow on a few
test commits and checks that the results are correct.

See the documentation in the test for a description of what it does.

Signed-off-by: Simon Glass 
Tested-by: Philipp Tomsich

patman: Rename 'list' variable in MakeCcFile()

2017-06-09T02:21:59+00:00

This is not a good variable name in Python because 'list' is a type. It
shows up highlighted in some editors. Rename it.

Signed-off-by: Simon Glass 
Tested-by: Philipp Tomsich

patman: Add a maintainer test feature to MakeCcFile()

2017-06-09T02:21:59+00:00

Allow the add_maintainers parameter to be a list of maintainers, thus
allowing us to simulate calling the script in tests without actually
needing it to work.

Signed-off-by: Simon Glass 
Tested-by: Philipp Tomsich

patman: Add unicode to test patches

2017-06-09T02:21:59+00:00

Add some unicode to the test patches to make sure that patman does the
right thing.

Signed-off-by: Simon Glass 
Tested-by: Philipp Tomsich

patman: Don't return the series in FixPatches()

2017-06-09T02:21:59+00:00

There is no need for this function to return the same object that was
passed in. Drop the return value.

Signed-off-by: Simon Glass 
Tested-by: Philipp Tomsich

patman: Don't report unicode character

2017-06-09T02:21:59+00:00

Unicode characters may appear in input patches so we should not warn about
them. Drop this warning.

Signed-off-by: Simon Glass 
Tested-by: Philipp Tomsich

patman: Rename 'str' variable in EmailPatches()

2017-06-09T02:21:59+00:00

This is not a good variable name in Python because 'str' is a type. It
shows up highlighted in some editors. Rename it.

Signed-off-by: Simon Glass 
Tested-by: Philipp Tomsich

patman: Don't convert input data to unicode

2017-06-09T02:21:59+00:00

The communication filter reads data in blocks and converts each block to
unicode (if necessary) one at a time. In the unlikely event that a unicode
character in the input spans a block this will not work. We get an error
like:

UnicodeDecodeError: 'utf8' codec can't decode bytes in position 1022-1023:
   unexpected end of data

There is no need to change the input to unicode, so the easiest fix is to
drop this feature.

Signed-off-by: Simon Glass 
Tested-by: Philipp Tomsich

patman: Adjust handling of unicode email address

2017-06-09T02:21:59+00:00

Don't mess with the email address when outputting them. Just make sure
they are encoded with utf-8.

Signed-off-by: Simon Glass 
Tested-by: Philipp Tomsich

patman: encode CC list to UTF-8

2017-06-09T02:21:59+00:00

This change encodes the CC list to UTF-8 to avoid failures on
maintainer-addresses that include non-ASCII characters (observed on
Debian 7.11 with Python 2.7.3).

Without this, I get the following failure:
  Traceback (most recent call last):
    File "tools/patman/patman", line 159, in 
      options.add_maintainers)
    File "[snip]/u-boot/tools/patman/series.py", line 234, in MakeCcFile
      print(commit.patch, ', '.join(set(list)), file=fd)
  UnicodeEncodeError: 'ascii' codec can't encode character u'\xfc' in position 81: ordinal not in range(128)
from Heiko's email address:
  [..., u'"Heiko St\xfcbner" ', ...]

While with this change added this encodes to:
  "=?UTF-8?q?Heiko=20St=C3=BCbner?= "

Signed-off-by: Philipp Tomsich 
Reviewed-by: Simon Glass 
Signed-off-by: Simon Glass 
Tested-by: Simon Glass 
Tested-by: Philipp Tomsich