u-boot.git/tools, branch v2016.09-rc2

tools/env: soften warning about erase block alignment

2016-08-20T18:03:27+00:00

addon 183923d3e
MMC/SATA have no erase blocks, only blocks. Hence the warning
about erase block alignment might be confusing in such environment.

Signed-off-by: Andreas Fenkart 
Reviewed-by: Tom Rini

tools/env: return with error if redundant environments have unequal size

2016-08-20T18:03:26+00:00

For double buffering to work, the target buffer must always be big
enough to hold all data. This can only be ensured if buffers are of
equal size, otherwise one must be smaller and we risk data loss
when copying from the bigger to the smaller buffer.

Reviewed-by: Simon Glass 
Signed-off-by: Andreas Fenkart 
Reviewed-by: Tom Rini

tools/env: ensure environment starts at erase block boundary

2016-08-15T22:46:40+00:00

56086921 added support for unaligned environments access.
U-boot itself does not support this:
- env_nand.c fails when using an unaligned offset. It produces an
  error in nand_erase_opts{drivers/mtd/nand/nand_util.c}
- in env_sf/env_flash the unused space at the end is preserved, but
  not in the beginning. block alignment is assumed
- env_sata/env_mmc aligns offset/length to the block size of the
  underlying device. data is silently redirected to the beginning of
  a block

There is seems no use case for unaligned environment. If there is
some useful data at the beginning of the the block (e.g. end of u-boot)
that would be very unsafe. If the redundant environments are hosted by
the same erase block then that invalidates the idea of double buffering.
It might be that unaligned access was allowed in the past, and that
people with legacy u-boot are trapped. But at the time of 56086921
it wasn't supported and due to reasons above I guess it was never
introduced.
I prefer to remove that (unused) feature in favor of simplicity

Signed-off-by: Andreas Fenkart 
Acked-by: Stefan Agner

mkimage: Fix argument parsing with signature comment

2016-08-06T00:55:23+00:00

Inform getopt that '-c' requires a parameter.

Fixes: a02221f29deb ("mkimage: Convert to use getopt()")
Signed-off-by: Karl Beldan 
Reviewed-by: Tom Rini

tools: moveconfig: support CONFIG_SYS_EXTRA_OPTIONS cleaning

2016-08-05T11:27:18+00:00

We mostly move config options from board header files to Kconfig,
but sometimes config defines come from CONFIG_SYS_EXTRA_OPTIONS.

Historically, CONFIG_SYS_EXTRA_OPTIONS originates in boards.cfg,
which was used as a central database of configuration prior to the
Kconfig conversion.

Now, we want to migrate to primary entries in Kconfig rather than
option list in CONFIG_SYS_EXTRA_OPTIONS, so it should be helpful to
have the tool to cleanup CONFIG_SYS_EXTRA_OPTIONS automatically.

Signed-off-by: Masahiro Yamada 
Reviewed-by: Tom Rini

tools: moveconfig: make getting all defconfigs into helper function

2016-08-05T11:27:17+00:00

I want to reuse this routine in the next commit.

Signed-off-by: Masahiro Yamada 
Reviewed-by: Tom Rini

tools: moveconfig: fix cleanup of defines across multiple lines

2016-08-05T11:27:17+00:00

Correct the clean-up of such defines that continue across multiple
lines, like follows:

  #define CONFIG_FOO "this continues to the next line " \
          "this line should be removed too" \
          "this line should be removed as well"

Signed-off-by: Masahiro Yamada 
Reviewed-by: Tom Rini

tools: moveconfig: show diffs of cleaned headers in color

2016-08-05T11:27:16+00:00

Show code diff in color if --color option is given.

Signed-off-by: Masahiro Yamada 
Reviewed-by: Tom Rini

tools: moveconfig: show result of header cleaning in unified diff

2016-08-05T11:27:16+00:00

The header cleanup feature of this tool now removes empty ifdef's,
successive blank lines as well as moved option defines.  So, we
want to see a little more context to check which lines were deleted.

It is true that we can see it by "git diff", but it would not work
in the --dry-run mode.  So, here, this commit.

Signed-off-by: Masahiro Yamada

tools: moveconfig: trim garbage lines after header cleanups

2016-08-05T11:27:16+00:00

The tools/moveconfig.py has a feature to cleanup #define/#undef's
of moved config options, but I want this tool to do a better job.

For example, when we are moving CONFIG_FOO and its define is
surrounded by #ifdef ... #endif, like follows:

  #ifdef CONFIG_BAR
  #  define CONFIG_FOO
  #endif

The header cleanup will leave empty #ifdef ... #endif:

  #ifdef CONFIG_BAR
  #endif

Likewise, if a define line between two blank lines

  
  #define CONFIG_FOO