u-boot.git/tools, branch v2020.10-rc2

mkimage: fit: fix import of external data

2020-08-07T15:47:18+00:00

The external data is located after the mmapped FDT pointed to by
'old_fdt', not in the newly created FDT we are importing into at 'fdt'.

Signed-off-by: Patrick Oppenlander

mkimage: fit: include image cipher in configuration signature

2020-08-07T15:47:18+00:00

This patch addresses issue #2 for signed configurations.

-----8<-----

Including the image cipher properties in the configuration signature
prevents an attacker from modifying cipher, key or iv properties.

Signed-off-by: Patrick Oppenlander 
Reviewed-by: Philippe Reynes

mkimage: fit: don't cipher ciphered data

2020-08-07T15:47:18+00:00

Previously, mkimage -F could be run multiple times causing already
ciphered image data to be ciphered again.

Signed-off-by: Patrick Oppenlander 
Reviewed-by: Philippe Reynes

mkimage: fit: handle FDT_ERR_NOSPACE when ciphering

2020-08-07T15:47:18+00:00

Also replace fdt_delprop/fdt_setprop with fdt_setprop as fdt_setprop can
replace an existing property value.

Signed-off-by: Patrick Oppenlander 
Reviewed-by: Philippe Reynes

mkimage: fit: only process one cipher node

2020-08-07T15:47:18+00:00

Previously mkimage would process any node matching the regex cipher.*
and apply the ciphers to the image data in the order they appeared in
the FDT. This meant that data could be inadvertently ciphered multiple
times.

Switch to processing a single cipher node which exactly matches
FIT_CIPHER_NODENAME.

Signed-off-by: Patrick Oppenlander 
Reviewed-by: Philippe Reynes

tools: env: Avoid an uninited warning with was_locked

2020-08-05T12:18:34+00:00

Set this variable to 0 to avoid a warning about an unused variable. This
happens on gcc 7.5.0 for me.

Signed-off-by: Simon Glass

tools: env: Fix printf() warning in fw_env

2020-08-05T12:18:34+00:00

The printf() string produces a warning about %d not matching size_t. Fix
it and put the format string on one line to avoid a checkpatch warning.

Signed-off-by: Simon Glass

fit_image: Use calloc() to fix reproducibility issue

2020-08-05T12:18:34+00:00

Vagrant Cascadian reported that mx6cuboxi target no longer builds
reproducibility on Debian.

One example of builds mismatches:

00096680: 696e 6700 736f 756e 642d 6461 6900 6465  ing.sound-dai.de
-00096690: 7465 6374 2d67 7069 6f73 0000            tect-gpios..
+00096690: 7465 6374 2d67 7069 6f73 0061            tect-gpios.a

This problem happens because all the buffers in fit_image.c are
allocated via malloc(), which does not zero out the allocated buffer.

Using calloc() fixes this unpredictable behaviour as it guarantees
that the allocated buffer are zero initialized.

Reported-by: Vagrant Cascadian 
Suggested-by: Tom Rini 
Signed-off-by: Fabio Estevam 
Tested-by: Vagrant Cascadian

checkpatch: Don't allow common.h and dm.h in headers

2020-08-04T02:19:54+00:00

These headers should not be included in other header files. Add a
checkpatch rule and test for this.

Signed-off-by: Simon Glass

patman: Fix up the test comments

2020-08-04T02:19:54+00:00

Many of the tests have the same comment and two have the same name. Fix
this.

Signed-off-by: Simon Glass