diff options
| author | Naveen Kumar Chaudhary <[email protected]> | 2026-06-07 21:15:42 +0530 |
|---|---|---|
| committer | Tom Rini <[email protected]> | 2026-06-23 12:37:21 -0600 |
| commit | d73aed0b0571828c7ee308adcb1bb1145892dfd1 (patch) | |
| tree | 6ff13165777bb74f649d2e775e071d48141ed20d | |
| parent | 0bef438428ca0118da2ebb44493d5d2090cb05a2 (diff) | |
serial: goldfish: return error when device address is invalid
goldfish_serial_of_to_plat() returns success even when dev_read_addr()
fails to find a valid address. This leaves plat->reg unset and defers
the failure to probe().
Return -EINVAL immediately when the address is FDT_ADDR_T_NONE so the
failure is reported at the of_to_plat stage where it belongs.
Signed-off-by: Naveen Kumar Chaudhary <[email protected]>
Acked-by: Kuan-Wei Chiu <[email protected]>
| -rw-r--r-- | drivers/serial/serial_goldfish.c | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/drivers/serial/serial_goldfish.c b/drivers/serial/serial_goldfish.c index 91dc040fcf2..732f167caae 100644 --- a/drivers/serial/serial_goldfish.c +++ b/drivers/serial/serial_goldfish.c @@ -74,8 +74,10 @@ static int goldfish_serial_of_to_plat(struct udevice *dev) fdt_addr_t addr; addr = dev_read_addr(dev); - if (addr != FDT_ADDR_T_NONE) - plat->reg = addr; + if (addr == FDT_ADDR_T_NONE) + return -EINVAL; + + plat->reg = addr; return 0; } |