From 8a5ddf6cd349ef86eb8f3c44381cdccb8a848c66 Mon Sep 17 00:00:00 2001 From: David Lechner Date: Fri, 7 Aug 2026 13:59:41 -0500 Subject: serial: mtk: return error value from clk_get_rate() Pass the return value from clk_get_rate() instead of changing it to -EINVAL. These return values are either ignored or logged, so it should make debugging easier in the cases where it is logged. Reviewed-by: Julien Stephan Link: https://patch.msgid.link/20260807-serial-mtk-clock-fixes-v3-3-8cc94d313b57@baylibre.com Signed-off-by: David Lechner --- drivers/serial/serial_mtk.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/serial/serial_mtk.c b/drivers/serial/serial_mtk.c index 697f5faec1b..d6a7cf488b9 100644 --- a/drivers/serial/serial_mtk.c +++ b/drivers/serial/serial_mtk.c @@ -218,7 +218,7 @@ static int mtk_serial_setbrg(struct udevice *dev, int baudrate) if (clk_valid(&priv->clk)) { clk_rate = clk_get_rate(&priv->clk); if (IS_ERR_VALUE(clk_rate) || clk_rate == 0) - return -EINVAL; + return (int)clk_rate ?: -EINVAL; } else { clk_rate = priv->fixed_clk_rate; } @@ -290,7 +290,7 @@ static int mtk_serial_of_to_plat(struct udevice *dev) clk_rate = clk_get_rate(&priv->clk); if (IS_ERR_VALUE(clk_rate)) { dev_err(dev, "invalid baud clock\n"); - return -EINVAL; + return clk_rate; } } -- cgit v1.3.1