From 8ea70d8132df30c37c9592952c6267c2e9b4e562 Mon Sep 17 00:00:00 2001 From: Petr Beneš Date: Thu, 18 Dec 2025 15:27:36 +0100 Subject: usb: ci_udc: cosmetics: EP and requests debug info MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Make a note in an unexpected situation, e.g. queuing a request on a disabled endpoint, enabling an enabled endpoint... Reviewed-by: Mattijs Korpershoek Signed-off-by: Petr Beneš Link: https://lore.kernel.org/r/20251218142737.3169753-2-petr.benes@ysoft.com Signed-off-by: Mattijs Korpershoek --- drivers/usb/gadget/ci_udc.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/drivers/usb/gadget/ci_udc.c b/drivers/usb/gadget/ci_udc.c index c8953d48723..046bb335ecb 100644 --- a/drivers/usb/gadget/ci_udc.c +++ b/drivers/usb/gadget/ci_udc.c @@ -273,8 +273,10 @@ ci_ep_alloc_request(struct usb_ep *ep, unsigned int gfp_flags) if (ci_ep->desc) num = ci_ep->desc->bEndpointAddress & USB_ENDPOINT_NUMBER_MASK; - if (num == 0 && controller.ep0_req) + if (num == 0 && controller.ep0_req) { + DBG("%s: already got controller.ep0_req = %p\n", __func__, controller.ep0_req); return &controller.ep0_req->req; + } ci_req = calloc(1, sizeof(*ci_req)); if (!ci_req) @@ -296,6 +298,8 @@ static void ci_ep_free_request(struct usb_ep *ep, struct usb_request *req) if (ci_ep->desc) num = ci_ep->desc->bEndpointAddress & USB_ENDPOINT_NUMBER_MASK; + else + DBG("%s: no endpoint %p descriptor\n", __func__, ci_ep); if (num == 0) { if (!controller.ep0_req) @@ -624,8 +628,10 @@ static int ci_ep_dequeue(struct usb_ep *_ep, struct usb_request *_req) break; } - if (&ci_req->req != _req) + if (&ci_req->req != _req) { + DBG("%s: ci_req not found in the queue\n", __func__); return -EINVAL; + } list_del_init(&ci_req->queue); -- cgit v1.3.1