From c525423e5cd66f88237d67071f169ed16df4d1a8 Mon Sep 17 00:00:00 2001 From: Devarsh Thakkar Date: Wed, 25 Sep 2024 20:43:52 +0530 Subject: boot/Kconfig: Add Video Kconfig as dependency for FDT_SIMPLEFB The fdt_simplefb.c APIs rely on video-uclass APIs and structures to fill/update framebuffer information, so compile it only when VIDEO Kconfig is enabled, as otherwise below warning can be seen if VIDEO Kconfig is disabled: "boot/fdt_simplefb.c:96:12: warning: fdt_simplefb_enable_existing_node defined but not used [-Wunused-function] 96 | static int fdt_simplefb_enable_existing_node(void *blob)" Reported-by: Mattijs Korpershoek Signed-off-by: Devarsh Thakkar Reviewed-by: Mattijs Korpershoek --- boot/Kconfig | 1 + 1 file changed, 1 insertion(+) (limited to 'boot') diff --git a/boot/Kconfig b/boot/Kconfig index 1ce1da6020c..fe2919f18c4 100644 --- a/boot/Kconfig +++ b/boot/Kconfig @@ -1683,6 +1683,7 @@ config FDT_FIXUP_PARTITIONS config FDT_SIMPLEFB bool "FDT tools for simplefb support" + depends on VIDEO help Enable the fdt tools to manage the simple fb nodes in device tree. These functions can be used by board to indicate to the OS -- cgit v1.3.1 From 944e515e759db4f9660245bd09e2df9051dd0b27 Mon Sep 17 00:00:00 2001 From: Devarsh Thakkar Date: Wed, 25 Sep 2024 20:43:53 +0530 Subject: boot: fdt_simplefb: Remove conditional compilation checks for VIDEO Kconfig CONFIG_VIDEO conditional compilation checks are no longer needed since FDT_SIMPLEFB Kconfig now depends on VIDEO Kconfig. Signed-off-by: Devarsh Thakkar Reviewed-by: Mattijs Korpershoek --- boot/fdt_simplefb.c | 2 -- 1 file changed, 2 deletions(-) (limited to 'boot') diff --git a/boot/fdt_simplefb.c b/boot/fdt_simplefb.c index 71b833eb9bd..5822131767d 100644 --- a/boot/fdt_simplefb.c +++ b/boot/fdt_simplefb.c @@ -103,7 +103,6 @@ static int fdt_simplefb_enable_existing_node(void *blob) return fdt_simplefb_configure_node(blob, off); } -#if IS_ENABLED(CONFIG_VIDEO) int fdt_simplefb_enable_and_mem_rsv(void *blob) { int ret; @@ -118,4 +117,3 @@ int fdt_simplefb_enable_and_mem_rsv(void *blob) return fdt_add_fb_mem_rsv(blob); } -#endif -- cgit v1.3.1