From 4de6d37fa289a4da32a395e5cc97a6649b948144 Mon Sep 17 00:00:00 2001 From: Heinrich Schuchardt Date: Wed, 6 Mar 2024 15:44:02 +0100 Subject: cmd: sbi: Correctly display unknown implementation IDs For an unknown implementation ID an output like SBI 1.0Unknown implementation ID 16777216 Extensions: sbi_set_timer ... was shown. The number 16777216 is not the implementation ID. * Show the correct number * Use a hexadecimal output format * Add a missing line feed Signed-off-by: Heinrich Schuchardt Reviewed-by: Conor Dooley Reviewed-by: Dan Carpenter --- cmd/riscv/sbi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'cmd') diff --git a/cmd/riscv/sbi.c b/cmd/riscv/sbi.c index 9daf0e247ad..87f7966f06b 100644 --- a/cmd/riscv/sbi.c +++ b/cmd/riscv/sbi.c @@ -99,7 +99,7 @@ static int do_sbi(struct cmd_tbl *cmdtp, int flag, int argc, } } if (i == ARRAY_SIZE(implementations)) - printf("Unknown implementation ID %ld", ret); + printf("\nUnknown implementation ID 0x%x", impl_id); } printf("\nMachine:\n"); ret = sbi_get_mvendorid(&mvendorid); -- cgit v1.2.3 From 3a223ff63c0699e3ab977b41fa8e94ab07aa11a5 Mon Sep 17 00:00:00 2001 From: Heinrich Schuchardt Date: Wed, 6 Mar 2024 15:48:52 +0100 Subject: cmd: sbi: formatting PolarFire Hart Software Services version The 'PolarFire Hart Software Services' SBI implementation returns the version of the incorporated OpenSBI. Format the number accordingly. Signed-off-by: Heinrich Schuchardt Reviewed-by: Conor Dooley --- cmd/riscv/sbi.c | 1 + 1 file changed, 1 insertion(+) (limited to 'cmd') diff --git a/cmd/riscv/sbi.c b/cmd/riscv/sbi.c index 87f7966f06b..bd9d9c4765d 100644 --- a/cmd/riscv/sbi.c +++ b/cmd/riscv/sbi.c @@ -81,6 +81,7 @@ static int do_sbi(struct cmd_tbl *cmdtp, int flag, int argc, break; switch (impl_id) { case 1: /* OpenSBI */ + case 8: /* PolarFire Hart Software Services */ printf("%ld.%ld", vers >> 16, vers & 0xffff); break; -- cgit v1.2.3