From 29f925d8f9c7d0e1aea340e537e2423f659f851d Mon Sep 17 00:00:00 2001 From: Ying Sun Date: Sun, 25 Jun 2023 16:52:07 +0800 Subject: common: Kconfig: SYS_CONSOLE_ENV_OVERWRITE depends on SYS_CONSOLE_IS_IN_ENV CONFIG_SYS_CONSOLE_ENV_OVERWRITE is implemented in common/console.c when "#if CONFIG_IS_ENABLED(SYS_CONSOLE_IS_IN_ENV)" is met. It is recommended to add dependency constraints to its definition. Suggested-by: Yanjie Ren Signed-off-by: Ying Sun --- common/Kconfig | 1 + 1 file changed, 1 insertion(+) (limited to 'common') diff --git a/common/Kconfig b/common/Kconfig index bbabadb35e1..42baca20a61 100644 --- a/common/Kconfig +++ b/common/Kconfig @@ -256,6 +256,7 @@ config SYS_CONSOLE_OVERWRITE_ROUTINE config SYS_CONSOLE_ENV_OVERWRITE bool "Update environment variables during console init" + depends on SYS_CONSOLE_IS_IN_ENV help The console environment variables (stdout, stdin, stderr) can be used to determine the correct console devices on start-up. This -- cgit v1.2.3 From 0f42f8995593570b0a0d0726cd1f021b5f90172f Mon Sep 17 00:00:00 2001 From: Ying Sun Date: Sun, 25 Jun 2023 17:18:21 +0800 Subject: tpl: Kconfig: TPL_BANNER_PRINT depends on DEBUG_UART && TPL_SERIAL As implemented in the arch/arm/mach-rockchip/tpl.c file, the CONFIG_TPL_BANNER_PRINT option will not work if either of these options is not enabled. Add dependency constraints to the CONFIG_TPL_BANNER_PRINT option definition to prevent configuration problems where option is enabled but do not take effect. Suggested-by: Yanjie Ren Signed-off-by: Ying Sun --- common/spl/Kconfig.tpl | 1 + 1 file changed, 1 insertion(+) (limited to 'common') diff --git a/common/spl/Kconfig.tpl b/common/spl/Kconfig.tpl index 1874f9db4f9..3d6cf1e59f3 100644 --- a/common/spl/Kconfig.tpl +++ b/common/spl/Kconfig.tpl @@ -43,6 +43,7 @@ config TPL_FRAMEWORK config TPL_BANNER_PRINT bool "Enable output of the TPL banner 'U-Boot TPL ...'" + depends on DEBUG_UART && TPL_SERIAL default y help If this option is enabled, TPL will print the banner with version -- cgit v1.2.3