From 6ea8dc661b04ddd5c19163932ee12705c53f552a Mon Sep 17 00:00:00 2001 From: Nam Cao Date: Thu, 7 Nov 2024 16:01:06 +0100 Subject: fs: Use ARCH_DMA_MINALIGN as default alignment for fs_read_alloc() The comment above fs_read_alloc() explains: @align: Alignment to use for memory allocation (0 for default) However, in the actual implementation, there is no alignment when @align is zero. This current default is probably fine for most cases. But for some block devices which transfer data via DMA, ARCH_DMA_MINALIGN is needed. Change the default alignment to ARCH_DMA_MINALIGN. Fixes: de7b5a8a1ac0 ("fs: Create functions to load and allocate a file") Signed-off-by: Nam Cao Tested-by: Javier Fernandez Pastrana --- fs/fs.c | 4 ++++ 1 file changed, 4 insertions(+) (limited to 'fs') diff --git a/fs/fs.c b/fs/fs.c index 1afa0fbeaed..21a23efd932 100644 --- a/fs/fs.c +++ b/fs/fs.c @@ -23,6 +23,7 @@ #include #include #include +#include #include #include #include @@ -1001,6 +1002,9 @@ int fs_read_alloc(const char *fname, ulong size, uint align, void **bufp) char *buf; int ret; + if (!align) + align = ARCH_DMA_MINALIGN; + buf = memalign(align, size + 1); if (!buf) return log_msg_ret("buf", -ENOMEM); -- cgit v1.2.3