From a99d652ff1e8fa98228ebec9009cd06ba17139bd Mon Sep 17 00:00:00 2001 From: Manorit Chawdhry Date: Mon, 8 Jan 2024 13:48:48 +0530 Subject: include: env: ti: ti_common: Fix a missing semicolon Fix a missing semicolon that leads to syntax error while booting j721s2. Importing environment from mmc1 ... syntax error at 'run'HUSH died! Fixes: 0d72b0f2f83b ("include: env: ti: ti_common: Run main_cpsw0_qsgmii_phyinit conditionally") Signed-off-by: Manorit Chawdhry Reviewed-by: Mattijs Korpershoek --- include/env/ti/ti_common.env | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'include/env') diff --git a/include/env/ti/ti_common.env b/include/env/ti/ti_common.env index f0f89a22876..5473f633aa7 100644 --- a/include/env/ti/ti_common.env +++ b/include/env/ti/ti_common.env @@ -27,7 +27,7 @@ bootcmd_ti_mmc= #if CONFIG_CMD_REMOTEPROC if test ${do_main_cpsw0_qsgmii_phyinit} -eq 1; then run main_cpsw0_qsgmii_phyinit; - fi + fi; run boot_rprocs; #endif if test ${boot_fit} -eq 1; -- cgit v1.2.3 From 27cc5951c862355da310e0bd2c42487979b9fa00 Mon Sep 17 00:00:00 2001 From: Manorit Chawdhry Date: Mon, 8 Jan 2024 13:48:49 +0530 Subject: include: env: ti: add default for do_main_cpsw0_qsgmii_phyinit By default this variable is unset and this causes the test condition to fail on devices that don't have this defined. Set a default value for this. => boot ## Error: "main_cpsw0_qsgmii_phyinit" not defined [...] Fixes: 0d72b0f2f83b ("include: env: ti: ti_common: Run main_cpsw0_qsgmii_phyinit conditionally") Signed-off-by: Manorit Chawdhry Reviewed-by: Mattijs Korpershoek --- include/env/ti/ti_common.env | 1 + 1 file changed, 1 insertion(+) (limited to 'include/env') diff --git a/include/env/ti/ti_common.env b/include/env/ti/ti_common.env index 5473f633aa7..02b410c3adc 100644 --- a/include/env/ti/ti_common.env +++ b/include/env/ti/ti_common.env @@ -22,6 +22,7 @@ get_fit_overlaystring= done; get_fit_config=setexpr name_fit_config gsub / _ conf-${fdtfile} run_fit=run get_fit_config; bootm ${addr_fit}#${name_fit_config}${overlaystring} +do_main_cpsw0_qsgmii_phyinit=0 bootcmd_ti_mmc= run findfdt; run init_${boot}; #if CONFIG_CMD_REMOTEPROC -- cgit v1.2.3