From 6b84b1db2d69609a783ab2fd6990c9e72903d367 Mon Sep 17 00:00:00 2001 From: Rasmus Villemoes Date: Fri, 28 Oct 2022 13:50:51 +0200 Subject: cyclic: drop redundant cyclic_ready flag We're already relying on gd->cyclic being NULL before cyclic_init() is called - i.e., we're relying on all of gd being zeroed before entering any C code. And when we do populate gd->cyclic, its ->cyclic_ready member is automatically set to true. So we can actually just rely on testing gd->cyclic itself. The only wrinkle is that cyclic_uninit() actually did set ->cyclic_ready to false. However, since it doesn't free gd->cyclic, the cyclic infrastructure is actually still ready (i.e., the list_head is properly initialized as an empty list). Signed-off-by: Rasmus Villemoes Reviewed-by: Stefan Roese Tested-by: Stefan Roese Tested-by: Tim Harvey # imx8mm-venice-* --- include/cyclic.h | 2 -- 1 file changed, 2 deletions(-) (limited to 'include') diff --git a/include/cyclic.h b/include/cyclic.h index 50427baa3f4..263b74d89b8 100644 --- a/include/cyclic.h +++ b/include/cyclic.h @@ -18,11 +18,9 @@ * struct cyclic_drv - Cyclic driver internal data * * @cyclic_list: Cylic list node - * @cyclic_ready: Flag if cyclic infrastructure is ready */ struct cyclic_drv { struct list_head cyclic_list; - bool cyclic_ready; }; /** -- cgit v1.3.1