From 6d9949fe866751c527c5dafab5350af89b7b8332 Mon Sep 17 00:00:00 2001 From: Patrick Delaunay Date: Thu, 24 Sep 2020 17:26:20 +0200 Subject: dm: update test on of_offset in ofnode_valid Update the test for node.of_offset because an invalid offset is not always set to -1 because the return value of the libfdt functions are: + an error with a value < 0 + a valid offset with value >=0 For example, in ofnode_get_by_phandle() function, we have: node.of_offset = fdt_node_offset_by_phandle(gd->fdt_blob, phandle); and this function can return -FDT_ERR_BADPHANDLE (-6). Without this patch, the added test dm_test_ofnode_get_by_phandle failed. Signed-off-by: Patrick Delaunay Reviewed-by: Simon Glass --- include/dm/ofnode.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'include') diff --git a/include/dm/ofnode.h b/include/dm/ofnode.h index d7852daf7f4..98c64fece30 100644 --- a/include/dm/ofnode.h +++ b/include/dm/ofnode.h @@ -128,7 +128,7 @@ static inline bool ofnode_valid(ofnode node) if (of_live_active()) return node.np != NULL; else - return node.of_offset != -1; + return node.of_offset >= 0; } /** -- cgit v1.3.1