From 8a655272d7b440dc3eeda598eb2d05819c0f75c2 Mon Sep 17 00:00:00 2001 From: Simon Glass Date: Sat, 23 Jan 2021 11:08:38 -0700 Subject: acpi: Tidy up documentation for struct acpi_gpio Some comments were provided after this patch was applied. Address them. Signed-off-by: Simon Glass Reviewed-by: Bin Meng --- include/acpi/acpi_device.h | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) (limited to 'include') diff --git a/include/acpi/acpi_device.h b/include/acpi/acpi_device.h index ed4acd912a1..2c8846250b6 100644 --- a/include/acpi/acpi_device.h +++ b/include/acpi/acpi_device.h @@ -171,10 +171,11 @@ enum acpi_gpio_polarity { * @io_restrict: I/O restriction setting * @polarity: GPIO polarity * - * Note that GpioIo doesn't have any means of Active Low / High setting, so a - * _DSD must be provided to mitigate this. + * Note that GpioIo() doesn't have any means of Active Low / High setting, so a + * _DSD must be provided to mitigate this. This parameter does not make sense + * for GpioInt() since it has its own means to define it. * - * GpioIo doesn't properly communicate the initial state of the output pin, + * GpioIo() doesn't properly communicate the initial state of the output pin, * thus Linux assumes the simple rule: * * Pull Bias Polarity Requested... @@ -184,7 +185,7 @@ enum acpi_gpio_polarity { * assuming non-active (Polarity = !Pull Bias) * * Down Low as low, assuming active - * Down High as high, assuming non-active + * Down High as low, assuming non-active * Up Low as high, assuming non-active * Up High as high, assuming active * -- cgit v1.2.3 From 86c372af1abd02f6d81c287159e5d80bb27b8ae4 Mon Sep 17 00:00:00 2001 From: Simon Glass Date: Sun, 24 Jan 2021 10:06:03 -0700 Subject: x86: spl: Add a function to find the text base It is useful to know the TEXT_BASE value for the image being loaded in TPL/SPL. Add a new spl_get_image_text_base() function to handle this. Make use of this in the x86 SPL handler, instead of having the logic there. Signed-off-by: Simon Glass Reviewed-by: Bin Meng --- include/spl.h | 10 ++++++++++ 1 file changed, 10 insertions(+) (limited to 'include') diff --git a/include/spl.h b/include/spl.h index faffeb519ac..e172500b5f8 100644 --- a/include/spl.h +++ b/include/spl.h @@ -254,6 +254,16 @@ ulong spl_get_image_pos(void); */ ulong spl_get_image_size(void); +/** + * spl_get_image_text_base() - get the text base of the next phase + * + * This returns the address that the next stage is linked to run at, i.e. + * CONFIG_SPL_TEXT_BASE or CONFIG_SYS_TEXT_BASE + * + * @return text-base address + */ +ulong spl_get_image_text_base(void); + /** * spl_load_simple_fit_skip_processing() - Hook to allow skipping the FIT * image processing during spl_load_simple_fit(). -- cgit v1.2.3 From 77f898d04095cdccb69c476ba0aa19f257fca64d Mon Sep 17 00:00:00 2001 From: Simon Glass Date: Sun, 31 Jan 2021 09:17:07 -0700 Subject: x86: Reduce size of samus image With the recent addition of ACPI generation, the image size has got beyond its current limit. Samus does not actually use this, nor x86 emulation for PCI ROMs, so disable both features. Signed-off-by: Simon Glass Reviewed-by: Bin Meng --- include/configs/chromebook_samus.h | 3 +++ 1 file changed, 3 insertions(+) (limited to 'include') diff --git a/include/configs/chromebook_samus.h b/include/configs/chromebook_samus.h index dfeede7e91a..2fe3e721993 100644 --- a/include/configs/chromebook_samus.h +++ b/include/configs/chromebook_samus.h @@ -15,6 +15,9 @@ #include #include +/* We can rely on running natively, and this saves code size */ +#undef CONFIG_BIOSEMU + #undef CONFIG_STD_DEVICES_SETTINGS #define CONFIG_STD_DEVICES_SETTINGS "stdin=usbkbd,i8042-kbd,serial\0" \ "stdout=vidconsole,serial\0" \ -- cgit v1.2.3