windows-driver-samples.git/Build-Samples.ps1, branch GerritsMSFTSimpleMediaPlayerCompilerUpdate

refactor: consolidate VS detection into Resolve-BuildEnvironment

2026-04-02T22:36:34Z

- Remove Initialize-DevShell as a separate step; VS Dev Shell setup is now fully owned by Resolve-BuildEnvironment alongside mode detection. This eliminates the ordering problem where vswhere ran unconditionally before knowing whether the environment was EWDK (which needs no VS). - Fix EWDK regression: EWDK mode now returns early before any vswhere or Dev Shell logic is invoked. - Fix Auto+WDK from plain terminal: the old isWdk guard required UCRTVersion to be set before the Dev Shell was opened, making Auto detection fail on a clean terminal. Removed the guard; the code now falls through to Dev Shell setup and validates UCRTVersion afterward. - Fix VSINSTALLDIR trailing-backslash mismatch: when the Dev Shell is already active, VSINSTALLDIR ends with '\' while vswhere installationPath does not. Added TrimEnd('\') on both sides before comparing. - Renumber Build-Samples.ps1 step comments (old Step 5 'Detect Build Environment' merged into Step 1; remaining steps renumbered). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

refactor: remove Github RunMode

2026-03-31T23:22:25Z

NuGet mode works correctly for GitHub Actions (the HTML open is already guarded by [Environment]::UserInteractive which is false on CI runners). The Github mode was redundant and is removed to keep the interface clean. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

fix: detect WDK component version from the selected VS installation

2026-03-31T23:22:25Z

Previously, WdkVsComponentVersion was read from the global ProgramData package cache, which is shared across all VS installations and could return the wrong version when multiple installs are present. - Add -include packages to the vswhere call in Get-VsInstallationsWithWdk so each returned installation includes its WdkVsComponentVersion - Initialize-DevShell now returns the selected installation object - Resolve-BuildEnvironment accepts an optional -VsInstallation parameter; when provided it reuses the already-selected install (no second prompt); when absent (Dev Shell was pre-active) it calls Select-VsInstallation once - Build-Samples.ps1 threads the result of Initialize-DevShell through to Resolve-BuildEnvironment Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Extract environment helper functions into BuildEnvironment.ps1

2026-03-31T23:22:25Z

Move Get-VsInstallationsWithWdk, Select-VsInstallation, Initialize-DevShell, Assert-MsBuildAvailable, and Resolve-BuildEnvironment out of Build-Samples.ps1 into a new BuildEnvironment.ps1 helper file. Build-Samples.ps1 dot-sources it via PSScriptRoot, consistent with the existing ListAllSamples.ps1 pattern. Reduces Build-Samples.ps1 from 733 to 565 lines with no behaviour change. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Add -RunMode flag, VS detection via vswhere, and multi-install selection

2026-03-31T23:22:25Z

- Add -RunMode parameter (Auto/WDK/NuGet/EWDK/Github) defaulting to Auto - Auto-detection priority order: NuGet -> EWDK -> WDK - Github mode: same as NuGet but suppresses opening the HTML report - Add Get-VsInstallationsWithWdk: uses vswhere.exe from its fixed ProgramFiles path to find VS installs with the Microsoft.Windows.DriverKit component - Add Select-VsInstallation: errors if none found, verbose-logs if one found, presents a numbered interactive menu if multiple found - Replace Initialize-DevShell glob-based blind pick with the new helpers - Remove GITHUB_REPOSITORY auto-detect branch; replace HTML open guard with buildEnv.IsGithubMode - Update comment-based help with -RunMode parameter docs and examples Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Support wildcard patterns in -Samples parameter

2026-03-30T22:43:16Z

- When -Samples contains wildcards (* or ?), discover all samples first then filter with -like (same pattern style as exclusions.csv) - Exact sample names still work as before without discovery overhead - Update parameter docs, examples, and Building-Locally.md

Merge Build-Sample.ps1 into Build-Samples.ps1 as internal function

2026-03-30T22:32:35Z

- Inline Build-Sample.ps1 logic as Build-SingleSample function in Build-Samples.ps1 - Pass function definition into parallel runspaces via $using: pattern - Replace exit codes with return values for in-process execution - Delete Build-Sample.ps1 (no longer needed as a separate script) - Update Build-ChangedSamples.ps1 trigger file list

Remove Samples.txt: discover samples dynamically via ListAllSamples

2026-03-27T23:04:47Z

- ListAllSamples.ps1: output sorted sample names to stdout instead of writing Samples.txt. The file output is replaced with Write-Output so callers can capture results via pipeline or command substitution. - Build-Samples.ps1: remove SampleListPath parameter. Default discovery now calls ListAllSamples.ps1 at runtime and consumes its stdout. Explicit -Samples array still works and is sorted alphabetically. Both paths guarantee a consistent alphabetical sample ordering. - Samples.txt: deleted. No longer needed as a pre-generated artifact. WDS_TestPass.cs is unaffected - it only passes -LogFilesDirectory and -InfOptions, neither of which changed. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Refactor Build-Samples.ps1 and fix ListAllSamples NuGet filter

2026-03-20T22:09:27Z

Build-Samples.ps1: - Extract helper functions for readability (Resolve-BuildEnvironment, Import-SampleExclusions, Initialize-DevShell, Assert-MsBuildAvailable, Get-DiskFreeGB) - Add #Requires -Version 7.0 - Fix build_number to explicit [int] cast (was string from regex) - Fix multi-socket CPU handling (sum LogicalProcessors) - Fix NuGet path detection to use absolute repo root path - Support wildcard patterns in exclusion paths (-like vs ContainsKey) - Guard Invoke-Item for CI/automation (skip in non-interactive sessions) - Validate sample directories exist before building - Wrap Get-Volume in try/catch for UNC/network drives - Use Write-Host with carriage return for progress (Write-Progress unreliable in -Parallel runspaces) - Clean up variable names and add section comments - Use switch instead of if/elseif for exit codes ListAllSamples.ps1: - Fix NuGet packages filter regex to catch packages anywhere in path (was only matching paths starting with packages) Samples.txt: - Regenerated with fixed filter, remove BOM Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Add Build-Samples.ps1, ListAllSamples.ps1, fix Build-Sample retry bug

2026-03-19T22:36:29Z

- ListAllSamples.ps1: Enumerates .sln files and writes Samples.txt - Build-Samples.ps1: Unified build script reading Samples.txt with exclusion support, parallel execution, and report generation - Build-Sample.ps1: Fix retry bug where all-fail exits 0 instead of 1 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>