windows-driver-samples.git/network/ndis, branch developUnnamed repository; edit this file 'description' to name the repository.http://cgit.235523.xyz/windows-driver-samples.git/atom/network/ndis?h=develop2026-05-26T22:02:07ZFixed indentation2026-05-26T22:02:07ZAndre Muezerieandremue@linux.microsoft.com2026-05-26T22:02:07Zurn:sha1:e7f58ba58c629c8e7e2af3ef459cd6cbcfc5dabdFixed more typos2026-05-26T20:19:55ZAndre Muezerieandremue@linux.microsoft.com2026-05-26T20:19:55Zurn:sha1:75562144a0f28ad5381479e0b98d0005f0eaf264Fixed file name in top comment2026-05-26T20:12:55ZAndre Muezerieandremue@linux.microsoft.com2026-05-26T20:12:55Zurn:sha1:5abeda97a44b0857bc3b75e7b0f10705fcff4176Fixed copyright comment2026-05-26T20:03:01ZAndre Muezerieandremue@linux.microsoft.com2026-05-26T20:03:01Zurn:sha1:25b9db24aaea97833d3bb22ed9189172d90f34e9Fixed comments2026-05-26T19:58:18ZAndre Muezerieandremue@linux.microsoft.com2026-05-26T19:58:18Zurn:sha1:e1dcf60ade945ae9b27ae4d6af989c7608aec51cFixed typos2026-05-26T19:49:22ZAndre Muezerieandremue@linux.microsoft.com2026-05-26T19:49:22Zurn:sha1:ed0471c3f7dde410e5a2445c9b374bd401146b6dndis: Removed trailing spaces2026-05-22T01:11:19ZAndre Muezerieandremue@linux.microsoft.com2026-05-22T01:11:19Zurn:sha1:e70dbdfb56391f23306bf8a03fbf8ef89a1ebb92
This PR performs a whitespace-only cleanup by removing trailing spaces/tabs from source files under network\ndis. This is to reduce noise when making changes using AI so that future reviews are easier to be done by humans.
No functional logic changes were introduced.
What Changed
1. Removed end-of-line trailing whitespace in text files.
2. Kept file encoding and line endings intact by applying byte-preserving edits.
Risk / Impact
1. Low risk: formatting-only change.
2. No API, behavior, or build configuration changes intended.
Merge pull request #1386 from andremueiot/user/andremueiot/multiplication_converted_to_larger_type2026-05-21T19:50:22Z5an7y-Microsoftjvalesmena@microsoft.com2026-05-21T19:50:22Zurn:sha1:c7ad9e81acd5d28f339c7f007d6bc9d7ff24f7aa
NDIS: Harden QoS bytes calculation in netvmini control pathndis: Harden QoS bytes calculation in netvmini control path2026-05-20T17:53:41ZAndre Muezerieandremue@linux.microsoft.com2026-05-20T17:53:41Zurn:sha1:c4289d33165d82afc4779f3d148a49e57f96b454
- Replaced direct size arithmetic in NICSetQOSParameters with checked integer-safe operations.
- Added overflow handling for classification table size computation:
- Multiply NumClassificationElements × ClassificationElementSize via RtlULongMult.
- Add the revision header size via RtlULongAdd.
- Return NDIS_STATUS_INVALID_LENGTH when either checked operation fails, instead of relying on unchecked arithmetic.
netvmini/rssv2: fix mixed-width comparison in processor lookup loop2026-05-14T20:53:59ZAndre Muezerieandremue@linux.microsoft.com2026-05-14T20:53:59Zurn:sha1:566fe957730ddd523930ae1a82ec7bdee48e87af
Summary
This PR addresses a static-analysis warning in rssv2.c related to comparing values of different integer widths in a loop condition.
Changes
- Updated the loop index type in NICSetRSSv2FindProcessorInRssSet from UINT8 to ULONG to match RssProcessorCount width.
- Added an explicit cast when returning the found index: return (UINT8)index; to preserve the function’s return type and behavior.
Why
Using matching integer widths in loop comparisons avoids analyzer warnings and reduces risk of subtle boundary issues.
Impact
No functional behavior change is intended; this is a type-safety and code-quality fix for warning cleanup.