diff options
| author | Fredrik Orderud <[email protected]> | 2023-12-11 12:17:19 +0100 |
|---|---|---|
| committer | Fredrik Orderud <[email protected]> | 2024-05-03 12:31:01 +0200 |
| commit | 54466dac1149ba84e0ebff353eca8922cbdc5908 (patch) | |
| tree | 3640039509b3951b41a16e8d236e37afe915f557 | |
| parent | 1b58b0d98ec1cf22c800853b9c50a3a0449a6b6f (diff) | |
simbatt: Fix broken registry read-back
The GetSimBattStateFromRegistry function is currently using default settings if GetSimBattStateFromRegistry succeeds, whereas settings from registry are only applied if GetSimBattStateFromRegistry fails. This does not make sense to me.
Therefore proposing to remove the `!` negation from `if (!NT_SUCCESS(Status)) {` on the line after `Status = GetSimBattStateFromRegistry(Device, RegState);` so that default settings are loaded when registry read-back fails.
| -rw-r--r-- | simbatt/func/miniclass.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/simbatt/func/miniclass.c b/simbatt/func/miniclass.c index ba2df340..612b4c66 100644 --- a/simbatt/func/miniclass.c +++ b/simbatt/func/miniclass.c @@ -202,7 +202,7 @@ Return Value: } Status = GetSimBattStateFromRegistry(Device, RegState); - if (!NT_SUCCESS(Status)) { + if (NT_SUCCESS(Status)) { RtlZeroMemory(RegState, sizeof(SIMBATT_STATE)); WdfWaitLockAcquire(DevExt->StateLock, NULL); |