Merge branch 'main' into main

11 files changed, 54 insertions, 32 deletions

diff --git a/.github/workflows/Code-Scanning.yml b/.github/workflows/Code-Scanning.yml
index 1364bfbd..63e155c9 100644
--- a/.github/workflows/Code-Scanning.yml
+++ b/.github/workflows/Code-Scanning.yml
@@ -48,7 +48,7 @@ jobs:
         run: nuget restore .\packages.config -PackagesDirectory .\packages\
       - name: Get changed files
         id: get-changed-files
-        uses: tj-actions/changed-files@v46
+        uses: tj-actions/changed-files@v41
         with:
           separator: ","
       - name: Initialize CodeQL
diff --git a/Directory.Build.props b/Directory.Build.props
index dfdef8b5..287a2500 100644
--- a/Directory.Build.props
+++ b/Directory.Build.props
@@ -1,7 +1,7 @@
 <Project>
-<Import Project="packages\Microsoft.Windows.WDK.x64.10.0.26100.3323\build\native\Microsoft.Windows.WDK.x64.props" Condition="Exists('packages\Microsoft.Windows.WDK.x64.10.0.26100.3323\build\native\Microsoft.Windows.WDK.x64.props') and '$(Platform)' == 'x64'"/>
-<Import Project="packages\Microsoft.Windows.WDK.arm64.10.0.26100.3323\build\native\Microsoft.Windows.WDK.arm64.props" Condition="Exists('packages\Microsoft.Windows.WDK.arm64.10.0.26100.3323\build\native\Microsoft.Windows.WDK.arm64.props') and '$(Platform)' == 'ARM64'"/>
-<Import Project="packages\Microsoft.Windows.SDK.CPP.x64.10.0.26100.3323\build\native\Microsoft.Windows.SDK.cpp.x64.props" Condition="Exists('packages\Microsoft.Windows.SDK.CPP.x64.10.0.26100.3323\build\native\Microsoft.Windows.SDK.cpp.x64.props') and '$(Platform)' == 'x64'"/>
-<Import Project="packages\Microsoft.Windows.SDK.CPP.arm64.10.0.26100.3323\build\native\Microsoft.Windows.SDK.cpp.arm64.props" Condition="Exists('packages\Microsoft.Windows.SDK.CPP.arm64.10.0.26100.3323\build\native\Microsoft.Windows.SDK.cpp.arm64.props') and '$(Platform)' == 'ARM64'"/>
-<Import Project="packages\Microsoft.Windows.SDK.CPP.10.0.26100.3323\build\native\Microsoft.Windows.SDK.cpp.props" Condition="Exists('packages\Microsoft.Windows.SDK.CPP.10.0.26100.3323\build\native\Microsoft.Windows.SDK.cpp.props')"/>
+<Import Project="packages\Microsoft.Windows.WDK.x64.10.0.26100.4204\build\native\Microsoft.Windows.WDK.x64.props" Condition="Exists('packages\Microsoft.Windows.WDK.x64.10.0.26100.4204\build\native\Microsoft.Windows.WDK.x64.props') and '$(Platform)' == 'x64'"/>
+<Import Project="packages\Microsoft.Windows.WDK.arm64.10.0.26100.4204\build\native\Microsoft.Windows.WDK.arm64.props" Condition="Exists('packages\Microsoft.Windows.WDK.arm64.10.0.26100.4204\build\native\Microsoft.Windows.WDK.arm64.props') and '$(Platform)' == 'ARM64'"/>
+<Import Project="packages\Microsoft.Windows.SDK.CPP.x64.10.0.26100.4204\build\native\Microsoft.Windows.SDK.cpp.x64.props" Condition="Exists('packages\Microsoft.Windows.SDK.CPP.x64.10.0.26100.4204\build\native\Microsoft.Windows.SDK.cpp.x64.props') and '$(Platform)' == 'x64'"/>
+<Import Project="packages\Microsoft.Windows.SDK.CPP.arm64.10.0.26100.4204\build\native\Microsoft.Windows.SDK.cpp.arm64.props" Condition="Exists('packages\Microsoft.Windows.SDK.CPP.arm64.10.0.26100.4204\build\native\Microsoft.Windows.SDK.cpp.arm64.props') and '$(Platform)' == 'ARM64'"/>
+<Import Project="packages\Microsoft.Windows.SDK.CPP.10.0.26100.4204\build\native\Microsoft.Windows.SDK.cpp.props" Condition="Exists('packages\Microsoft.Windows.SDK.CPP.10.0.26100.4204\build\native\Microsoft.Windows.SDK.cpp.props')"/>
 </Project>
diff --git a/exclusions.csv b/exclusions.csv
index 5352e0d1..63d5e24a 100644
--- a/exclusions.csv
+++ b/exclusions.csv
@@ -6,3 +6,8 @@ network\trans\WFPSampler,Debug|ARM64,,22621,Only NI: Only ARM: Fails to build on
 prm,*,,22621,Only NI: Not supported on NI.
 powerlimit\plclient,*,,22621,Only NI: Not supported on NI.
 powerlimit\plpolicy,*,,22621,Only NI: Not supported on NI.
+general\pcidrv,*,,26100,"failure introduced in VS17.14, suppressed until fix"
+serial\serial,*,,26100,"failure introduced in VS17.14, suppressed until fix"
+network\wlan\wdi,*,,26100,"failure introduced in VS17.14, suppressed until fix"
+tools\kasan\samples\kasandemo-wdm,*|x64,,26100,"failure introduced in VS17.14, suppressed until fix"
+
diff --git a/filesys/miniFilter/avscan/filter/avscan.c b/filesys/miniFilter/avscan/filter/avscan.c
index 3c96fd08..c07cb181 100644
--- a/filesys/miniFilter/avscan/filter/avscan.c
+++ b/filesys/miniFilter/avscan/filter/avscan.c
@@ -2277,7 +2277,7 @@ Return Value:
 
         if ( transactionContext ) {  // case 3
 
-            FltReferenceContext( transactionContext );
+            FltReferenceContext( StreamContext );
 
             AvAcquireResourceExclusive( transactionContext->Resource );
 
diff --git a/packages.config b/packages.config
index fa8c2142..5f93b2bf 100644
--- a/packages.config
+++ b/packages.config
@@ -1,8 +1,8 @@
 <?xml version="1.0" encoding="utf-8"?>
 <packages>
-  <package id="Microsoft.Windows.SDK.CPP" version="10.0.26100.3323" targetFramework="native" />
-  <package id="Microsoft.Windows.SDK.CPP.x64" version="10.0.26100.3323" targetFramework="native" />
-  <package id="Microsoft.Windows.SDK.CPP.arm64" version="10.0.26100.3323" targetFramework="native" />
-  <package id="Microsoft.Windows.WDK.x64" version="10.0.26100.3323" targetFramework="native" />
-  <package id="Microsoft.Windows.WDK.arm64" version="10.0.26100.3323" targetFramework="native" />
+  <package id="Microsoft.Windows.SDK.CPP" version="10.0.26100.4204" targetFramework="native" />
+  <package id="Microsoft.Windows.SDK.CPP.x64" version="10.0.26100.4204" targetFramework="native" />
+  <package id="Microsoft.Windows.SDK.CPP.arm64" version="10.0.26100.4204" targetFramework="native" />
+  <package id="Microsoft.Windows.WDK.x64" version="10.0.26100.4204" targetFramework="native" />
+  <package id="Microsoft.Windows.WDK.arm64" version="10.0.26100.4204" targetFramework="native" />
 </packages>
diff --git a/spb/SpbTestTool/exe/command.h b/spb/SpbTestTool/exe/command.h
index 5e2633bd..d3f887b0 100644
--- a/spb/SpbTestTool/exe/command.h
+++ b/spb/SpbTestTool/exe/command.h
@@ -183,6 +183,8 @@ public:
         _In_opt_              string        Tag
         ) : CCommand("open", Parameters)
     {
+        UNREFERENCED_PARAMETER(Tag);
+
         return;
     }
 
@@ -208,6 +210,8 @@ public:
         _In_opt_              string        Tag
         ) : CCommand("close", Parameters)
     {
+        UNREFERENCED_PARAMETER(Tag);
+
         return;
     }
 
@@ -233,6 +237,8 @@ public:
         _In_opt_              string        Tag
         ) : CCommand("lock", Parameters)
     {
+        UNREFERENCED_PARAMETER(Tag);
+
         return;
     }
 
@@ -258,6 +264,8 @@ public:
         _In_opt_              string        Tag
         ) : CCommand("unlock", Parameters)
     {
+        UNREFERENCED_PARAMETER(Tag);
+
         return;
     }
 
@@ -283,6 +291,8 @@ public:
         _In_opt_              string        Tag
         ) : CCommand("lockconn", Parameters)
     {
+        UNREFERENCED_PARAMETER(Tag);
+
         return;
     }
 
@@ -308,6 +318,8 @@ public:
         _In_opt_              string        Tag
         ) : CCommand("unlockconn", Parameters)
     {
+        UNREFERENCED_PARAMETER(Tag);
+
         return;
     }
 
@@ -335,6 +347,8 @@ public:
         _In_opt_              string        Tag
         ) : CCommand("read", Parameters)
     {
+        UNREFERENCED_PARAMETER(Tag);
+
         return;
     }
 
@@ -392,6 +406,8 @@ public:
         _In_opt_              string        Tag
         ) : CCommand("write", Parameters)
     {
+        UNREFERENCED_PARAMETER(Tag);
+
         return;
     }
 
@@ -446,6 +462,8 @@ public:
         _In_opt_              string        Tag
         ) : CCommand("writeread", Parameters)
     {
+        UNREFERENCED_PARAMETER(Tag);
+
         WriteBuffer = NULL;
         return;
     }
@@ -524,6 +542,8 @@ public:
         _In_opt_              string        Tag
         ) : CCommand("fullduplex", Parameters)
     {
+        UNREFERENCED_PARAMETER(Tag);
+
         WriteBuffer = NULL;
         return;
     }
@@ -597,6 +617,8 @@ public:
         _In_opt_              string        Tag
         ) : CCommand("signal", Parameters)
     {
+        UNREFERENCED_PARAMETER(Tag);
+
         return;
     }
 
@@ -622,6 +644,8 @@ public:
         _In_opt_              string        Tag
         ) : CCommand("waitoninterrupt", Parameters)
     {
+        UNREFERENCED_PARAMETER(Tag);
+
         return;
     }
 
diff --git a/storage/class/classpnp/src/class.c b/storage/class/classpnp/src/class.c
index 58d1835a..6da2b146 100644
--- a/storage/class/classpnp/src/class.c
+++ b/storage/class/classpnp/src/class.c
@@ -3740,7 +3740,7 @@ ClassIoComplete(
     PSCSI_REQUEST_BLOCK srb = Context;
     PFUNCTIONAL_DEVICE_EXTENSION fdoExtension = Fdo->DeviceExtension;
     PCLASS_PRIVATE_FDO_DATA fdoData = fdoExtension->PrivateFdoData;
-    NTSTATUS status;
+    NTSTATUS status = STATUS_SUCCESS;
     BOOLEAN retry;
     BOOLEAN callStartNextPacket;
     ULONG srbFlags;
@@ -6055,7 +6055,7 @@ __ClassInterpretSenseInfo_ProcessingInvalidSenseBuffer:
                         logErrorInternal = FALSE;
                         logError = FALSE;
                     } else if (cdbOpcode == SCSIOP_MODE_SENSE10) {
-                        USHORT allocationLength;
+                        USHORT allocationLength = 0;
                         REVERSE_BYTES_SHORT(&(cdb->MODE_SENSE10.AllocationLength), &allocationLength);
                         if (SrbGetDataTransferLength(Srb) <= allocationLength) {
                             *Status = STATUS_SUCCESS;
@@ -6063,7 +6063,7 @@ __ClassInterpretSenseInfo_ProcessingInvalidSenseBuffer:
                             logError = FALSE;
                         }
                     } else if (ClasspIsReceiveTokenInformation(cdb)) {
-                        ULONG allocationLength;
+                        ULONG allocationLength = 0;
                         REVERSE_BYTES(&(cdb->RECEIVE_TOKEN_INFORMATION.AllocationLength), &allocationLength);
                         if (SrbGetDataTransferLength(Srb) <= allocationLength) {
                             *Status = STATUS_SUCCESS;
diff --git a/storage/class/classpnp/src/obsolete.c b/storage/class/classpnp/src/obsolete.c
index aeeef81d..e0fe3d13 100644
--- a/storage/class/classpnp/src/obsolete.c
+++ b/storage/class/classpnp/src/obsolete.c
@@ -119,7 +119,7 @@ ClassIoCompleteAssociated(
     PIRP originalIrp = Irp->AssociatedIrp.MasterIrp;
     LONG irpCount;
 
-    NTSTATUS status;
+    NTSTATUS status = STATUS_SUCCESS;
     BOOLEAN retry;
 
     TracePrint((TRACE_LEVEL_WARNING, TRACE_FLAG_GENERAL, "ClassIoCompleteAssociated is OBSOLETE !"));
@@ -390,8 +390,8 @@ RetryRequest(
         //
 
         NT_ASSERT(SrbGetDataBuffer(srbHeader) == MmGetMdlVirtualAddress(Irp->MdlAddress));
-    _Analysis_assume_(Irp->MdlAddress->ByteCount <= dataTransferLength);
-        transferByteCount = Irp->MdlAddress->ByteCount;
+    _Analysis_assume_(MmGetMdlByteCount(Irp->MdlAddress) <= dataTransferLength);
+        transferByteCount = MmGetMdlByteCount(Irp->MdlAddress);
 
     } else {
 
diff --git a/storage/class/disk/src/disk.c b/storage/class/disk/src/disk.c
index c8dbeb59..ce3395f7 100644
--- a/storage/class/disk/src/disk.c
+++ b/storage/class/disk/src/disk.c
@@ -707,7 +707,7 @@ Return Value:
         mediaTypes->MediaInfoCount = 1;
 
         mediaInfo->DeviceSpecific.DiskInfo.Cylinders.QuadPart   = fdoExtension->DiskGeometry.Cylinders.QuadPart;
-        mediaInfo->DeviceSpecific.DiskInfo.MediaType            = FixedMedia;
+        mediaInfo->DeviceSpecific.DiskInfo.MediaType            = (STORAGE_MEDIA_TYPE)FixedMedia;
         mediaInfo->DeviceSpecific.DiskInfo.TracksPerCylinder    = fdoExtension->DiskGeometry.TracksPerCylinder;
         mediaInfo->DeviceSpecific.DiskInfo.SectorsPerTrack      = fdoExtension->DiskGeometry.SectorsPerTrack;
         mediaInfo->DeviceSpecific.DiskInfo.BytesPerSector       = fdoExtension->DiskGeometry.BytesPerSector;
@@ -899,7 +899,7 @@ SkipTable:
             mediaTypes->MediaInfoCount = 1;
 
             mediaInfo->DeviceSpecific.RemovableDiskInfo.Cylinders.QuadPart   = fdoExtension->DiskGeometry.Cylinders.QuadPart;
-            mediaInfo->DeviceSpecific.RemovableDiskInfo.MediaType            = RemovableMedia;
+            mediaInfo->DeviceSpecific.RemovableDiskInfo.MediaType            = (STORAGE_MEDIA_TYPE)RemovableMedia;
             mediaInfo->DeviceSpecific.RemovableDiskInfo.TracksPerCylinder    = fdoExtension->DiskGeometry.TracksPerCylinder;
             mediaInfo->DeviceSpecific.RemovableDiskInfo.SectorsPerTrack      = fdoExtension->DiskGeometry.SectorsPerTrack;
             mediaInfo->DeviceSpecific.RemovableDiskInfo.BytesPerSector       = fdoExtension->DiskGeometry.BytesPerSector;
diff --git a/storage/class/disk/src/diskwmi.c b/storage/class/disk/src/diskwmi.c
index 7503e5a1..de2d7eee 100644
--- a/storage/class/disk/src/diskwmi.c
+++ b/storage/class/disk/src/diskwmi.c
@@ -1739,7 +1739,7 @@ DiskInfoExceptionComplete(
                 //
                 // Reset byte count of transfer in SRB Extension.
                 //
-                srbEx->DataTransferLength = Irp->MdlAddress->ByteCount;
+                srbEx->DataTransferLength = MmGetMdlByteCount(Irp->MdlAddress);
 
                 //
                 // Zero SRB statuses.
@@ -1768,7 +1768,7 @@ DiskInfoExceptionComplete(
                 //
                 // Reset byte count of transfer in SRB Extension.
                 //
-                srb->DataTransferLength = Irp->MdlAddress->ByteCount;
+                srb->DataTransferLength = MmGetMdlByteCount(Irp->MdlAddress);
 
                 //
                 // Zero SRB statuses.
diff --git a/storage/miniports/lsi_u3/src/lsi_u3.inf b/storage/miniports/lsi_u3/src/lsi_u3.inf
index 5a879f51..52a4d4df 100644
--- a/storage/miniports/lsi_u3/src/lsi_u3.inf
+++ b/storage/miniports/lsi_u3/src/lsi_u3.inf
@@ -36,18 +36,11 @@ lsi_u3.sys = 1
 [DestinationDirs]
 DefaultDestDir = 12 ; DIRID_DRIVERS
 
+; Use NT$ARCH$ for platform-specific stamping via Stampinf
 [Manufacturer]
-%LSI%=LSI,NTamd64,NTia64,NTarm64
+%LSI%=LSI,NT$ARCH$
 
-[LSI.NTamd64]
-%DevDesc1% = LSI_U3_Inst, PCI\VEN_1000&DEV_0020
-%DevDesc2% = LSI_U3_Inst, PCI\VEN_1000&DEV_0021
-
-[LSI.NTia64]
-%DevDesc1% = LSI_U3_Inst, PCI\VEN_1000&DEV_0020
-%DevDesc2% = LSI_U3_Inst, PCI\VEN_1000&DEV_0021
-
-[LSI.NTarm64]
+[LSI.NT$ARCH$]
 %DevDesc1% = LSI_U3_Inst, PCI\VEN_1000&DEV_0020
 %DevDesc2% = LSI_U3_Inst, PCI\VEN_1000&DEV_0021