Bug fix: Non paged functions in MinWaveRT should not be inline (#313)

* Format Changes
==============
* Add KSEVENT_PINCAPS_FORMATCHANGE to Bluetooth HFP Endpoints
* Remove 8 bit formats from Bluetooth HFP Endpoints

Name Template
==============
* Bluetooth Endpoints are now based on templates in INF and then customized with endpoints specific data

Sideband Common Interface for future Sideband buses
===================================================
* Add ISidebandDevice

* Add current directory to TabletAudioSample include path. Remove unused compiler flags.

* RS4 bug fixes

* Replace FastMutex with Spinlock for DeviceFormatsAndModes to work well at DISPATCH_LEVEL

* Resync with Microsoft-master branch

* Replace FastMutex with Spinlock for DeviceFormatsAndModes to work well at DISPATCH_LEVEL

* RS5 updates:
 - USB Sideband implementation
 - Power management options: _USE_IPortClsRuntimePower, _USE_SingleComponentMultiFxStates

* Bug fix: Non paged code in Wave Filter should not be defined Inline.

1 files changed, 237 insertions, 0 deletions

diff --git a/audio/sysvad/EndpointsCommon/minwavert.cpp b/audio/sysvad/EndpointsCommon/minwavert.cpp
index f4a0599c..1ad029f7 100644
--- a/audio/sysvad/EndpointsCommon/minwavert.cpp
+++ b/audio/sysvad/EndpointsCommon/minwavert.cpp
@@ -977,6 +977,243 @@ CMiniportWaveRT::ValidateStreamCreate
 }
 
 //=============================================================================
+#pragma code_seg()
+_Use_decl_annotations_
+VOID CMiniportWaveRT::AcquireFormatsAndModesLock()
+{
+    KeAcquireSpinLock(&m_DeviceFormatsAndModesLock, &m_DeviceFormatsAndModesIrql);
+}
+
+#pragma code_seg()
+_Use_decl_annotations_
+VOID CMiniportWaveRT::ReleaseFormatsAndModesLock()
+{
+    KeReleaseSpinLock(&m_DeviceFormatsAndModesLock, m_DeviceFormatsAndModesIrql);
+}
+
+//---------------------------------------------------------------------------
+// GetPinSupportedDeviceFormats 
+//
+//  Return supported formats for a given pin.
+//
+//  Return value
+//      The number of KSDATAFORMAT_WAVEFORMATEXTENSIBLE items.
+//
+//  Remarks
+//      Supported formats index array follows same order as filter's pin
+//      descriptor list.
+//
+#pragma code_seg()
+_Use_decl_annotations_
+ULONG CMiniportWaveRT::GetPinSupportedDeviceFormats(_In_ ULONG PinId, _Outptr_opt_result_buffer_(return) KSDATAFORMAT_WAVEFORMATEXTENSIBLE **ppFormats)
+{
+    PPIN_DEVICE_FORMATS_AND_MODES pDeviceFormatsAndModes = NULL;
+
+    AcquireFormatsAndModesLock();
+
+    pDeviceFormatsAndModes = m_DeviceFormatsAndModes;
+    ASSERT(m_DeviceFormatsAndModesCount > PinId);
+    ASSERT(pDeviceFormatsAndModes[PinId].WaveFormats != NULL);
+    ASSERT(pDeviceFormatsAndModes[PinId].WaveFormatsCount > 0);
+
+    if (ppFormats != NULL)
+    {
+        *ppFormats = pDeviceFormatsAndModes[PinId].WaveFormats;
+    }
+
+    ReleaseFormatsAndModesLock();
+
+    return pDeviceFormatsAndModes[PinId].WaveFormatsCount;
+}
+
+//---------------------------------------------------------------------------
+// GetAudioEngineSupportedDeviceFormats 
+//
+//  Return supported device formats for the audio engine node.
+//
+//  Return value
+//      The number of KSDATAFORMAT_WAVEFORMATEXTENSIBLE items.
+//
+//  Remarks
+//      Supported formats index array follows same order as filter's pin
+//      descriptor list. This routine assumes the engine formats are the
+//      last item in the filter's array of PIN_DEVICE_FORMATS_AND_MODES.
+//
+#pragma code_seg()
+_Use_decl_annotations_
+ULONG CMiniportWaveRT::GetAudioEngineSupportedDeviceFormats(_Outptr_opt_result_buffer_(return) KSDATAFORMAT_WAVEFORMATEXTENSIBLE **ppFormats)
+{
+    ULONG i;
+    PPIN_DEVICE_FORMATS_AND_MODES pDeviceFormatsAndModes = NULL;
+
+    AcquireFormatsAndModesLock();
+
+    pDeviceFormatsAndModes = m_DeviceFormatsAndModes;
+
+    // By convention, the audio engine node's device formats are the last
+    // entry in the PIN_DEVICE_FORMATS_AND_MODES list.
+
+    // Since this endpoint apparently supports offload, there must be at least a system,
+    // offload, and loopback pin, plus the entry for the device formats.
+    ASSERT(m_DeviceFormatsAndModesCount > 3);
+
+    i = m_DeviceFormatsAndModesCount - 1;                       // Index of last list entry
+
+    ASSERT(pDeviceFormatsAndModes[i].PinType == NoPin);
+    ASSERT(pDeviceFormatsAndModes[i].WaveFormats != NULL);
+    ASSERT(pDeviceFormatsAndModes[i].WaveFormatsCount > 0);
+
+    if (ppFormats != NULL)
+    {
+        *ppFormats = pDeviceFormatsAndModes[i].WaveFormats;
+    }
+
+    ReleaseFormatsAndModesLock();
+    return pDeviceFormatsAndModes[i].WaveFormatsCount;
+}
+
+//---------------------------------------------------------------------------
+// GetPinSupportedDeviceModes 
+//
+//  Return mode information for a given pin.
+//
+//  Return value
+//      The number of MODE_AND_DEFAULT_FORMAT items or 0 if none.
+//
+//  Remarks
+//      Supported formats index array follows same order as filter's pin
+//      descriptor list.
+//
+#pragma code_seg()
+_Use_decl_annotations_
+ULONG CMiniportWaveRT::GetPinSupportedDeviceModes(_In_ ULONG PinId, _Outptr_opt_result_buffer_(return) _On_failure_(_Deref_post_null_) MODE_AND_DEFAULT_FORMAT **ppModes)
+{
+    PMODE_AND_DEFAULT_FORMAT modes;
+    ULONG numModes;
+
+    AcquireFormatsAndModesLock();
+
+    ASSERT(m_DeviceFormatsAndModesCount > PinId);
+    ASSERT((m_DeviceFormatsAndModes[PinId].ModeAndDefaultFormatCount == 0) == (m_DeviceFormatsAndModes[PinId].ModeAndDefaultFormat == NULL));
+
+    modes = m_DeviceFormatsAndModes[PinId].ModeAndDefaultFormat;
+    numModes = m_DeviceFormatsAndModes[PinId].ModeAndDefaultFormatCount;
+
+#ifdef SYSVAD_BTH_BYPASS
+    // Special handling for the SCO bypass endpoint, whose modes are determined at runtime
+    if (m_DeviceType == eBthHfpMicDevice)
+    {
+        ASSERT(m_pSidebandDevice != NULL);
+        if (m_pSidebandDevice->IsNRECSupported())
+        {
+            modes = BthHfpMicPinSupportedDeviceModesNrec;
+            numModes = ARRAYSIZE(BthHfpMicPinSupportedDeviceModesNrec);
+        }
+        else
+        {
+            modes = BthHfpMicPinSupportedDeviceModesNoNrec;
+            numModes = ARRAYSIZE(BthHfpMicPinSupportedDeviceModesNoNrec);
+        }
+    }
+#endif // SYSVAD_BTH_BYPASS
+
+    if (ppModes != NULL)
+    {
+        if (numModes > 0)
+        {
+            *ppModes = modes;
+        }
+        else
+        {
+            // ensure that the returned pointer is NULL
+            // in the event of failure (SAL annotation above
+            // indicates that it must be NULL, and OACR sees a possibility
+            // that it might not be).
+            *ppModes = NULL;
+        }
+    }
+
+    ReleaseFormatsAndModesLock();
+    return numModes;
+}
+
+#pragma code_seg()
+BOOL CMiniportWaveRT::IsSystemCapturePin(ULONG nPinId)
+{
+    AcquireFormatsAndModesLock();
+
+    PINTYPE pinType = m_DeviceFormatsAndModes[nPinId].PinType;
+
+    ReleaseFormatsAndModesLock();
+    return (pinType == SystemCapturePin);
+}
+
+#pragma code_seg()
+BOOL CMiniportWaveRT::IsCellularBiDiCapturePin(ULONG nPinId)
+{
+    AcquireFormatsAndModesLock();
+
+    PINTYPE pinType = m_DeviceFormatsAndModes[nPinId].PinType;
+
+    ReleaseFormatsAndModesLock();
+    return (pinType == TelephonyBidiPin);
+}
+
+#pragma code_seg()
+BOOL CMiniportWaveRT::IsSystemRenderPin(ULONG nPinId)
+{
+    AcquireFormatsAndModesLock();
+
+    PINTYPE pinType = m_DeviceFormatsAndModes[nPinId].PinType;
+
+    ReleaseFormatsAndModesLock();
+    return (pinType == SystemRenderPin);
+}
+
+#pragma code_seg()
+BOOL CMiniportWaveRT::IsLoopbackPin(ULONG nPinId)
+{
+    AcquireFormatsAndModesLock();
+
+    PINTYPE pinType = m_DeviceFormatsAndModes[nPinId].PinType;
+
+    ReleaseFormatsAndModesLock();
+    return (pinType == RenderLoopbackPin);
+}
+
+#pragma code_seg()
+BOOL CMiniportWaveRT::IsOffloadPin(ULONG nPinId)
+{
+    AcquireFormatsAndModesLock();
+
+    PINTYPE pinType = m_DeviceFormatsAndModes[nPinId].PinType;
+
+    ReleaseFormatsAndModesLock();
+    return (pinType == OffloadRenderPin);
+}
+
+#pragma code_seg()
+BOOL CMiniportWaveRT::IsBridgePin(ULONG nPinId)
+{
+    AcquireFormatsAndModesLock();
+
+    PINTYPE pinType = m_DeviceFormatsAndModes[nPinId].PinType;
+
+    ReleaseFormatsAndModesLock();
+    return (pinType == BridgePin);
+}
+
+#pragma code_seg()
+BOOL CMiniportWaveRT::IsKeywordDetectorPin(ULONG nPinId)
+{
+    AcquireFormatsAndModesLock();
+
+    PINTYPE pinType = m_DeviceFormatsAndModes[nPinId].PinType;
+
+    ReleaseFormatsAndModesLock();
+    return (pinType == KeywordCapturePin);
+}
+
 #pragma code_seg("PAGE")
 NTSTATUS
 CMiniportWaveRT::StreamCreated