Fixes for sample build errors and updates to the execution script to use new build flags (#1078)

* Fixes for sample build errors

* Fix additional sample

* Add additional sample

* Updated comments in Build-Sample.ps1

* Adjusting exclusions.csv to be accurate for GE. Still issues for NI that we need to understand better

* Merge from develop branch

* Merge from develop branch

* Merge from develop branch

* Delete WPD samples

* Separate infverif additional options for old vs new WDK

* Delete WPD samples entry in our CODEOWNERS file

* Fix spelling error

* For 22621 WDK Remove the /samples flag

---------

Co-authored-by: Zac Lockard <[email protected]>
Co-authored-by: Jakob Lichtenberg (170957) <[email protected]>

1 files changed, 0 insertions, 552 deletions

diff --git a/wpd/WpdMultiTransportDriver/Device.cpp b/wpd/WpdMultiTransportDriver/Device.cpp
deleted file mode 100644
index 9e1af476..00000000
--- a/wpd/WpdMultiTransportDriver/Device.cpp
+++ /dev/null
@@ -1,552 +0,0 @@
-#include "stdafx.h"
-#include "Device.h"
-#include "WpdMultiTransportDriver_i.c"
-
-#include "Device.tmh"
-
-STDMETHODIMP_(HRESULT)
-CDevice::OnD0Entry(_In_ IWDFDevice* /*pDevice*/,
-                        WDF_POWER_DEVICE_STATE /*previousState*/)
-{
-    return S_OK;
-}
-
-STDMETHODIMP_(HRESULT)
-CDevice::OnD0Exit(_In_ IWDFDevice* /*pDevice*/,
-                       WDF_POWER_DEVICE_STATE /*newState*/)
-{
-    return S_OK;
-}
-
-STDMETHODIMP_(VOID)
-CDevice::OnSurpriseRemoval(_In_ IWDFDevice* /*pDevice*/)
-{
-    return;
-}
-
-STDMETHODIMP_(HRESULT)
-CDevice::OnQueryRemove(_In_ IWDFDevice* /*pDevice*/)
-{
-    return S_OK;
-}
-
-STDMETHODIMP_(HRESULT)
-CDevice::OnQueryStop(_In_ IWDFDevice* /*pDevice*/)
-{
-    return S_OK;
-}
-
-STDMETHODIMP_(VOID)
-CDevice::OnSelfManagedIoCleanup(_In_ IWDFDevice* /*pDevice*/)
-{
-    return;
-}
-
-STDMETHODIMP_(VOID)
-CDevice::OnSelfManagedIoFlush(_In_ IWDFDevice* /*pDevice*/)
-{
-    return;
-}
-
-STDMETHODIMP_(HRESULT)
-CDevice::OnSelfManagedIoInit(_In_ IWDFDevice* /*pDevice*/)
-{
-    return S_OK;
-}
-
-STDMETHODIMP_(HRESULT)
-CDevice::OnSelfManagedIoSuspend(_In_ IWDFDevice* /*pDevice*/)
-{
-    return S_OK;
-}
-
-STDMETHODIMP_(HRESULT)
-CDevice::OnSelfManagedIoRestart(_In_ IWDFDevice* /*pDevice*/)
-{
-    return S_OK;
-}
-
-STDMETHODIMP_(HRESULT)
-CDevice::OnSelfManagedIoStop(_In_ IWDFDevice* /*pDevice*/)
-{
-    return S_OK;
-}
-
-STDMETHODIMP_(HRESULT)
-CDevice::OnPrepareHardware(_In_ IWDFDevice* pDevice)
-{
-    HRESULT hr = S_OK;
-
-    if (m_pWpdBaseDriver != NULL)
-    {
-        hr = m_pWpdBaseDriver->Initialize();
-        CHECK_HR(hr, "Failed to Initialize the driver class");
-    }
-
-    // Initialize the WPD Class Extension. This will enable the appropriate WPD interface GUID,
-    // as well as do any additional initialization (e.g. enabling Legacy Compatibility layers for those drivers
-    // which requested support in their INF).
-    if (hr == S_OK && m_pPortableDeviceClassExtension == NULL)
-    {
-        CComPtr<IPortableDeviceValues>                pOptions;
-        CComPtr<IPortableDevicePropVariantCollection> pContentTypes;
-
-        hr = CoCreateInstance(CLSID_PortableDeviceClassExtension,
-                              NULL,
-                              CLSCTX_INPROC_SERVER,
-                              IID_IPortableDeviceClassExtension,
-                              (VOID**)&m_pPortableDeviceClassExtension);
-        CHECK_HR(hr, "Failed to CoCreate CLSID_PortableDeviceClassExtension");
-
-        if (hr == S_OK)
-        {
-            hr = CoCreateInstance(CLSID_PortableDeviceValues,
-                                  NULL,
-                                  CLSCTX_INPROC_SERVER,
-                                  IID_IPortableDeviceValues,
-                                  (VOID**)&pOptions);
-            CHECK_HR(hr, "Failed to CoCreate CLSID_PortableDeviceValues");
-
-            if (hr == S_OK)
-            {
-                CComPtr<IPortableDeviceValues>        pIDs;
-
-                // ATTENTION: The following GUID value is provided for illustrative
-                // purposes only.
-                //
-                // Rather than hard-coding a GUID value in your driver, the driver
-                // must obtain a GUID value from the device. The GUID value on the
-                // device can be provisioned by the driver (upon first-connect) by
-                // using CoCreateGUID and setting that value into non-volatile storage
-                // on the device. The same GUID value will then be reported by each
-                // of your device's transports. To avoid a provisioning race condition,
-                // always read the value from the device after provisioning. Only
-                // provision the GUID once. Thereafter, always use the value provided
-                // by the device.
-                GUID guidFUID = { 0x245e5e81, 0x2c17, 0x40a4, { 0x8b, 0x10, 0xe9, 0x43, 0xc5, 0x4c, 0x97, 0xb2 } };
-
-                // Initialize the PortableDeviceClassExtension with a list of supported content types for the
-                // connected device.  This will ensure that the correct application compatibility settings will
-                // be applied for your device.
-
-                // Get supported content types
-                if (hr == S_OK)
-                {
-                    hr = GetSupportedContentTypes(&pContentTypes);
-                    CHECK_HR(hr, "Failed to get supported content types");
-                }
-
-                // Add the supported types to the options
-                if (hr == S_OK)
-                {
-                    hr = pOptions->SetIPortableDevicePropVariantCollectionValue(WPD_CLASS_EXTENSION_OPTIONS_SUPPORTED_CONTENT_TYPES, pContentTypes);
-                    CHECK_HR(hr, "Failed to set WPD_CLASS_EXTENSION_OPTIONS_SUPPORTED_CONTENT_TYPES");
-                }
-
-                if (hr == S_OK)
-                {
-                    m_pWpdBaseDriver->m_pQueueCallback = NULL;
-
-                    HRESULT hrTemp = m_pPortableDeviceClassExtension->QueryInterface(
-                        __uuidof(IQueueCallbackDeviceIoControl),
-                        (void**)&m_pWpdBaseDriver->m_pQueueCallback
-                        );
-                    CHECK_HR(hrTemp, "Failed to obtain IQueueCallbackDeviceIoControl interface from class extension");
-
-                    if (hrTemp == S_OK)
-                    {
-                        // Enable the Multi-Transport Mode option
-                        hr = pOptions->SetBoolValue(WPD_CLASS_EXTENSION_OPTIONS_MULTITRANSPORT_MODE, TRUE);
-                        CHECK_HR(hr, "Failed to enable multi-transport mode");
-
-                        // Create a PnP ID value collection
-                        if (hr == S_OK)
-                        {
-                            hr = CreateIDValues(DEVICE_MANUFACTURER_VALUE,
-                                                DEVICE_MODEL_VALUE,
-                                                DEVICE_FIRMWARE_VERSION_VALUE,
-                                                guidFUID,
-                                                &pIDs);
-                            CHECK_HR(hr, "Failed to Create the ID value collection");
-                        }
-
-                        // Add the PnP ID value collection to the options
-                        if (hr == S_OK)
-                        {
-                            hr = pOptions->SetIPortableDeviceValuesValue(WPD_CLASS_EXTENSION_OPTIONS_DEVICE_IDENTIFICATION_VALUES, pIDs);
-                            CHECK_HR(hr, "Failed to set WPD_CLASS_EXTENSION_OPTIONS_DEVICE_IDENTIFICATION_VALUES");
-                        }
-
-                        // Add the transport bandwidth (in kilobits per second units) to the options
-                        // (0 indicates bandwidth unknown)
-                        if (hr == S_OK)
-                        {
-                            // Set the transport bandwidth (optional)
-                            hr = pOptions->SetUnsignedIntegerValue(WPD_CLASS_EXTENSION_OPTIONS_TRANSPORT_BANDWIDTH, 0L);
-                            CHECK_HR(hr, "Failed to set WPD_CLASS_EXTENSION_OPTIONS_TRANSPORT_BANDWIDTH");
-                        }
-                    }
-                }
-
-                if (hr == S_OK)
-                {
-                    hr = m_pPortableDeviceClassExtension->Initialize(pDevice, pOptions);
-                    CHECK_HR(hr, "Failed to Initialize portable device class extension object");
-                }
-
-                // Since users commonly have the abiltity to customize their device even when it is not
-                // connected to the PC, we need to make sure the PC is current when the driver loads.
-                //
-                // Send the latest device friendly name to the PortableDeviceClassExtension component
-                // so the system is always updated with the current device name.
-                //
-                // This call should also be made after a successful property set operation of
-                // WPD_DEVICE_FRIENDLY_NAME.
-
-                LPWSTR wszDeviceFriendlyName = NULL;
-
-                if (hr == S_OK)
-                {
-                    hr = GetDeviceFriendlyName(&wszDeviceFriendlyName);
-                    CHECK_HR(hr, "Failed to get device's friendly name");
-                }
-
-                if (hr == S_OK && wszDeviceFriendlyName != NULL)
-                {
-                    hr = UpdateDeviceFriendlyName(m_pPortableDeviceClassExtension, wszDeviceFriendlyName);
-                    CHECK_HR(hr, "Failed to update device's friendly name");
-                }
-
-                // Free the memory.  CoTaskMemFree ignores NULLs so no need to check.
-                CoTaskMemFree(wszDeviceFriendlyName);
-            }
-        }
-    }
-
-    return hr;
-}
-
-STDMETHODIMP_(HRESULT)
-CDevice::OnReleaseHardware(_In_ IWDFDevice* /*pDevice*/)
-{
-    if (m_pWpdBaseDriver != NULL)
-    {
-        m_pWpdBaseDriver->Uninitialize();
-    }
-
-    if (m_pPortableDeviceClassExtension != NULL)
-    {
-        m_pPortableDeviceClassExtension = NULL;
-    }
-
-    return S_OK;
-}
-
-HRESULT CDevice::GetSupportedContentTypes(
-    _Outptr_ IPortableDevicePropVariantCollection** ppContentTypes)
-{
-    HRESULT hr = S_OK;
-    CComPtr<IPortableDeviceValues> pParams;
-    CComPtr<IPortableDeviceValues> pResults;
-
-    if (ppContentTypes == NULL)
-    {
-        hr = E_INVALIDARG;
-        return hr;
-    }
-
-    // CoCreate a collection to store the WPD_COMMAND_CAPABILITIES_GET_SUPPORTED_CONTENT_TYPES command parameters.
-    if(SUCCEEDED(hr))
-    {
-        hr = CoCreateInstance(CLSID_PortableDeviceValues,
-                              NULL,
-                              CLSCTX_INPROC_SERVER,
-                              IID_IPortableDeviceValues,
-                              (VOID**)&pParams);
-        CHECK_HR(hr, "Failed to CoCreate CLSID_PortableDeviceValues");
-    }
-
-    // CoCreate a collection to store the WPD_COMMAND_CAPABILITIES_GET_SUPPORTED_CONTENT_TYPES command results.
-    if (hr == S_OK)
-    {
-        hr = CoCreateInstance(CLSID_PortableDeviceValues,
-                              NULL,
-                              CLSCTX_INPROC_SERVER,
-                              IID_IPortableDeviceValues,
-                              (VOID**)&pResults);
-        CHECK_HR(hr, "Failed to CoCreate CLSID_PortableDeviceValues");
-    }
-
-    // Set the params
-    if(SUCCEEDED(hr))
-    {
-        hr = pParams->SetGuidValue(WPD_PROPERTY_COMMON_COMMAND_CATEGORY, WPD_COMMAND_CAPABILITIES_GET_SUPPORTED_CONTENT_TYPES.fmtid);
-        CHECK_HR(hr, ("Failed to set WPD_PROPERTY_COMMON_COMMAND_CATEGORY"));
-    }
-    if(SUCCEEDED(hr))
-    {
-        hr = pParams->SetUnsignedIntegerValue(WPD_PROPERTY_COMMON_COMMAND_ID, WPD_COMMAND_CAPABILITIES_GET_SUPPORTED_CONTENT_TYPES.pid);
-        CHECK_HR(hr, ("Failed to set WPD_PROPERTY_COMMON_COMMAND_ID"));
-    }
-    if(SUCCEEDED(hr))
-    {
-        hr = pParams->SetGuidValue(WPD_PROPERTY_CAPABILITIES_FUNCTIONAL_CATEGORY, WPD_FUNCTIONAL_CATEGORY_ALL);
-        CHECK_HR(hr, ("Failed to set WPD_PROPERTY_CAPABILITIES_FUNCTIONAL_CATEGORY"));
-    }
-
-    // Make the call
-    if(SUCCEEDED(hr))
-    {
-        hr = m_pWpdBaseDriver->DispatchWpdMessage(pParams, pResults);
-        CHECK_HR(hr, ("Failed to dispatch message to get supported content types"));
-    }
-
-    // Get the results
-    if(SUCCEEDED(hr))
-    {
-        hr = pResults->GetIPortableDevicePropVariantCollectionValue(WPD_PROPERTY_CAPABILITIES_CONTENT_TYPES, ppContentTypes);
-        CHECK_HR(hr, ("Failed to get WPD_PROPERTY_CAPABILITIES_CONTENT_TYPES"));
-    }
-
-    return hr;
-}
-
-HRESULT CDevice::GetDeviceFriendlyName(
-    _Outptr_result_maybenull_ LPWSTR*   pwszDeviceFriendlyName)
-{
-    HRESULT hr = S_OK;
-
-    CComPtr<IPortableDeviceValues>        pParams;
-    CComPtr<IPortableDeviceValues>        pResults;
-    CComPtr<IPortableDeviceKeyCollection> pKeys;
-    CComPtr<IPortableDeviceValues>        pValues;
-
-    if (pwszDeviceFriendlyName == NULL)
-    {
-        hr = E_INVALIDARG;
-        return hr;
-    }
-
-    *pwszDeviceFriendlyName = NULL;
-
-    // CoCreate a collection to store the WPD_COMMAND_OBJECT_PROPERTIES_GET command parameters.
-    if (hr == S_OK)
-    {
-        hr = CoCreateInstance(CLSID_PortableDeviceValues,
-                              NULL,
-                              CLSCTX_INPROC_SERVER,
-                              IID_IPortableDeviceValues,
-                              (VOID**)&pParams);
-        CHECK_HR(hr, "Failed to CoCreate CLSID_PortableDeviceValues");
-    }
-
-    // CoCreate a collection to store the WPD_COMMAND_OBJECT_PROPERTIES_GET command results.
-    if (hr == S_OK)
-    {
-        hr = CoCreateInstance(CLSID_PortableDeviceValues,
-                              NULL,
-                              CLSCTX_INPROC_SERVER,
-                              IID_IPortableDeviceValues,
-                              (VOID**)&pResults);
-        CHECK_HR(hr, "Failed to CoCreate CLSID_PortableDeviceValues");
-    }
-
-    // CoCreate a collection to store the requested property keys.  In our case, we are requesting just the device friendly name
-    // (WPD_DEVICE_FRIENDLY_NAME)
-    if (hr == S_OK)
-    {
-        hr = CoCreateInstance(CLSID_PortableDeviceKeyCollection,
-                              NULL,
-                              CLSCTX_INPROC_SERVER,
-                              IID_IPortableDeviceKeyCollection,
-                              (VOID**)&pKeys);
-        CHECK_HR(hr, "Failed to CoCreate CLSID_PortableDeviceKeyCollection for results");
-    }
-
-    // Set the params
-    if (hr == S_OK)
-    {
-        hr = pParams->SetGuidValue(WPD_PROPERTY_COMMON_COMMAND_CATEGORY, WPD_COMMAND_OBJECT_PROPERTIES_GET.fmtid);
-        CHECK_HR(hr, ("Failed to set WPD_PROPERTY_COMMON_COMMAND_CATEGORY"));
-    }
-
-    if (hr == S_OK)
-    {
-        hr = pParams->SetUnsignedIntegerValue(WPD_PROPERTY_COMMON_COMMAND_ID, WPD_COMMAND_OBJECT_PROPERTIES_GET.pid);
-        CHECK_HR(hr, ("Failed to set WPD_PROPERTY_COMMON_COMMAND_ID"));
-    }
-
-    if (hr == S_OK)
-    {
-        hr = pParams->SetStringValue(WPD_PROPERTY_OBJECT_PROPERTIES_OBJECT_ID, WPD_DEVICE_OBJECT_ID);
-        CHECK_HR(hr, ("Failed to set WPD_PROPERTY_OBJECT_PROPERTIES_OBJECT_ID"));
-    }
-
-    if (hr == S_OK)
-    {
-        hr = pKeys->Add(WPD_DEVICE_FRIENDLY_NAME);
-        CHECK_HR(hr, ("Failed to add WPD_DEVICE_FRIENDLY_NAME to key collection"));
-    }
-
-    if (hr == S_OK)
-    {
-        hr = pParams->SetIPortableDeviceKeyCollectionValue(WPD_PROPERTY_OBJECT_PROPERTIES_PROPERTY_KEYS, pKeys);
-        CHECK_HR(hr, ("Failed to set WPD_PROPERTY_OBJECT_PROPERTIES_PROPERTY_KEYS"));
-    }
-
-    // Make the call
-    if (hr == S_OK)
-    {
-        hr = m_pWpdBaseDriver->DispatchWpdMessage(pParams, pResults);
-        CHECK_HR(hr, ("Failed to dispatch message to get supported content types"));
-    }
-
-    // Get the results
-    if (hr == S_OK)
-    {
-        hr = pResults->GetIPortableDeviceValuesValue(WPD_PROPERTY_OBJECT_PROPERTIES_PROPERTY_VALUES, &pValues);
-        CHECK_HR(hr, ("Failed to get WPD_PROPERTY_OBJECT_PROPERTIES_PROPERTY_VALUES"));
-    }
-
-    if (hr == S_OK)
-    {
-        hr = pValues->GetStringValue(WPD_DEVICE_FRIENDLY_NAME, pwszDeviceFriendlyName);
-        CHECK_HR(hr, ("Failed to get WPD_DEVICE_FRIENDLY_NAME"));
-    }
-
-    return hr;
-}
-
-HRESULT
-CDevice::CreateIDValues(
-    _In_         LPCWSTR pszManufacturer,
-    _In_         LPCWSTR pszModel,
-    _In_opt_     LPCWSTR pszVersion,
-    _In_ REFGUID guidFUID,
-    _COM_Outptr_ IPortableDeviceValues** ppValues)
-{
-    HRESULT hr = S_OK;
-    CComPtr<IPortableDeviceValues> pValues;
-
-    *ppValues = NULL;
-
-    // Create the object to hold the ID values
-    hr = CoCreateInstance(
-        CLSID_PortableDeviceValues,
-        NULL,
-        CLSCTX_INPROC_SERVER,
-        IID_IPortableDeviceValues,
-        (VOID**)&pValues);
-
-    if (SUCCEEDED(hr))
-    {
-        hr = pValues->SetStringValue(WPD_DEVICE_MANUFACTURER, pszManufacturer);
-    }
-
-    if (SUCCEEDED(hr))
-    {
-        hr = pValues->SetStringValue(WPD_DEVICE_MODEL, pszModel);
-    }
-
-    if (SUCCEEDED(hr) && pszVersion)
-    {
-        hr = pValues->SetStringValue(WPD_DEVICE_FIRMWARE_VERSION, pszVersion);
-    }
-
-    if (SUCCEEDED(hr))
-    {
-        hr = pValues->SetGuidValue(WPD_DEVICE_FUNCTIONAL_UNIQUE_ID, guidFUID);
-    }
-
-    if (SUCCEEDED(hr))
-    {
-        *ppValues = pValues.Detach();
-    }
-
-    return hr;
-}
-
-HRESULT UpdateDeviceFriendlyName(
-    _In_ IPortableDeviceClassExtension*  pPortableDeviceClassExtension,
-    _In_ LPCWSTR                         wszDeviceFriendlyName)
-{
-    HRESULT hr = S_OK;
-
-    // If we were passed NULL parameters we have nothing to do, return S_OK.
-    if ((pPortableDeviceClassExtension == NULL) ||
-        (wszDeviceFriendlyName         == NULL))
-    {
-        return S_OK;
-    }
-
-    CComPtr<IPortableDeviceValues>  pParams;
-    CComPtr<IPortableDeviceValues>  pResults;
-    CComPtr<IPortableDeviceValues>  pValues;
-
-    // Prepare to make a call to set the device information
-    if (hr == S_OK)
-    {
-        hr = CoCreateInstance(CLSID_PortableDeviceValues,
-                              NULL,
-                              CLSCTX_INPROC_SERVER,
-                              IID_IPortableDeviceValues,
-                              (VOID**)&pParams);
-        CHECK_HR(hr, "Failed to CoCreate CLSID_PortableDeviceValues");
-    }
-
-    if (hr == S_OK)
-    {
-        hr = CoCreateInstance(CLSID_PortableDeviceValues,
-                              NULL,
-                              CLSCTX_INPROC_SERVER,
-                              IID_IPortableDeviceValues,
-                              (VOID**)&pResults);
-        CHECK_HR(hr, "Failed to CoCreate CLSID_PortableDeviceValues for results");
-    }
-
-    if (hr == S_OK)
-    {
-        hr = CoCreateInstance(CLSID_PortableDeviceValues,
-                              NULL,
-                              CLSCTX_INPROC_SERVER,
-                              IID_IPortableDeviceValues,
-                              (VOID**)&pValues);
-        CHECK_HR(hr, "Failed to CoCreate CLSID_PortableDeviceValues for results");
-    }
-
-    // Get the information values to update and set them in WPD_PROPERTY_CLASS_EXTENSION_DEVICE_INFORMATION_VALUES
-    if (hr == S_OK)
-    {
-        hr = pValues->SetStringValue(WPD_DEVICE_FRIENDLY_NAME, wszDeviceFriendlyName);
-        CHECK_HR(hr, ("Failed to set WPD_DEVICE_FRIENDLY_NAME"));
-    }
-
-    // Set the params
-    if (hr == S_OK)
-    {
-        hr = pParams->SetGuidValue(WPD_PROPERTY_COMMON_COMMAND_CATEGORY, WPD_COMMAND_CLASS_EXTENSION_WRITE_DEVICE_INFORMATION.fmtid);
-        CHECK_HR(hr, ("Failed to set WPD_PROPERTY_COMMON_COMMAND_CATEGORY"));
-    }
-    if (hr == S_OK)
-    {
-        hr = pParams->SetUnsignedIntegerValue(WPD_PROPERTY_COMMON_COMMAND_ID, WPD_COMMAND_CLASS_EXTENSION_WRITE_DEVICE_INFORMATION.pid);
-        CHECK_HR(hr, ("Failed to set WPD_PROPERTY_COMMON_COMMAND_ID"));
-    }
-    if (hr == S_OK)
-    {
-        hr = pParams->SetIPortableDeviceValuesValue(WPD_PROPERTY_CLASS_EXTENSION_DEVICE_INFORMATION_VALUES, pValues);
-        CHECK_HR(hr, ("Failed to set WPD_PROPERTY_CLASS_EXTENSION_DEVICE_INFORMATION_VALUES"));
-    }
-
-    // Make the call
-    if (hr == S_OK)
-    {
-        hr = pPortableDeviceClassExtension->ProcessLibraryMessage(pParams, pResults);
-        CHECK_HR(hr, ("Failed to process update device information message"));
-    }
-
-    // A Failed ProcessLibraryMessage operation for updating this value is not considered
-    // fatal and should return S_OK.
-
-    return S_OK;
-}