| Age | Commit message (Collapse) | Author |
|---|
|
|
|
|
|
|
|
|
|
|
|
|
|
This PR performs a whitespace-only cleanup by removing trailing spaces/tabs from source files under network\ndis. This is to reduce noise when making changes using AI so that future reviews are easier to be done by humans.
No functional logic changes were introduced.
What Changed
1. Removed end-of-line trailing whitespace in text files.
2. Kept file encoding and line endings intact by applying byte-preserving edits.
Risk / Impact
1. Low risk: formatting-only change.
2. No API, behavior, or build configuration changes intended.
|
|
andremueiot/user/andremueiot/multiplication_converted_to_larger_type
NDIS: Harden QoS bytes calculation in netvmini control path
|
|
- Replaced direct size arithmetic in NICSetQOSParameters with checked integer-safe operations.
- Added overflow handling for classification table size computation:
- Multiply NumClassificationElements × ClassificationElementSize via RtlULongMult.
- Add the revision header size via RtlULongAdd.
- Return NDIS_STATUS_INVALID_LENGTH when either checked operation fails, instead of relying on unchecked arithmetic.
|
|
Summary
This PR addresses a static-analysis warning in rssv2.c related to comparing values of different integer widths in a loop condition.
Changes
- Updated the loop index type in NICSetRSSv2FindProcessorInRssSet from UINT8 to ULONG to match RssProcessorCount width.
- Added an explicit cast when returning the found index: return (UINT8)index; to preserve the function’s return type and behavior.
Why
Using matching integer widths in loop comparisons avoids analyzer warnings and reduces risk of subtle boundary issues.
Impact
No functional behavior change is intended; this is a type-safety and code-quality fix for warning cleanup.
|
|
These changes eliminate the warnings about uninitialized variables under network\ndis.
A macro was also added to prottest.c to suppress a (false) buffer overrun.
|
|
|
|
|
|
* Removed Win32 and Arm from the project configurations.
* Set default platform to x64.
|
|
* Added ARM64 as a new project configuration in both Debug and Release modes.
* Set up properties for the ARM64 platform, including target version, debug libraries, driver target platform, driver type, and platform toolset.
* Included additional dependencies for the ARM64 build.
* Added ARM64 to the list of platforms for which the mux.dll file is packaged.
* Remove /CETCOMPAT as it's not compatible with ARM64
|
|
* Add ARM64 as target platform on multiple samples
* Remove ARM64 from WFPSampler temporarily
---------
Co-authored-by: Jakob Lichtenberg (170957) <[email protected]>
|
|
* Delete deprecated directives DelFiles and DelService
* Add PnpLockdown=1 to the version section of the inf
* Add catalog file in muxp.inf
* Add PnpLockdown=1 to the version section of mux_mp.inf
* Add catalog file in mux_mp.inf
* include mux_mp.inf in the muxvaln project
* include muxp.inf in mux project. Add mux.dll as file to package. Note as of now the Notifyob proj must be built then mux.dll must be moved to the Project Directory
* Changed all DIRID to 13
* change all DIRID to 13
* Create build dependency so that mux.dll is generated before other projects.
* Include the mux.dll from the notifyob project into the build package
* Delete comments
* Edit muxp.inf so that DIRID 13 is used for installation above certain releases
* Change MUXP->MUXP_NC and MUXP_Update->MUXP. This makes the updated version look like the default. Old version called _NC for non-compliant
* Edit muxp.inf so that MUXP comes before MUXP_NC
* Make same edits to mux_mp.inf
* Enable the Control-flow Enforcement Technology (CET) Shadow Stack mitigation
* Fix Warning from runing Prefast static analysis
* Fix more warnings from running Prefast
* Use stampinf ARCH variable to replace all the hard coded architecures in mux_mp.inf
* Use stampinf ARCH variable to replace all the hard coded architecures in muxp.inf
* Delete extra comma typo
* Change encoding of mux_mp.inf to UTF-16 LE
* Change encoding of muxp.inf to UTF-16 LE
* Add the correct build number for installing network drivers with Dlls and upate comment in muxp.inf
* Add the correct build number for installing network drivers with Dlls and upate comment in mux_mp.inf
* Change all instances of MUXP tp MUXMP in mux_mp.inf
* Change Brace style to match existing code
* Fix mistakes returning win32 err for HRESULT, and leaking memory
* Fix mux_mp.inf to payload muxvlan.sys
* Edit to sln and vcxproj files to edit how build directories are made
* Edit vcxproj files to package correct files. Edit Target name for muxvlan project to be mux so the same inf files can be used for both projects
* Remove comments
* Fix mux_mp.inf to payload mux.sys
* fix mistakes returning win32 err instead of HRESULT, and leaking mem
* Change comment on mux_mp.inf explaining why build 25341 is used
* Free lpszBindName before return.
|
|
* Add PnpLockdown=1 to the version section of the inf
* Change service name to Ndisprot60
* Change Section 'wdfsection' to 'Install.Wdf' so it can be referenced. Change service to NdisProt60 in that section
* Change all DIRID to 13
* Add different manufacturer entires so installtion is different for Windows 7 vs Windows 10 and above
* Add another manufacturer so the driver installs in DriverStore for newest builds
* Enable the Control-flow Enforcement Technology (CET) Shadow Stack mitigation
* Add SAL annotation to the DllCanUnloadNow definition to match declaration
* Use stampinf ARCH variable to replace hard coded architectures
* Fix a comment
* Add the correct build number for installing network drivers using Dlls and update comment.
|
|
Driver' (#971)
Co-authored-by: Jason Knichel <[email protected]>
|
|
Co-authored-by: Jason Knichel <[email protected]>
|
|
Co-authored-by: Jason Knichel <[email protected]>
|
|
* Add PnPLockdown=1 to the veresion section to the inf
* Added segments to the DriverVer
* Change Service name to Ndisprot630
* Edit INF to install used DIRID 13 above a certain release number
* Change names Install->Install_NC and Install_Update->Install
* Move things around so Install appears before Install_NC
* enable the Control-flow Enforcement Technology (CET) Shadow Stack mitigation
* Network driver INF that target DIRID 13 should only build 25319 or later
* Update comment
* Enable CET Shadow Stack compatiblility
|
|
* removed unused Common.Params.reg section
* Change DIRID from 12 to 13
* add PnpLockdown = 1 to the version section of the inf
* Edit inf so that it uses DIRID 13 for installation above certain release
* add the x86 and ia64 archs that were previously removed for simplicity
* add comment on why there is a different installation for newer build versions
* Move sections so updated ones appear first
* Change Install_Update->Install and Install->Install_NC
* Enable CET Shadow Stack Compatible
* remove white space
* Use the stampinf ARCH variable to replace all the hard coded architectures
* Network driver INF that use DIRID 13 should only target build 25319 or later
* Update comment
* delete some white space
* Change encoding of inf to UTF-16LE
|
|
* Add PnpLockdown=1 to the version section of the INF
* Add segments to the DriverVer
* Change Service name from Ndisprot to Ndisprot60 because Ndisprot is reserved
* Edit INF to install used DIRID 13 above a certain release number
* Add section Install_Update.Remove.Services
* Change names Install->Install_NC and Install_Update->Install
* Move things around so Install appears before Install_NC
* enable the Control-flow Enforcement Technology (CET) Shadow Stack mitigation
* Network driver INF that target DIRID 13 should only build 25319 or later
* Update comment
|
|
* Add PnpLockdown=1 to the version section of the INF
* Add segments to DriverVer in INF
* Change DIRID from 12 to 13
* Enable the Control-flow Enforcement Technology (CET) Shadow Stack mitigation.
* Use Stampinf architecture
* Change the encoding of inf to UTF-16LE
|
|
* Use Stampinf architecture
* Enable the CET Shadow Stack mitigation
* Change the encoding of inf to UTF-16LE
|
|
* Enable stampinf arch replacement for netvmini60
* delete stray comma
* Enable stampinf arch replacement for netvmini620
* Enable stampinf arch replacement for netvmini630
* Enable stampinf arch replacement for netvmini680
* Enable the CET Shadow Stack mitigation for each netvmini60,620,630,680 projects
|
|
updates (#928)
Co-authored-by: Jason Knichel <[email protected]>
|
|
* Opt-in many Desktop samples for ApiValidator
ApiValidator is passing for many of our samples
marked Desktop. This is promising and it is worth
running ApiValidator on these to ensure they stay within
the Universal API limits.
* Shift avstream/sampledevicemft sample to use mfcore.dll rather than mf.dll
* Opt many samples in for Universal validation
Many of our driver samples build cleanly agains the UniversalDDIs.xml
API list. Opting these in as Universal helps protect their API surface
against accidentally picking up more Desktop-only APIs.
* Revert "Opt-in many Desktop samples for ApiValidator"
This reverts commit a6aa7e6797ab01e6b15c8a4e1cbcea6d7a615629.
---------
Co-authored-by: Michael Bernstein (DPLAT) <[email protected]>
|
|
Co-authored-by: Jason Knichel <[email protected]>
|
|
|
|
* Add PnpLockdown to the version section of the INF
* Add segments to DriverVer
* Change DIRID from 12 to 13
|
|
* add NDIS_SUPPORT_NDIS680 in #if directive in adapter.c
* add NDIS_SUPPORT_NDIS680 in #if directive in miniport.c
* fix driver isolation violation 1323 for netvmini680.inf
* fix driver isolation violation 1322 for netvmini680.inf
* set NIC_PHYSICAL_MEDIUM to NdisPhysicalMedium802_3 in hardware.h
* change local type from ULONG to UINT8 to match return type
* Remove AddReg TextModeFlags in inf for netvmini680
|
|
drivers. (#803)
* fix driver isolation violations 1322 1323 for netvmini60.inf
* fix driver isolation violations 1322 1323 for netvmini620.inf
* fix driver isolation violations 1322 1323 for netvmini630.inf
* change local type from ULONG to UINT8 to match return type
* Remove AddReg TextModeFlags in inf for netvmini60
* Remove AddReg TextModeFlags in inf for netvmini620
* Remove AddReg TextModeFlags in inf for netvmini630
|
|
fix UINT8 comparison with ULONG
|
|
Virtual Miniport: Replace ExAllocatePool* with ExAllocatePool2
|
|
|
|
|
|
Update switch extension samples to use SHA256 driver signing
|
|
|
|
|
|
|
|
|
|
|
|
|
|
* Update README.md
* Update README.md
|
|
|
|
|
|
|
|
* Update README.md
* Update README.md
|
