| Age | Commit message (Collapse) | Author |
|
different adapter types.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
andremueiot/user/andremueiot/trailing_spaces_config
Removed trailing spaces under config and modem
|
|
This PR performs a whitespace-only cleanup by removing trailing spaces/tabs from source files under network\ndis. This is to reduce noise when making changes using AI so that future reviews are easier to be done by humans.
No functional logic changes were introduced.
What Changed
1. Removed end-of-line trailing whitespace in text files.
2. Kept file encoding and line endings intact by applying byte-preserving edits.
Risk / Impact
1. Low risk: formatting-only change.
2. No API, behavior, or build configuration changes intended.
|
|
This PR performs a whitespace-only cleanup by removing trailing spaces/tabs from source files under directories:
• network\config
• network\modem
No functional logic changes were introduced.
What Changed
1. Removed end-of-line trailing whitespace in text files.
2. Kept file encoding and line endings intact by applying byte-preserving edits.
Risk / Impact
1. Low risk: formatting-only change.
2. No API, behavior, or build configuration changes intended.
|
|
andremueiot/user/andremueiot/multiplication_converted_to_larger_type
NDIS: Harden QoS bytes calculation in netvmini control path
|
|
- Replaced direct size arithmetic in NICSetQOSParameters with checked integer-safe operations.
- Added overflow handling for classification table size computation:
- Multiply NumClassificationElements × ClassificationElementSize via RtlULongMult.
- Add the revision header size via RtlULongAdd.
- Return NDIS_STATUS_INVALID_LENGTH when either checked operation fails, instead of relying on unchecked arithmetic.
|
|
Summary
This PR addresses a static-analysis warning in rssv2.c related to comparing values of different integer widths in a loop condition.
Changes
- Updated the loop index type in NICSetRSSv2FindProcessorInRssSet from UINT8 to ULONG to match RssProcessorCount width.
- Added an explicit cast when returning the found index: return (UINT8)index; to preserve the function’s return type and behavior.
Why
Using matching integer widths in loop comparisons avoids analyzer warnings and reduces risk of subtle boundary issues.
Impact
No functional behavior change is intended; this is a type-safety and code-quality fix for warning cleanup.
|
|
andremueiot/user/andremueiot/uninitialized_var_bindview
Potentially uninitialized variables in bindview
|
|
These changes eliminate the warnings about uninitialized variables under network\ndis.
A macro was also added to prottest.c to suppress a (false) buffer overrun.
|
|
These changes eliminate the warnings below in bindview.cpp by initializinf the variables mentioned.
1449 The status of this call to externally defined (SAL) GetCursorPos is not checked, potentially leaving pt uninitialized.
1528 The status of this call to externally defined (SAL) GetCursorPos is not checked, potentially leaving pt uninitialized.
1825 The status of this call to externally defined (SAL) GetDeviceStatus is not checked, potentially leaving ulStatus uninitialized.
|
|
|
|
|
|
Added assertions to EnlpAffinitizeThread to verify BitScanReverse succeeds. Updated EnlRingDoorBell to properly acquire and release the spinlock around the Armed state check for thread safety. Removed obsolete netvadapterlibrary.sln.old solution file.
|
|
|
|
|
|
VCXProj driven Nuget package. hardcode the WIL path
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
memory related header -KNEW.H
|
|
|
|
|
|
https://learn.microsoft.com/en-us/windows-hardware/drivers/install/general-guidelines-for-inf-files#editing-inf-files-and-file-encodings
The file must be saved with an ANSI or Unicode (UTF-16 LE) file encoding. Unicode (UTF-16 LE) is preferred since it allows the INF to support localizing the INF Strings section in a wide variety of languages. If your INF contains non-ASCII characters, you must save the file as a Unicode (UTF-16 LE) file.
|
|
|
|
'D:\a\Windows-driver-samples\Windows-driver-samples\network\wlan\WIFICX\um\ARM64\Debug\wificxsampleclientum.inf', must contain [Version] section and have signature "$Windows NT$"
|
|
inf2cat and code analysis. Will enable back when newer version EWDK fixed the issue.
|
|
|
|
|
|
|
|
start handling the WifiRequest
|