From 7406226311c363607c2eb0daabd3dcfcb63625bb Mon Sep 17 00:00:00 2001 From: Gerrit Swaneveld Date: Tue, 9 Jun 2026 12:31:37 -0700 Subject: Fix to use CPP20 for compiler STD 17 used experimental coroutine. STD 20 uses standard C++. WinRT will inherit the coroutine automatically, so updating to STD 20 will fix this issue. --- general/SimpleMediaSource/MediaSource/MediaSource.vcxproj | 11 +++++------ general/SimpleMediaSource/MediaSource/SimpleMediaSource.cpp | 6 +++--- .../SimpleMediaSourceDriver/SimpleMediaSourceDriver.vcxproj | 3 +-- 3 files changed, 9 insertions(+), 11 deletions(-) diff --git a/general/SimpleMediaSource/MediaSource/MediaSource.vcxproj b/general/SimpleMediaSource/MediaSource/MediaSource.vcxproj index 78bbbfbb..02e1a0d7 100644 --- a/general/SimpleMediaSource/MediaSource/MediaSource.vcxproj +++ b/general/SimpleMediaSource/MediaSource/MediaSource.vcxproj @@ -22,14 +22,13 @@ 15.0 {43AD9BF7-E765-48FE-9826-71A8F2CB12DD} MediaSource - $(LatestTargetPlatformVersion) SimpleMediaSource DynamicLibrary true - WindowsApplicationForDrivers10.0 + v145 Unicode @@ -99,7 +98,7 @@ false Sync MultiThreadedDebugDLL - stdcpp17 + stdcpp20 Create pch.h ..\..\..\wil\include;$(IntDir);%(AdditionalIncludeDirectories) @@ -119,7 +118,7 @@ false Sync MultiThreadedDebugDLL - stdcpp17 + stdcpp20 Create pch.h ..\..\..\wil\include;$(IntDir);%(AdditionalIncludeDirectories) @@ -141,7 +140,7 @@ false MultiThreadedDLL Sync - stdcpp17 + stdcpp20 Create pch.h ..\..\..\wil\include;$(IntDir);%(AdditionalIncludeDirectories) @@ -165,7 +164,7 @@ false MultiThreadedDLL Sync - stdcpp17 + stdcpp20 Create pch.h ..\..\..\wil\include;$(IntDir);%(AdditionalIncludeDirectories) diff --git a/general/SimpleMediaSource/MediaSource/SimpleMediaSource.cpp b/general/SimpleMediaSource/MediaSource/SimpleMediaSource.cpp index 8ff15872..e672c9da 100644 --- a/general/SimpleMediaSource/MediaSource/SimpleMediaSource.cpp +++ b/general/SimpleMediaSource/MediaSource/SimpleMediaSource.cpp @@ -27,11 +27,11 @@ namespace winrt::WindowsSample::implementation RETURN_IF_FAILED(m_streamList[i]->Initialize(this, i, MFSampleAllocatorUsage_UsesProvidedAllocator)); RETURN_IF_FAILED(m_streamList[i]->GetStreamDescriptor(&streamDescriptorList[i])); - } + } - RETURN_IF_FAILED(MFCreatePresentationDescriptor(m_streamList.size(), streamDescriptorList.get(), &m_spPresentationDescriptor)); + RETURN_IF_FAILED(MFCreatePresentationDescriptor(static_cast(m_streamList.size()), streamDescriptorList.get(), &m_spPresentationDescriptor)); - m_sourceState = SourceState::Stopped; + m_sourceState = SourceState::Stopped; return S_OK; } diff --git a/general/SimpleMediaSource/SimpleMediaSourceDriver/SimpleMediaSourceDriver.vcxproj b/general/SimpleMediaSource/SimpleMediaSourceDriver/SimpleMediaSourceDriver.vcxproj index cca6b63a..422ac09a 100644 --- a/general/SimpleMediaSource/SimpleMediaSourceDriver/SimpleMediaSourceDriver.vcxproj +++ b/general/SimpleMediaSource/SimpleMediaSourceDriver/SimpleMediaSourceDriver.vcxproj @@ -59,10 +59,9 @@ Debug x64 SimpleMediaSourceDriver - $(LatestTargetPlatformVersion) - WindowsUserModeDriver10.0 + v145 DynamicLibrary Universal -- cgit v1.3.1 From 7bb4625b2183f45587c7748e7a8b8fd5e65338fd Mon Sep 17 00:00:00 2001 From: 5an7y Date: Tue, 9 Jun 2026 14:38:47 -0700 Subject: Remove general\simplemediasource from exclusions.csv The CPP20 compiler fix in this PR resolves the VS 18.4 build failure, so the build exclusion is no longer needed. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --- exclusions.csv | 1 - 1 file changed, 1 deletion(-) diff --git a/exclusions.csv b/exclusions.csv index 1be0512e..df12335d 100644 --- a/exclusions.csv +++ b/exclusions.csv @@ -10,4 +10,3 @@ general\pcidrv,*,26100,,"failure introduced in VS17.14, suppressed until fix" serial\serial,*,26100,,"failure introduced in VS17.14, suppressed until fix" network\wlan\wdi,*,26100,,"failure introduced in VS17.14, suppressed until fix" tools\kasan\samples\kasandemo-wdm,*|x64,26100,,"failure introduced in VS17.14, suppressed until fix" -general\simplemediasource,*,,,"Failure introduced by VS 18.4, suppressed until fix" -- cgit v1.3.1 From c877bfd2add28f8691758d72c97c43c8fc8062dd Mon Sep 17 00:00:00 2001 From: Gerrit Swaneveld Date: Wed, 10 Jun 2026 11:48:06 -0700 Subject: Reset to correct toolset Use WindowsApplicationForDrivers and WindowsUserModeDriver to access WDF --- general/SimpleMediaSource/MediaSource/MediaSource.vcxproj | 2 +- .../SimpleMediaSourceDriver/SimpleMediaSourceDriver.vcxproj | 5 +++-- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/general/SimpleMediaSource/MediaSource/MediaSource.vcxproj b/general/SimpleMediaSource/MediaSource/MediaSource.vcxproj index 02e1a0d7..dee4adb3 100644 --- a/general/SimpleMediaSource/MediaSource/MediaSource.vcxproj +++ b/general/SimpleMediaSource/MediaSource/MediaSource.vcxproj @@ -28,7 +28,7 @@ DynamicLibrary true - v145 + WindowsApplicationForDrivers10.0 Unicode diff --git a/general/SimpleMediaSource/SimpleMediaSourceDriver/SimpleMediaSourceDriver.vcxproj b/general/SimpleMediaSource/SimpleMediaSourceDriver/SimpleMediaSourceDriver.vcxproj index 422ac09a..7eaf2747 100644 --- a/general/SimpleMediaSource/SimpleMediaSourceDriver/SimpleMediaSourceDriver.vcxproj +++ b/general/SimpleMediaSource/SimpleMediaSourceDriver/SimpleMediaSourceDriver.vcxproj @@ -1,4 +1,4 @@ - + @@ -61,7 +61,7 @@ SimpleMediaSourceDriver - v145 + WindowsUserModeDriver10.0 DynamicLibrary Universal @@ -127,6 +127,7 @@ true true trace.h + stdcpp20 %(AdditionalDependencies);OneCoreUAP.lib -- cgit v1.3.1