diff options
| author | Jérôme Leclercq <[email protected]> | 2023-10-20 10:41:32 +0200 |
|---|---|---|
| committer | GitHub <[email protected]> | 2023-10-20 10:41:32 +0200 |
| commit | 9991a20e1302dc7cb1df77bd0771e052b9a5e429 (patch) | |
| tree | 9c72213cf840f7a87f65f882ebd057bac633af92 | |
| parent | ff24cac604e403bd930898da743e27bd9eca1d48 (diff) | |
cmakelists: restore system headers
It's been three years since #1050 and msvc has stable external header support now, I think we can now re-enable system headers for cmakelists
| -rw-r--r-- | xmake/plugins/project/cmake/cmakelists.lua | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/xmake/plugins/project/cmake/cmakelists.lua b/xmake/plugins/project/cmake/cmakelists.lua index 9d66cba48..d186b0a02 100644 --- a/xmake/plugins/project/cmake/cmakelists.lua +++ b/xmake/plugins/project/cmake/cmakelists.lua @@ -450,8 +450,7 @@ end function _add_target_sysinclude_directories(cmakelists, target, outputdir) local includedirs = _get_configs_from_target(target, "sysincludedirs") if #includedirs > 0 then - -- TODO should be `SYSTEM PRIVATE` - cmakelists:print("target_include_directories(%s PRIVATE", target:name()) + cmakelists:print("target_include_directories(%s SYSTEM PRIVATE", target:name()) for _, includedir in ipairs(includedirs) do cmakelists:print(" " .. _get_relative_unix_path(includedir, outputdir)) end @@ -459,7 +458,7 @@ function _add_target_sysinclude_directories(cmakelists, target, outputdir) end local includedirs_interface = target:get("sysincludedirs", {interface = true}) if includedirs_interface then - cmakelists:print("target_include_directories(%s INTERFACE", target:name()) + cmakelists:print("target_include_directories(%s SYSTEM INTERFACE", target:name()) for _, headerdir in ipairs(includedirs_interface) do cmakelists:print(" " .. _get_relative_unix_path(headerdir, outputdir)) end |