diff options
| author | Roy Ivy III <[email protected]> | 2018-10-14 22:16:24 -0500 |
|---|---|---|
| committer | Roy Ivy III <[email protected]> | 2018-10-15 22:55:16 -0500 |
| commit | ca72eb0cf60c3e0747444859d9fc738b98ecc4b5 (patch) | |
| tree | 460d1694c4a414510146de57e1e62a59588a332f /xmake/plugins/lua/scripts/mkdir.lua | |
| parent | 19829f49a644d4377c082df90b812a891d4d403c (diff) | |
fix find_vstudio when executing from an already defined MSVC command prompt
.# Discussion
Older MSVC/VS versions don't define the "VisualStudioVersion" environment variable.
Prior to this fix, when executing within an already prepared environment (eg, the
"Visual Studio Command Prompt") with those older MSVC/VS builds, the search logic would
incorrectly try to search for all installed versions and read their environments. But
since the environment had already been prepped, executing `vsvarsall` for any found
MSVC/VS versions resulted in a superimposed and confused/invalid environment.
For the older MSVC/VS versions without "VisualStudioVersion", this fix does use
heuristics to guess at the correct version (and it's corresponding vsvers value [used as
the results key value]). But, even if the wrong version is guessed, the results from
find_vstudio are clean, without any environmental superposition, and fully usable for
compilation.
Diffstat (limited to 'xmake/plugins/lua/scripts/mkdir.lua')
0 files changed, 0 insertions, 0 deletions
