summaryrefslogtreecommitdiff
path: root/xmake/plugins
diff options
context:
space:
mode:
authorwtz <[email protected]>2023-07-19 12:35:52 +0800
committerwtz <[email protected]>2023-07-19 12:35:52 +0800
commitf75224a8435d0eb9cdda79f8bc571eeef25a8e33 (patch)
tree278e00b17c8f5558df1c1a21f1204078ea62a58f /xmake/plugins
parentca83e9a78b7f2d45e833fa705c880867ad2381c6 (diff)
Fix grammar
Diffstat (limited to 'xmake/plugins')
-rw-r--r--xmake/plugins/doxygen/main.lua2
-rw-r--r--xmake/plugins/format/main.lua2
-rw-r--r--xmake/plugins/project/clang/compile_commands.lua4
-rw-r--r--xmake/plugins/project/cmake/cmakelists.lua4
-rw-r--r--xmake/plugins/project/ninja/build_ninja.lua2
-rw-r--r--xmake/plugins/project/utils/target_cmds.lua2
-rw-r--r--xmake/plugins/project/vstudio/impl/vs201x_solution.lua2
-rw-r--r--xmake/plugins/project/vstudio/impl/vs201x_vcxproj.lua6
-rw-r--r--xmake/plugins/project/vsxmake/getinfo.lua2
-rw-r--r--xmake/plugins/project/xcode/xcodeproj.lua2
10 files changed, 14 insertions, 14 deletions
diff --git a/xmake/plugins/doxygen/main.lua b/xmake/plugins/doxygen/main.lua
index 9ebaac8f3..876e747d1 100644
--- a/xmake/plugins/doxygen/main.lua
+++ b/xmake/plugins/doxygen/main.lua
@@ -89,7 +89,7 @@ function main()
instance:envs_enter()
end
- -- we need force to detect and flush detect cache after loading all environments
+ -- we need to force detect and flush detect cache after loading all environments
if not doxygen then
doxygen = find_tool("doxygen", {force = true})
end
diff --git a/xmake/plugins/format/main.lua b/xmake/plugins/format/main.lua
index 328bcb394..297e0a851 100644
--- a/xmake/plugins/format/main.lua
+++ b/xmake/plugins/format/main.lua
@@ -47,7 +47,7 @@ function main()
instance:envs_enter()
end
- -- we need force to detect and flush detect cache after loading all environments
+ -- we need to force detect and flush detect cache after loading all environments
if not clang_format then
clang_format = find_tool("clang-format", {force = true})
end
diff --git a/xmake/plugins/project/clang/compile_commands.lua b/xmake/plugins/project/clang/compile_commands.lua
index ded2ad3c4..e7034abe4 100644
--- a/xmake/plugins/project/clang/compile_commands.lua
+++ b/xmake/plugins/project/clang/compile_commands.lua
@@ -62,7 +62,7 @@ function _translate_arguments(arguments)
local is_include = false
local lsp = _get_lsp()
for idx, arg in ipairs(arguments) do
- -- convert path to string, maybe we need convert path, but not supported now.
+ -- convert path to string, maybe we need to convert path, but not supported now.
arg = tostring(arg)
-- see https://github.com/xmake-io/xmake/issues/1721
@@ -72,7 +72,7 @@ function _translate_arguments(arguments)
if arg:startswith("-isystem-after", 1, true) then
arg = "-I" .. arg:sub(15)
elseif arg:startswith("-isystem", 1, true) then
- -- clangd support `-isystem`, we need not translate it
+ -- clangd support `-isystem`, we don't need to translate it
-- @see https://github.com/xmake-io/xmake/issues/3020
if not lsp or lsp ~= "clangd" then
arg = "-I" .. arg:sub(9)
diff --git a/xmake/plugins/project/cmake/cmakelists.lua b/xmake/plugins/project/cmake/cmakelists.lua
index 12cec5bcb..6b62ebe8a 100644
--- a/xmake/plugins/project/cmake/cmakelists.lua
+++ b/xmake/plugins/project/cmake/cmakelists.lua
@@ -952,7 +952,7 @@ function _add_target_custom_commands_for_batchcmds(cmakelists, target, outputdir
end
if suffix == "before" then
-- ADD_CUSTOM_COMMAND and PRE_BUILD did not work as I expected,
- -- so we need use add_dependencies and fake target to support it.
+ -- so we need to use add_dependencies and fake target to support it.
--
-- @see https://gitlab.kitware.com/cmake/cmake/-/issues/17802
--
@@ -1052,7 +1052,7 @@ function _add_target(cmakelists, target, outputdir)
_add_target_dependencies(cmakelists, target)
-- add target custom commands
- -- we need call it first for running all rules, these rules will change some flags, e.g. c++modules
+ -- we need to call it first for running all rules, these rules will change some flags, e.g. c++modules
_add_target_custom_commands(cmakelists, target, outputdir)
-- add target precompilied header
diff --git a/xmake/plugins/project/ninja/build_ninja.lua b/xmake/plugins/project/ninja/build_ninja.lua
index fd3280b43..360bb075c 100644
--- a/xmake/plugins/project/ninja/build_ninja.lua
+++ b/xmake/plugins/project/ninja/build_ninja.lua
@@ -435,7 +435,7 @@ function make(outputdir)
-- open the build.ninja file
--
- -- we need change encoding to support msvc_deps_prefix
+ -- we need to change encoding to support msvc_deps_prefix
-- @see https://github.com/ninja-build/ninja/issues/613
--
-- TODO maybe we need support more encoding for other languages
diff --git a/xmake/plugins/project/utils/target_cmds.lua b/xmake/plugins/project/utils/target_cmds.lua
index e732f07d7..4c7f4f008 100644
--- a/xmake/plugins/project/utils/target_cmds.lua
+++ b/xmake/plugins/project/utils/target_cmds.lua
@@ -92,7 +92,7 @@ end
function get_target_buildcmd_sourcegroups(target, cmds, sourcegroups, suffix)
for idx, group in irpairs(sourcegroups) do
for _, item in pairs(group) do
- -- buildcmd scripts are always in rule, so we need ignore target item (item.target).
+ -- buildcmd scripts are always in rule, so we need to ignore target item (item.target).
local sourcebatch = item.sourcebatch
if item.rule then
if not _sourcebatch_is_built(sourcebatch) then
diff --git a/xmake/plugins/project/vstudio/impl/vs201x_solution.lua b/xmake/plugins/project/vstudio/impl/vs201x_solution.lua
index f482c1abd..ea2d8e1fa 100644
--- a/xmake/plugins/project/vstudio/impl/vs201x_solution.lua
+++ b/xmake/plugins/project/vstudio/impl/vs201x_solution.lua
@@ -37,7 +37,7 @@ function _make_projects(slnfile, vsinfo)
local targets = {}
local vctool = "8BC9CEB8-8B4A-11D0-8D11-00A0C91BC942"
for targetname, target in table.orderpairs(project.targets()) do
- -- we need set startup project for default or binary target
+ -- we need to set startup project for default or binary target
-- @see https://github.com/xmake-io/xmake/issues/1249
if target:get("default") == true then
table.insert(targets, 1, target)
diff --git a/xmake/plugins/project/vstudio/impl/vs201x_vcxproj.lua b/xmake/plugins/project/vstudio/impl/vs201x_vcxproj.lua
index b81e3bed7..1be380130 100644
--- a/xmake/plugins/project/vstudio/impl/vs201x_vcxproj.lua
+++ b/xmake/plugins/project/vstudio/impl/vs201x_vcxproj.lua
@@ -1114,7 +1114,7 @@ function _make_source_file_forall(vcxprojfile, vsinfo, target, sourcefile, sourc
-- for *.c/cpp/cu files
else
- -- we need use different object directory and allow parallel building
+ -- we need to use different object directory and allow parallel building
--
-- @see https://github.com/xmake-io/xmake/issues/2016
-- https://github.com/xmake-io/xmake/issues/1062
@@ -1246,7 +1246,7 @@ function _make_source_file_forspec(vcxprojfile, vsinfo, target, sourcefile, sour
-- for *.c/cpp/cu files
else
- -- we need use different object directory and allow parallel building
+ -- we need to use different object directory and allow parallel building
--
-- @see https://github.com/xmake-io/xmake/issues/2016
-- https://github.com/xmake-io/xmake/issues/1062
@@ -1347,7 +1347,7 @@ function _make_source_files(vcxprojfile, vsinfo, target)
local pcheader = target.pcxxheader or target.pcheader
vcxprojfile:enter("<ItemGroup>")
for _, includefile in ipairs(target.headerfiles) do
- -- we need ignore pcheader file to fix https://github.com/xmake-io/xmake/issues/1171
+ -- we need to ignore pcheader file to fix https://github.com/xmake-io/xmake/issues/1171
if not pcheader or includefile ~= pcheader then
_make_header_file(vcxprojfile, includefile, target.project_dir)
end
diff --git a/xmake/plugins/project/vsxmake/getinfo.lua b/xmake/plugins/project/vsxmake/getinfo.lua
index edc4a17b8..6fe8c7f90 100644
--- a/xmake/plugins/project/vsxmake/getinfo.lua
+++ b/xmake/plugins/project/vsxmake/getinfo.lua
@@ -541,7 +541,7 @@ function main(outputdir, vsinfo)
end
end
- -- we need set startup project for default or binary target
+ -- we need to set startup project for default or binary target
-- @see https://github.com/xmake-io/xmake/issues/1249
local targetnames = {}
for targetname, target in table.orderpairs(project.targets()) do
diff --git a/xmake/plugins/project/xcode/xcodeproj.lua b/xmake/plugins/project/xcode/xcodeproj.lua
index 6e3abe3da..15ba420f8 100644
--- a/xmake/plugins/project/xcode/xcodeproj.lua
+++ b/xmake/plugins/project/xcode/xcodeproj.lua
@@ -22,7 +22,7 @@
import(".cmake.cmakelists")
import("lib.detect.find_tool")
--- TODO maybe we need implement it by myself, do not use cmake
+-- TODO maybe we need to implement it by myself, do not use cmake
function make(outputdir)
-- check