summaryrefslogtreecommitdiff
path: root/xmake/toolchains
diff options
context:
space:
mode:
authorruki <[email protected]>2021-03-19 00:39:25 +0800
committerruki <[email protected]>2021-03-19 00:39:25 +0800
commit66a47b5aa01fc5ccd4897f6d81da4f9b6baab428 (patch)
tree6b3b6e2a68817a88f5eec8aee3a2983258e12926 /xmake/toolchains
parent7adbba0c3b57e0a58eaf00b8ab21db5bcffdf1fc (diff)
add some TODO comments
Diffstat (limited to 'xmake/toolchains')
-rw-r--r--xmake/toolchains/ndk/check.lua5
1 files changed, 4 insertions, 1 deletions
diff --git a/xmake/toolchains/ndk/check.lua b/xmake/toolchains/ndk/check.lua
index d7ecb4113..907d652c6 100644
--- a/xmake/toolchains/ndk/check.lua
+++ b/xmake/toolchains/ndk/check.lua
@@ -48,8 +48,9 @@ function _check_ndk(toolchain)
toolchain:config_set("ndk_toolchains_ver", ndk.toolchains_ver)
toolchain:config_set("ndk_sysroot", ndk.sysroot)
toolchain:configs_save()
+ return true
else
- --[[TODO
+ --[[TODO we need also add this tips when use remote ndk toolchain
-- failed
cprint("${bright color.error}please run:")
cprint(" - xmake config --ndk=xxx")
@@ -72,5 +73,7 @@ end
function main(toolchain)
_check_android_sdk(toolchain)
_check_ndk(toolchain)
+ -- TODO we should return the check result, but we need support builder with package first
+ -- so we need improve remote ndk toolchain
return true
end