From 28322db9b0c5ccee35c1445dfc567bea0d8ff072 Mon Sep 17 00:00:00 2001
From: A2va <49582555+A2va@users.noreply.github.com>
Date: Fri, 24 May 2024 18:13:50 +0200
Subject: Add icon banner

Then file icon is not working
---
 xmake/scripts/xpack/wix/msi.wxs | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/xmake/scripts/xpack/wix/msi.wxs b/xmake/scripts/xpack/wix/msi.wxs
index 82ec2e88a..dda4978a7 100644
--- a/xmake/scripts/xpack/wix/msi.wxs
+++ b/xmake/scripts/xpack/wix/msi.wxs
@@ -20,7 +20,11 @@
     <Package Language="1033" Manufacturer="$(PackageCompany)" Name="$(PackageName)" UpgradeCode="$(UpgradeCode)" Version="$(PackageVersion)">
         <MajorUpgrade DowngradeErrorMessage="A later version of $(PackageName) is already installed. Setup will now exit." />
         <?if $(PackageIconFile) != "" ?>  
-            <Icon Id="Icon.ico" SourceFile="$(PackageIconFile)"/>
+            <Icon Id="Icon" SourceFile="$(PackageIconFile)"/>
+            <Property Id="ARPPRODUCTICON" Value="Icon" />
+            <WixVariable Id="WixUIBannerBmp" Value="$(PackageIconFile)" />
+            <!-- Disable for now, because this is not pretty if the icon has a small resolution -->
+            <!-- <WixVariable Id="WixUIDialogBmp" Value="$(PackageIconFile)" /> -->
         <?endif ?>
         <MediaTemplate EmbedCab="true" />
         <WixVariable Id="WixUILicenseRtf" Value="$(PackageLicenseFile)" />
-- 
cgit v1.3.1