From 2a70793d5afbca2417bc65601f3a1785a1328d76 Mon Sep 17 00:00:00 2001
From: ruki <waruqi@gmail.com>
Date: Tue, 14 Nov 2023 23:21:00 +0800
Subject: improve uninstall

---
 xmake/scripts/xpack/nsis/makensis.nsi | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/xmake/scripts/xpack/nsis/makensis.nsi b/xmake/scripts/xpack/nsis/makensis.nsi
index 8bddfd54a..77b3c10fa 100644
--- a/xmake/scripts/xpack/nsis/makensis.nsi
+++ b/xmake/scripts/xpack/nsis/makensis.nsi
@@ -52,7 +52,9 @@ RequestExecutionLevel user
 ManifestDPIAware true
 
 ; set icon
-!define MUI_ICON "${PACKAGE_ICONFILE}"
+!if "${PACKAGE_ICONFILE}" != ""
+  !define MUI_ICON "${PACKAGE_ICONFILE}"
+!endif
 
 ; UAC
 !macro Init thing
@@ -305,5 +307,8 @@ Section "Uninstall"
     ${WordReplace} $R0 ";$InstDir" "" "+" $R1
     WriteRegExpandStr ${HKCU} "Environment" "Path" "$R1"
   ${EndIf}
+
+  ; remove uninstall.exe
+  Delete "$InstDir\uninstall.exe"
 SectionEnd
 
-- 
cgit v1.3.1