From 1b03d8e117a718965707d98b679eca2678dc02a1 Mon Sep 17 00:00:00 2001 From: Francesco Guastella Date: Thu, 2 Oct 2025 14:09:46 +0200 Subject: fix(package): write manifest.pathenvs in deterministic order --- xmake/core/package/package.lua | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/xmake/core/package/package.lua b/xmake/core/package/package.lua index db943815a..7be3278b1 100644 --- a/xmake/core/package/package.lua +++ b/xmake/core/package/package.lua @@ -994,7 +994,17 @@ function _instance:manifest_save() manifest.mode = self:mode() manifest.configs = self:configs() manifest.envs = self:_rawenvs() - manifest.pathenvs = self:_pathenvs():to_array() + + -- ensure pathenvs are written deterministically: use ordered iteration + do + local arr = {} + for name in self:_pathenvs():orderitems() do + if name ~= nil then + table.insert(arr, name) + end + end + manifest.pathenvs = arr + end -- save enabled library deps if self:librarydeps() then -- cgit v1.3.1 From fa3b93a9d44d8f9740f45a0e6ca9476a3f1ecdf0 Mon Sep 17 00:00:00 2001 From: Francesco Guastella Date: Thu, 2 Oct 2025 15:04:39 +0200 Subject: Use table.to_array --- xmake/core/package/package.lua | 12 ++---------- 1 file changed, 2 insertions(+), 10 deletions(-) diff --git a/xmake/core/package/package.lua b/xmake/core/package/package.lua index 7be3278b1..da2544d08 100644 --- a/xmake/core/package/package.lua +++ b/xmake/core/package/package.lua @@ -995,16 +995,8 @@ function _instance:manifest_save() manifest.configs = self:configs() manifest.envs = self:_rawenvs() - -- ensure pathenvs are written deterministically: use ordered iteration - do - local arr = {} - for name in self:_pathenvs():orderitems() do - if name ~= nil then - table.insert(arr, name) - end - end - manifest.pathenvs = arr - end + -- ensure pathenvs are written deterministically + manifest.pathenvs = table.to_array(self:_pathenvs():orderitems()) -- save enabled library deps if self:librarydeps() then -- cgit v1.3.1